From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B5532E5B2A for ; Tue, 23 Jun 2026 10:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782212270; cv=none; b=a/8oZ1nj4UBoDeAZ+zbeddDltsEP0MAYpXObOUA6824I8LXXA5E1ac540QD+0EYDDAVGAk+sjVVX6anGAhsJmnSccczdN/gVYjXIV/H7PlGnz/pi+0JBNh+p6tSfKNvkwqZ4nLRau2yIIOJR8suIbd826PF4vxu2I6ewPBaW7Mo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782212270; c=relaxed/simple; bh=IOBxnOtMshhbTfhP8u/coiEFsQzAKQdVCSVyXJW+724=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j9sYWr3k8xzyPWptxIWWLmz9Cpf7WAS6Cs2aVvH2UAf+bD6DTlooJtHd5UEwIlt3qt7lDiLG4VHlnnEu+hbWye0sHAaOF8e6aEIU3UlJH/T4Anm4IZa2nuuBR/IqK3ltG9anQhar8d4EXIDw62eCpQrTzxB6Wy/rDDD6BLkQJy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oxnjHKaW; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oxnjHKaW" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-84536ecfc5bso4846081b3a.2 for ; Tue, 23 Jun 2026 03:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782212269; x=1782817069; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4EB+eP0FgMbygYM0Y8vrQyXLJ+2AgLlhtsqyywSd5+U=; b=oxnjHKaWP2Krh50cxQSRqMN2mUo/Q3piOWLKps2bz2Ar8GQ+KEhJ1IDf3LKTSc7KRl 4a7IoYz5RtAv8i7dTrcYTAkeyVLyLbOFdQ90OVpMJkOs8s1rZYEp/P5YgR4iVSd2EuuL 0GlmUuAS7fsNcrNARGJDI/V+6MdIVgBWVbnvqN4oHzkgJ2vJBnSD8ORGf6hH0A7QG1Wy j2fhdEpszgPxxbsBgNOQZeI5ZPVXoKDoLU4tojJNKLUk8yW3FpVrAmmJ3eVIXOiO4TlC 2XoZQsqPfO4fQ4N58Vjqmg/YL/Lz1UTfVPJDaP99E1+5QtY0OHqFQcves14dT0ViaHWT lA9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782212269; x=1782817069; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4EB+eP0FgMbygYM0Y8vrQyXLJ+2AgLlhtsqyywSd5+U=; b=LVlcUfgYV5nOxbh6d4lknLh1LKttgeeCJ4aNnBcWnrBCYo76HKim04TvtOXOYR5RG7 8kRyCr7mLOuyKExlSc/Ozxo2QVn4g9W0mnFqb68JIABgq58kAZug1fDScRtjvKum3oRj ABSoCyGPU/4PTOc/Kj4ZYQAFw29rOlBT0RUYKzW6Wu42qP+7mbCpYaxr5jk528AbbaOJ G7Tz1rBvWiwRwAoLpKtLV83zakUeIGg2L7pAvpZwVpwlBj/l7wP3jm96lvglKMnJ2qmO ZksJnirXWpsOUkqnvbHCam6tuTo8WJyOPimL8/4F+dfEOLKnVYb+wmleqibwPv95sO0m ioiA== X-Forwarded-Encrypted: i=1; AHgh+RrZWtwfxaCn+goV0FQHby4neoh62ileuJX+n+xpdVT9Ejc5vAZTppQurBYpkyT8JGcoIRBFcyW9GS6Nxh0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4FOKAoSCeLb6shM/dXSkbRLRLuQ9H3Mcc4jqzhjFt8t14nOOs n63K+wZ8VfhUDqAyt093jdserjMcFOqsKcGMWZ+CWnoIcIzYkb3F1RX0sEjobw== X-Gm-Gg: AfdE7cmFEimtkVP9O9M2dwP72weTdMVNFvxxqjx7EGojycGryIvI7lSkoRcoVzr6las qbYjDsKxsvmnQBT2U6oX45fAactipS0Bf/nfQKFnlSem/LN2UpxDXpkIEhrF1vaPzzuUFJlWRqB UV7cfB3OzcEj1zVRwyS8wrJV91FILn0T361PN+DNV/jvWheLdb4qLnDm0XtbobI7CPtFnFXc8qh nHTuuAn7Xc87u5zWVE8B6sMed2GkHxvI9KzresX5u90edyUuN4/xhwaR3q7bnzFjrHKpf8iXVEr 8W9YgkR41A2s+v1c/0M7EKbl3pMI0WJnKbWNyEezw+anEki3pdcu9s3mUbpRh0c1yVf2YLmulNL 7TTSoKK0wNUavGSiD3SHG34kwG3QAiXN2lo13HIlHYbWm6BgKSN5S23f4zMGNIa8194MASZyTMS 4igN7N3wcAd1ouF2cbZytG+DgeggCpxlL1pfbZzPXNh/ruuI3pKirz93MX1g== X-Received: by 2002:a05:6a00:2e9a:b0:841:dca1:8b69 with SMTP id d2e1a72fcca58-8459700cb26mr2409225b3a.5.1782212268677; Tue, 23 Jun 2026 03:57:48 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564d68130sm12343868b3a.10.2026.06.23.03.57.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 03:57:48 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Cezary Rojewski Cc: Jaroslav Kysela , Takashi Iwai , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 1/5] ASoC: intel: sst-mfld-platform-pcm: Use __free(kfree) for stream pointer Date: Tue, 23 Jun 2026 17:57:17 +0700 Message-ID: <20260623105721.25865-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260623105721.25865-1-phucduc.bui@gmail.com> References: <20260623105721.25865-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Declare 'stream' with __free(kfree) so it is automatically freed when leaving scope. This allows direct returns from error paths and removes the explicit kfree(stream) call. Set 'stream' to NULL after ownership has been transferred to runtime->private_data to prevent it from being freed on the success path. Signed-off-by: bui duc phuc --- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/sound/soc/intel/atom/sst-mfld-platform-pcm.c b/sound/soc/intel/atom/sst-mfld-platform-pcm.c index f074af2499c8..47823443354c 100644 --- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c +++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c @@ -304,7 +304,7 @@ static int sst_media_open(struct snd_pcm_substream *substream, { int ret_val = 0; struct snd_pcm_runtime *runtime = substream->runtime; - struct sst_runtime_stream *stream; + struct sst_runtime_stream *stream __free(kfree) = NULL; stream = kzalloc_obj(*stream); if (!stream) @@ -330,7 +330,7 @@ static int sst_media_open(struct snd_pcm_substream *substream, ret_val = power_up_sst(stream); if (ret_val < 0) - goto out_power_up; + return ret_val; /* * Make sure the period to be multiple of 1ms to align the @@ -347,12 +347,19 @@ static int sst_media_open(struct snd_pcm_substream *substream, snd_pcm_hw_constraint_step(substream->runtime, 0, SNDRV_PCM_HW_PARAM_PERIODS, 2); - return snd_pcm_hw_constraint_integer(runtime, - SNDRV_PCM_HW_PARAM_PERIODS); + ret_val = snd_pcm_hw_constraint_integer(runtime, + SNDRV_PCM_HW_PARAM_PERIODS); + + if (ret_val < 0) + return ret_val; + + stream = NULL; + + return ret_val; + out_ops: mutex_unlock(&sst_lock); -out_power_up: - kfree(stream); + return ret_val; } -- 2.43.0