From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9C013C661A for ; Tue, 23 Jun 2026 12:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782216936; cv=none; b=fsr0iKrtTqtb8QxZLvvva6aHvhpSrKSN8YLfdGMZn98eUxbMhQ6/HiCTVp3l22ys81N1vBrYuia/jHSfML40Q1w3Ls+ICj79GMpRzU1bKTpW8V5/up5Nnd7CMUglvJE6oRUe+Uh/VHqd81tSCckqGB9uWM+dpwIzqnwZNs8Hzio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782216936; c=relaxed/simple; bh=0PskQQaOeX5KTenREHspdZ8Fn0M9xcrcducjtdHTohQ=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=gPRrX6OCiDaD67X104zxt06+w/W21jq8niaACuB6UPmW+5L/ilIa3/IyteR77MglfUv6xOw76+koI47E6iXeWqHka2qsnQ1XTBjOSadEjlnpFiTYinXnzNvCXqFmx4QY8EaVf6lc/ZsN7r7wMxUQhwVpNxNPef6izEmB1GIGC5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P4fB47qI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P4fB47qI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22A601F000E9; Tue, 23 Jun 2026 12:15:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782216935; bh=ZKb9R2k+KiLQsQ5MQpTxDmKoG1Qx90CZZkVGXnK3sCU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=P4fB47qIpTZ0DS04Qr07WdB9wL6SPmjjOglH2C5HBBrdMj4coHLVy63PVBErsf95G fxjK336IdQd8CPazmPvPAudbw8fpmj3M3BwqxGnRl9aOsQD9pS0Z9E7nn0hJlXIf1W ovwp2apmq+PwLzjNy3bHUXZGS06J6CGCznDsYeXqYv84Oz7/F2x7z0lvUk82XyXzn9 KLCPyOi9eF0CISEjwCNH4/h3ReSgST1F2+haPQeYX7Nkr0Ojqyvv1/LR0XmGRhZpFB t5F1wtjDsl7y+9AFV7MLGR6ggWticoJDqb3aYChAPB/KWlo9zF2ZuCPxcZqtPJSbeV 3/eDd0EafgdwA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 07/12] ARM: dts: microchip: sama7d65: Add ADC node Reply-To: sashiko-reviews@lists.linux.dev To: "Varshini Rajendran" Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260623105944.128840-8-varshini.rajendran@microchip.com> References: <20260623105944.128840-1-varshini.rajendran@microchip.com> <20260623105944.128840-8-varshini.rajendran@microchip.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 23 Jun 2026 12:15:34 +0000 Message-Id: <20260623121535.22A601F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The patch introduces a new `vddout25` fixed regulator node in `s= ama7d65.dtsi`, but this addition is completely undocumented in the commit m= essage, which exclusively mentions adding the ADC node. -- commit ee5a93263289a5fcd9ba9faf0c09df7c63701b1d Author: Varshini Rajendran ARM: dts: microchip: sama7d65: Add ADC node This commit adds the device tree node for the ADC controller in the sama7d65 SoC. > diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dt= s/microchip/sama7d65.dtsi > index 94d49e20dc794..ba775459a816e 100644 > --- a/arch/arm/boot/dts/microchip/sama7d65.dtsi > +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi [ ... ] > @@ -95,6 +96,16 @@ slow_xtal: clock-slowxtal { > }; > }; > =20 > + vddout25: fixed-regulator-vddout25 { > + compatible =3D "regulator-fixed"; > + > + regulator-name =3D "VDDOUT25"; [Severity: Medium] Is this regulator intentionally included in this patch? The commit message exclusively mentions adding the ADC node, but this adds a new root-level vddout25 fixed regulator node. Should this be split into a separate commit or documented in the commit message? > + regulator-min-microvolt =3D <2500000>; > + regulator-max-microvolt =3D <2500000>; > + regulator-boot-on; > + status =3D "disabled"; > + }; > + > ns_sram: sram@100000 { [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260623105944.1288= 40-1-varshini.rajendran@microchip.com?part=3D7