From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4304CDB46F for ; Tue, 23 Jun 2026 11:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T+2LJtkZOo7zVvvD1fwQYUjIghWRLRNZtms8N1waA6U=; b=y12M3+YxrRjR34+gvED6AOp2xU yxSFjjJBi2VH6SCumleHm42eaStSbpGwplhX8cr50vbvSs+vXSIUCwLfzco0VCqX8GvSkY+OYr+X3 yp8y/+UNxDAPNJtYlNFIFA5gKzFvl4MQ6NMYnxHLeh5WSs/desoyw4DeR7f/nc27BhBRy4IzGcuv5 LJSavDcUK/cUTlQCxN3wvJwpAXJV14OwtYMsqLNO4jJ0PCkL9s7Fms6TzbMgFz18VTqHibVpX6pZd ekxLSAxEzgc3Mpyd8XSAGUFwn9YXELVgn1/IECwCU5tqNOHfkCHRe2s3SXc5E+ZiApQXy0oCmDJ7P L6S8PEKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wbzWe-00000006C5y-3qVg; Tue, 23 Jun 2026 11:42:44 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wbzWd-00000006C5s-20Rs for linux-arm-kernel@lists.infradead.org; Tue, 23 Jun 2026 11:42:43 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 6706360052; Tue, 23 Jun 2026 11:42:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DC6C1F000E9; Tue, 23 Jun 2026 11:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1782214962; bh=T+2LJtkZOo7zVvvD1fwQYUjIghWRLRNZtms8N1waA6U=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=husrEPyQ2uYygUyC/f+DdU6YkHNgkUoAcJ53B3wKd+OCJZtia4DvbvHWZobWxUG00 qCc4mxz07jLBpIkSGfCugsFmL5+n6eAPwR2uICfYLiO5mNhDVp9v3BQ1BN8JvIrxwE YEbOWWSzigFk8cCUNb0mnTBqIjoRlmwwlHJn+Hfg= Date: Tue, 23 Jun 2026 13:41:31 +0200 From: Greg Kroah-Hartman To: Ben Dooks Cc: Thinh Nguyen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-usb@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] usb: dwc3: imx8mp: make dwc3_imx_glue_ops static and rename to imx8mp Message-ID: <2026062313-poker-closable-d9d0@gregkh> References: <20260623101043.748359-1-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260623101043.748359-1-ben.dooks@codethink.co.uk> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 23, 2026 at 11:10:43AM +0100, Ben Dooks wrote: > The dwc3_imx_glue_ops is not used outside this file, and technically this > is the dwc3-imx8mp driver so whilst making this static to avoid the > following warning, rename it dwc3_imx8mp_glue_ops to distinguish it from > the other driver which also has dwc3_imx_glue_ops. > > Fixes: > drivers/usb/dwc3/dwc3-imx8mp.c:176:22: warning: symbol 'dwc3_imx_glue_ops' was not declared. Should it be static? > > Signed-off-by: Ben Dooks > --- > drivers/usb/dwc3/dwc3-imx8mp.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c > index 1cf96540b66e..de8c17bc940d 100644 > --- a/drivers/usb/dwc3/dwc3-imx8mp.c > +++ b/drivers/usb/dwc3/dwc3-imx8mp.c > @@ -158,7 +158,7 @@ static irqreturn_t dwc3_imx8mp_interrupt(int irq, void *_dwc3_imx) > return IRQ_HANDLED; > } > > -static void dwc3_imx_pre_set_role(struct dwc3 *dwc, enum usb_role role) > +static void dwc3_imx8mp_pre_set_role(struct dwc3 *dwc, enum usb_role role) > { > if (role == USB_ROLE_HOST) > /* > @@ -173,8 +173,8 @@ static void dwc3_imx_pre_set_role(struct dwc3 *dwc, enum usb_role role) > pm_runtime_use_autosuspend(dwc->dev); > } > > -struct dwc3_glue_ops dwc3_imx_glue_ops = { > - .pre_set_role = dwc3_imx_pre_set_role, > +static struct dwc3_glue_ops dwc3_imx8mp_glue_ops = { > + .pre_set_role = dwc3_imx8mp_pre_set_role, > }; > > static int dwc3_imx8mp_probe(struct platform_device *pdev) > @@ -266,7 +266,7 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev) > goto put_dwc3; > } > > - dwc3->glue_ops = &dwc3_imx_glue_ops; > + dwc3->glue_ops = &dwc3_imx8mp_glue_ops; > > if (dwc3->dr_mode == USB_DR_MODE_HOST) > pm_runtime_dont_use_autosuspend(dwc3->dev); > -- > 2.37.2.352.g3c44437643 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot