All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: sashiko-bot@kernel.org
Cc: SeongJae Park <sj@kernel.org>, damon@lists.linux.dev
Subject: Re: [RFC PATCH v1.3] mm/damon/ops-common: handle extreme intervals in damon_hot_score()
Date: Tue, 23 Jun 2026 06:42:03 -0700	[thread overview]
Message-ID: <20260623134204.66401-1-sj@kernel.org> (raw)
In-Reply-To: <20260623013428.4A8D61F000E9@smtp.kernel.org>

On Tue, 23 Jun 2026 01:34:24 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
> 
> Pre-existing issues:
> - [High] The `age_in_sec` calculation silently overflows on 32-bit architectures, breaking age-based subscores.
> - [Medium] Multiplication of `r->nr_accesses` by `DAMON_MAX_SUBSCORE` silently overflows 32-bit arithmetic for heavily accessed regions, breaking hotness scoring.
> - [Medium] Weighted average calculation in `damon_hot_score` can overflow if large weights are provided via sysfs.

All of these require unnormal user setup, and causes only monitoring results
accuracy degradation rather than some criticial issues like panic or memory
corruption.  No blocker.


Thanks,
SJ

[...]

      reply	other threads:[~2026-06-23 13:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23  1:16 [RFC PATCH v1.3] mm/damon/ops-common: handle extreme intervals in damon_hot_score() SeongJae Park
2026-06-23  1:34 ` sashiko-bot
2026-06-23 13:42   ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260623134204.66401-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=sashiko-bot@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.