From: Stephen Hemminger <stephen@networkplumber.org>
To: Mark Blasko <blasko@google.com>
Cc: dev@dpdk.org, Ciara Loftus <ciara.loftus@intel.com>,
Maryam Tahhan <mtahhan@redhat.com>,
Joshua Washington <joshwash@google.com>,
"Jasper Tran O'Leary" <jtranoleary@google.com>
Subject: Re: [PATCH] net/af_xdp: add Rx metadata and dynamic timestamping support
Date: Tue, 23 Jun 2026 15:06:38 -0700 [thread overview]
Message-ID: <20260623150638.266d8574@phoenix.local> (raw)
In-Reply-To: <20260623215325.814776-1-blasko@google.com>
On Tue, 23 Jun 2026 21:53:24 +0000
Mark Blasko <blasko@google.com> wrote:
> + if (rxq->rx_timestamp_enabled &&
> + timestamp_dynfield_offset >= 0) {
> + struct af_xdp_rx_metadata *meta;
> +
> + meta = (struct af_xdp_rx_metadata *)
> + ((char *)rte_pktmbuf_mtod(bufs[i], void *) -
> + sizeof(struct af_xdp_rx_metadata));
> + *RTE_MBUF_DYNFIELD(bufs[i],
> + timestamp_dynfield_offset,
> + uint64_t *) = meta->rx_timestamp;
> + bufs[i]->ol_flags |= timestamp_dynflag;
> + }
> +
Why does XDP time stamp need to be different than how other drivers
already do timestamps. See AF_PACKET and TAP device?
Should not be driver specific here.
prev parent reply other threads:[~2026-06-23 22:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 21:53 [PATCH] net/af_xdp: add Rx metadata and dynamic timestamping support Mark Blasko
2026-06-23 22:06 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260623150638.266d8574@phoenix.local \
--to=stephen@networkplumber.org \
--cc=blasko@google.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=joshwash@google.com \
--cc=jtranoleary@google.com \
--cc=mtahhan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.