All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: sashiko-bot@kernel.org
Cc: SeongJae Park <sj@kernel.org>, damon@lists.linux.dev
Subject: Re: [PATCH v2] mm/damon/ops-common: handle extreme intervals in damon_hot_score()
Date: Tue, 23 Jun 2026 08:08:21 -0700	[thread overview]
Message-ID: <20260623150821.74292-1-sj@kernel.org> (raw)
In-Reply-To: <20260623141527.044D11F000E9@smtp.kernel.org>

On Tue, 23 Jun 2026 14:15:26 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> 
> Pre-existing issues:
> - [High] Multiplication in `freq_subscore` calculation overflows 32-bit `unsigned int` for extreme intervals, reversing region hotness prioritization.
> - [High] User-supplied sysfs weights can overflow, resulting in a bypassed division and Signed Integer Overflow (UB).

Sashiko acknowledges both are pre-existing issue, so no blocker for this patch.

Also, both issues happen only under extreme and never common user setups, and
causing only DAMON internal behavioral degradation.  No critical issues like
panic or memory corruption will happen.  These are known low priority issues,
not a blocker of this patch.


Thanks,
SJ

[...]

      reply	other threads:[~2026-06-23 15:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23 13:58 [PATCH v2] mm/damon/ops-common: handle extreme intervals in damon_hot_score() SeongJae Park
2026-06-23 14:15 ` sashiko-bot
2026-06-23 15:08   ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260623150821.74292-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=sashiko-bot@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.