From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Hanna Reitz" <hreitz@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
qemu-block@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH] iotests: increase timeouts for tests to 5 minutes
Date: Tue, 23 Jun 2026 17:03:26 +0100 [thread overview]
Message-ID: <20260623160326.2346255-1-berrange@redhat.com> (raw)
Currently we have tests timeout set to 3 minutes, on the basis
that they're generally done in less than a minute. I've hit a
couple of random failures suggesting that's not sufficiently
pessimistic. Increase the timeout to 5 minutes to have a greater
safety net in high load scenarios.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/qemu-iotests/meson.build | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
index bc6132a0f7..8857f25f29 100644
--- a/tests/qemu-iotests/meson.build
+++ b/tests/qemu-iotests/meson.build
@@ -52,16 +52,17 @@ foreach driver, speed: qemu_iotests_drivers
'-tap', '-' + driver, item,
'--source-dir', meson.current_source_dir(),
'--build-dir', meson.current_build_dir()]
- # Some individual tests take as long as 45 seconds
- # Bump the timeout to 3 minutes for some headroom
- # on slow machines to minimize spurious failures
+ # Some individual tests take as long as 3 minutes
+ # in high load scenarios. Bump the timeout to 5
+ # minutes for some headroom on slow / loaded
+ # machines to minimize spurious failures
test('io-' + driver + '-' + item,
python,
args: args,
depends: qemu_iotests_binaries,
env: qemu_iotests_env,
protocol: 'tap',
- timeout: 180,
+ timeout: 300,
suite: suites)
endforeach
endif
@@ -94,16 +95,14 @@ foreach driver, speed: qemu_iotests_drivers
'-tap', '-' + driver, item,
'--source-dir', meson.current_source_dir(),
'--build-dir', meson.current_build_dir()]
- # Some individual tests take as long as 45 seconds
- # Bump the timeout to 3 minutes for some headroom
- # on slow machines to minimize spurious failures
+ # See earlier note about timeouts
test('io-' + driver + '-' + item,
python,
args: args,
depends: qemu_iotests_binaries,
env: qemu_iotests_env,
protocol: 'tap',
- timeout: 180,
+ timeout: 300,
suite: suites)
endforeach
endforeach
--
2.54.0
next reply other threads:[~2026-06-23 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 16:03 Daniel P. Berrangé [this message]
2026-07-16 10:15 ` [PATCH] iotests: increase timeouts for tests to 5 minutes Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260623160326.2346255-1-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.