Re: [PATCH v6 6/8] Documentation: bootconfig: document build-time cmdline rendering

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The documentation for CONFIG_CMDLINE_FROM_BOOTCONFIG omits the Kconfig requirement that CONFIG_CMDLINE must be empty.
--

commit 7ac5b833fb6889abf419a5e5890a63a00f59d74e
Author: Breno Leitao <leitao@debian.org>

Documentation: bootconfig: document build-time cmdline rendering

This commit adds documentation describing the CONFIG_CMDLINE_FROM_BOOTCONFIG
option, explaining its build-time rendering behavior, requirements, opt-in
semantics, and how it interacts with other command line sources.

> diff --git a/Documentation/admin-guide/bootconfig.rst b/Documentation/admin-guide/bootconfig.rst
> index f712758472d5c..349cefbb2bbcd 100644
> --- a/Documentation/admin-guide/bootconfig.rst
> +++ b/Documentation/admin-guide/bootconfig.rst
[ ... ]
> +``CONFIG_CMDLINE_FROM_BOOTCONFIG`` resolves this by rendering the
> +``kernel`` subtree of ``CONFIG_BOOT_CONFIG_EMBED_FILE`` into a flat cmdline
> +string at kernel build time (via ``tools/bootconfig -C``) and prepending
> +it to ``boot_command_line`` during early architecture setup, so the keys
> +are visible to ``parse_early_param()``.
> +
> +The option requires ``CONFIG_BOOT_CONFIG_EMBED=y``, a non-empty
> +``CONFIG_BOOT_CONFIG_EMBED_FILE``, and an architecture that selects
> +``CONFIG_ARCH_SUPPORTS_CMDLINE_FROM_BOOTCONFIG``. Currently only x86

[Severity: Low]
Should this also mention the requirement that CONFIG_CMDLINE must be empty?

Users might satisfy all the explicitly listed requirements but still find the
option hidden in menuconfig if their kernel is configured with a non-empty
built-in command line, because the Kconfig rule uses depends on CMDLINE = "".

> +selects it; on other architectures the embedded bootconfig still works,
> +but only through the late runtime parser.
> +
> +The same ``bootconfig`` opt-in applies as elsewhere: the rendered keys
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260623-bootconfig_using_tools-v6-0-640c2f587a3c@debian.org?part=6