From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 144D7CDB471 for ; Wed, 24 Jun 2026 11:42:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wcM09-00082X-A8; Wed, 24 Jun 2026 07:42:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wcLzs-0007oj-Bw for qemu-devel@nongnu.org; Wed, 24 Jun 2026 07:42:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wcLzp-0007ei-NK for qemu-devel@nongnu.org; Wed, 24 Jun 2026 07:42:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782301339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TewsrQjOEEfUbtJfnRuG82VZIS4a9rgFezYVmFt14qI=; b=go8UpGPnPnYN2UqeGKO/K04pAPUwK51nkIGSs16rASu7AVXf406HF7WImo5djvBErl1db7 zzrWY5KUFB/xfoP3qXmJAowPGdaIlFN6FTcZZUed1BRV/UwxPjUz/nMLi17Dvkdfi/WthM ALFKGEzYWHEwYhtuUCFiboYUMpS+G1E= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-KFn8AkvCO2Sp9_3PnuXetw-1; Wed, 24 Jun 2026 07:42:17 -0400 X-MC-Unique: KFn8AkvCO2Sp9_3PnuXetw-1 X-Mimecast-MFC-AGG-ID: KFn8AkvCO2Sp9_3PnuXetw_1782301337 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0421A1955D97 for ; Wed, 24 Jun 2026 11:42:17 +0000 (UTC) Received: from localhost (unknown [10.44.24.16]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7FA1E30001A7; Wed, 24 Jun 2026 11:42:15 +0000 (UTC) From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Wed, 24 Jun 2026 15:41:30 +0400 Subject: [GIT PULL 08/35] util: make notifer_remove() safer MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260624-ui-v1-8-482147b0a7af@redhat.com> References: <20260624-ui-v1-0-482147b0a7af@redhat.com> In-Reply-To: <20260624-ui-v1-0-482147b0a7af@redhat.com> To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi X-Developer-Signature: v=1; a=openpgp-sha256; l=793; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=yLgBs2ho0OvcmQtzdxufCxHOw5F5fjwZkyxkY+89Asc=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqO8JnyvMbRCKXmDk5vL/EMP1dsB34XMyTJfzoh hv8hrO0j/+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCajvCZwAKCRDa6OEJdZac 5SOzEACnILAM/66Azt1a8OmsvOjvrSTFVVZysEDW3cKIOf+uzpuGPbR9JrYI5gq31n9YgKw0vMO UWiHrmEtcbF55n6lLhxsN+sKZRoX0r9dqwR4nrrTjcMnCKATPrmz6MRlyHmN9XItAbtFqjiOMBf Ratj7ZdfxqBNJhJBqjOTTYenhBt1o5MVaX+gAFdvTQT+ITVF+khtSKairsw8DdrGLzDJo6QNjiI QwVZQOokhf6Fcu8WTgTNp2wObpy/TADof0orcfmNfzvPyXp/aoPkUaCBe2VwDuAVR/OJmEEP7hH g+xf6/qMUFX2v0nYRuhw/LPXIrw03G9sRm+0MmBWj6y+1+j58O/OyGPqHUiQ5cWnFziBlg+3PJd Zin5b6RStNcmb6jkbIlY9DM/e5+dRAwvgpsPU+XNvOrwgBpdRP4IDqa0Brz1c6BwsDNblJBk0ze f0T0G3jKqg+tNh/l6/XFy/AAmDuP4LnWRoIotWRrA5Dt5tmYq6bn6B662SGoT+BTgYPelbpI0as /+Ujrw2yJvkTvaVnL5KKnVuJdLKMm7vNVPTCGpX+EwT+OjgnwM9g2ItgGXMAxNEKznLpUuVoAea IHuAtiMUTXacOXcKdf4/FwwI5QOKiIy9nbbIXFJy8yqJpHt3iOafZN1b0H9BITYwi4SqjJukA5m YaWRcJQUQjt56iA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Allow to call multiple time notifier_remove() safely. This shoudn't impact performance in any measurable way... Reviewed-by: Akihiko Odaki Signed-off-by: Marc-André Lureau Message-ID: <20260623-b4-ui-v4-8-4656aec3398d@redhat.com> --- util/notify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/notify.c b/util/notify.c index c6e158ffb33..24420a7288e 100644 --- a/util/notify.c +++ b/util/notify.c @@ -28,7 +28,7 @@ void notifier_list_add(NotifierList *list, Notifier *notifier) void notifier_remove(Notifier *notifier) { - QLIST_REMOVE(notifier, node); + QLIST_SAFE_REMOVE(notifier, node); } void notifier_list_notify(NotifierList *list, void *data) -- 2.54.0