All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Rqirus <cmh79479@gmail.com>
Cc: Andreas Noever <andreas.noever@gmail.com>,
	Michael Jamet <michael.jamet@intel.com>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: xdomain: notify peers after enumeration
Date: Wed, 24 Jun 2026 07:07:53 +0200	[thread overview]
Message-ID: <20260624050753.GG3066@black.igk.intel.com> (raw)
In-Reply-To: <20260624011131.2532004-1-cmh79479@gmail.com>

Hi,

On Wed, Jun 24, 2026 at 09:11:31AM +0800, Rqirus wrote:
> Service drivers may register local XDomain properties while discovery is
> still in progress. This can cause the properties changed notification to be
> sent before the peer is ready to act on it.
> 
> If the peer has already read the local property block before the service
> was registered, it may keep using the old property generation and miss the
> newly registered service. With ThunderboltIP this can leave the network
> service half-discovered after a warm reboot and the login request
> eventually times out.
> 
> Queue another properties changed notification after the XDomain reaches
> ENUMERATED so the peer can re-read the final local properties.
> 
> Signed-off-by: Rqirus <cmh79479@gmail.com>

You should be using your full name here.

The patch itself looks reasonable to me.

> ---
>  drivers/thunderbolt/xdomain.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c
> index 86b2f7474..9c068d073 100644
> --- a/drivers/thunderbolt/xdomain.c
> +++ b/drivers/thunderbolt/xdomain.c
> @@ -1811,6 +1811,7 @@ static void tb_xdomain_state_work(struct work_struct *work)
>  			tb_xdomain_failed(xd);
>  		} else {
>  			xd->state = XDOMAIN_STATE_ENUMERATED;
> +			tb_xdomain_queue_properties_changed(xd);
>  		}
>  		break;
>  
> 
> base-commit: 502d801f0ab03e4f32f9a33d203154ce84887921
> -- 
> 2.47.3

      reply	other threads:[~2026-06-24  5:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24  1:11 [PATCH] thunderbolt: xdomain: notify peers after enumeration Rqirus
2026-06-24  5:07 ` Mika Westerberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260624050753.GG3066@black.igk.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=cmh79479@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michael.jamet@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.