All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhang Chen <zhangckid@gmail.com>
To: qemu-devel <qemu-devel@nongnu.org>,
	"Dr . David Alan Gilbert" <dave@treblig.org>,
	Eric Blake <eblake@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>, Jason Wang <jasowang@redhat.com>,
	Fam Zheng <fam@euphon.net>
Cc: Zhang Chen <zhangckid@gmail.com>
Subject: [PATCH V9 07/17] monitor: support iothread ref/unref for anonymous monitors
Date: Wed, 24 Jun 2026 15:08:41 +0800	[thread overview]
Message-ID: <20260624070851.13342-8-zhangckid@gmail.com> (raw)
In-Reply-To: <20260624070851.13342-1-zhangckid@gmail.com>

Implement iothread registration and unregistration within monitor data lifecycle
helpers using IOThreadHolder.

When an explicit monitor ID is missing, fall back to utilizing the chardev
label as a safe identifier for iothread_ref/put operations. This enables
accurate tracking for anonymous monitors while keeping 'mon->id' as NULL.

Signed-off-by: Zhang Chen <zhangckid@gmail.com>
---
 monitor/monitor.c | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/monitor/monitor.c b/monitor/monitor.c
index 65749f931e..c3eec8c069 100644
--- a/monitor/monitor.c
+++ b/monitor/monitor.c
@@ -612,8 +612,18 @@ void monitor_data_init(Monitor *mon, bool is_qmp, bool skip_flush,
 {
     mon->id = id ? g_strdup(id) : NULL;
 
-    if (use_io_thread && !mon_iothread) {
-        monitor_iothread_init();
+    if (use_io_thread) {
+        if (!mon_iothread) {
+            monitor_iothread_init();
+        }
+
+        /* Setup the chr->label as the backup ID for iothread_ref/unref */
+        IOThreadHolder holder = {
+            .type = IO_THREAD_HOLDER_KIND_MONITOR_NAME,
+            .u.monitor_name.monitor_name = id ? (char *)mon->id :
+                                                (char *)mon->chr.chr->label,
+        };
+        iothread_ref_and_get_aio_context(mon_iothread, &holder);
     }
     qemu_mutex_init(&mon->mon_lock);
     mon->is_qmp = is_qmp;
@@ -624,6 +634,16 @@ void monitor_data_init(Monitor *mon, bool is_qmp, bool skip_flush,
 
 void monitor_data_destroy(Monitor *mon)
 {
+    if (mon->use_io_thread && mon_iothread) {
+        IOThreadHolder holder = {
+            .type = IO_THREAD_HOLDER_KIND_MONITOR_NAME,
+            .u.monitor_name.monitor_name = mon->id ? (char *)mon->id :
+                                           (char *)mon->chr.chr->label,
+        };
+
+        iothread_put_aio_context(mon_iothread, &holder);
+    }
+
     g_free(mon->mon_cpu_path);
     qemu_chr_fe_deinit(&mon->chr, false);
     if (monitor_is_qmp(mon)) {
-- 
2.49.0



  parent reply	other threads:[~2026-06-24  7:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24  7:08 [PATCH V9 00/17] iothread: Support tracking and querying IOThread holders Zhang Chen
2026-06-24  7:08 ` [PATCH V9 01/17] qapi/misc: Fix missed query-iothreads items Zhang Chen
2026-06-24  7:08 ` [PATCH V9 02/17] iothread: introduce iothread_ref/unref to track attached devices Zhang Chen
2026-06-24 15:51   ` Stefan Hajnoczi
2026-06-24  7:08 ` [PATCH V9 03/17] iothread: tracking iothread users with holder name Zhang Chen
2026-06-24 17:10   ` Stefan Hajnoczi
2026-06-24  7:08 ` [PATCH V9 04/17] iothread: introduce iothread_unsafe_get_aio_context() Zhang Chen
2026-06-24 17:19   ` Stefan Hajnoczi
2026-06-24  7:08 ` [PATCH V9 05/17] block/export: track IOThread reference in BlockExport Zhang Chen
2026-06-24 17:51   ` Stefan Hajnoczi
2026-06-24  7:08 ` [PATCH V9 06/17] monitor: refactor monitor_data_init() to pass ID Zhang Chen
2026-06-24  7:08 ` Zhang Chen [this message]
2026-06-24  7:08 ` [PATCH V9 08/17] monitor: switch to iothread_unsafe_get_aio_context() Zhang Chen
2026-06-24  7:08 ` [PATCH V9 09/17] virtio-vq-mapping: track iothread-vq-mapping references using device path Zhang Chen
2026-06-24  7:08 ` [PATCH V9 10/17] virtio: use iothread_get/put_aio_context for thread pinning Zhang Chen
2026-06-24  7:08 ` [PATCH V9 11/17] net/colo: track IOThread references using path-based holder Zhang Chen
2026-06-24  7:08 ` [PATCH V9 12/17] virtio-balloon: Update tracking iothread users with holder Zhang Chen
2026-06-24  7:08 ` [PATCH V9 13/17] vfio-user/proxy: Update tracking iothread users with holder name Zhang Chen
2026-06-24  7:08 ` [PATCH V9 14/17] xen-block: " Zhang Chen
2026-06-24  7:08 ` [PATCH V9 15/17] qapi: examine IOThread attachment status via query-iothreads Zhang Chen
2026-06-24  7:08 ` [PATCH V9 16/17] iothread: simplify API by merging iothread_get_aio_context variants Zhang Chen
2026-06-24  7:08 ` [PATCH V9 17/17] tests/unit/iothread: Update the iothread_get_aio_context Zhang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260624070851.13342-8-zhangckid@gmail.com \
    --to=zhangckid@gmail.com \
    --cc=armbru@redhat.com \
    --cc=dave@treblig.org \
    --cc=eblake@redhat.com \
    --cc=fam@euphon.net \
    --cc=jasowang@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.