From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CA97388E76 for ; Wed, 24 Jun 2026 07:12:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782285156; cv=none; b=Fpx87JQZplibmAL/4TZST3d255PeLHEPquzEWZvn11JpRQTE97yYmr4bGXttajYt49xdZ6DqicDfKzJOzDs3guMxhswOMiCFS7iOh9+sgDVkPCQYnEX6Pb8WSCksXcr6c/4H4ao/gg73MiuctIQoXaVZI/UsRlc9NYsoXiSkHpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782285156; c=relaxed/simple; bh=T+oTEsZifQSSjkTTm8dieBj546vS01rprc6FRMPpgRY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NTxZFCjrnA21B3nZUVhz9O9ewUkswllHpKn5fPpY2l/j/ntlqKj2muXKkQ0ZujJGbd3dBnBEFPlpBgJBChNNSLiPNPsmSVgVKJv6v1fPYqRsTHcE8oKE831ikKfIcCghPLHijezIoYL3xG5wzRs6uhdm4tDTWzS48xVsDAyOCH0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VP80X4C2; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VP80X4C2" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-4624c1409c9so537229f8f.3 for ; Wed, 24 Jun 2026 00:12:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782285153; x=1782889953; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VhG9FcF945Re4Q58PUpr7BwlsxWpmlT6fgah9/vT28s=; b=VP80X4C2LEMovPnEmn2cJDyB3XpcTQeZxn+hqir0d5ayChT7Jta/2b9N8MpjcfQr1q kqjp+ajjACnCkjpR47VMpGmp/Q3QqJvyQyu3B2u4VxDnXc+zNnnAelQYsixH+y9bfZZy l73qFgpyH+EyHTzEIArFF0xFodbR4E6jnThWgn2X2WPfRYG9c3KUOBI3uHaF9aeVUIY4 RIGvPrl5ZmmdxHToHAgeIuSAepQ+7e0Wm3tCe7aaWzf96xcuyL46UmDAP4+h0bFQlhFK ctsKM/Mu7VrPHLpFVOE/kEMwCGYHnZ6idfmHwzX0oZsJgK2euglPFB4+K8AvaGhhlg5+ Ft6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782285153; x=1782889953; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VhG9FcF945Re4Q58PUpr7BwlsxWpmlT6fgah9/vT28s=; b=SBCrlYeNzD0OQL3VxXpj2gE5s9HwDCmt70HoCnLQxb7qFe3Lc5gXtJkZm4B2EqVNbI mH+NMYa/zH19aAjnA9mY5CAjWlEAfTMnZquZ8JZGg8NYyDVevX8VP9KavWoDmpTAOUGk KVFjPjyDKWWyVHwjnR1cZNWPw+hXfOZDYWTMtI4DycWiWxgj5bXA2t3TNRiSCpcwZkW9 L6HpfcgCbr0fhCyHAbpFrOtwxDl9pQpP85Ws1Sc1ojlf9G44n8l91/sTq1ctLOSWkx4n TTax+kaC5e+VRuOSwUXnESLAvK7PDvOUGGLBtPVPlwSf3LrKgPFijL4Udmo8TFwDbNpq baPQ== X-Forwarded-Encrypted: i=1; AHgh+Rqm6BMYqMNBnRe1GLrgBTOT1CTrXUDuXXG25B6xSek2JIgSnJrwz9dJ0IrkTNe4oNTxI76mIfkl@lists.linux.dev X-Gm-Message-State: AOJu0Yx4G5I9QD0qubdabTDcsM8Apnr6LEgM8bKRQFkKygJDnCQDpjY7 5cvt8APURUUjBmI5k7UuF7jJW81n4QFuX3amoS2hmjnhmvAdMlgn+kzi X-Gm-Gg: AfdE7clZiFI6cTabBXMj4OPo/gm0aug2cjKOS3q1iCES48IVk7LUqAdLY3dwLqtoHru h4+u8607CtH0ux/ad4QmcoFdXAm67hXkrJQ3HUVfmVuvURKQxilsJy+jG+ToG4lJya4WBBD30FQ 36+2YbfbKQYjCL22w6pMnS82YKSZNSj+B7c691VzJgUbudm3X2iV2NMCKAm9jqBfUA4iDfWO5WN u6HpjVxO913oRrYEpkCzfveGtE7XSB/vUmZiPATPSYk5g3jQmq8noOfNMAeor6xhQUTi5tIt+Y0 OLKiUywQ+euOOX/Wob0N4l0uI/Ef4VyYzvHKz9UVVyfoh3peIsVq2lIekRB3RwhlaW9I1zwqp7Q 9b6KggfwldrjjEPcQ5OQSAkQGz8W1Rx36X7Uf5LSFm9jnAD8LFtaPCgwMbcBZdstGfZnbmpPk3D Vy282+Cpmz X-Received: by 2002:a05:6000:4683:b0:46a:1f35:113f with SMTP id ffacd0b85a97d-46a1f35172dmr8359155f8f.21.1782285152523; Wed, 24 Jun 2026 00:12:32 -0700 (PDT) Received: from localhost ([212.73.77.104]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-46c1ee0189esm4296531f8f.9.2026.06.24.00.12.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2026 00:12:32 -0700 (PDT) From: Askar Safin To: avagin@gmail.com Cc: akpm@linux-foundation.org, alexander@mihalicyn.com, axboe@kernel.dk, bernd@bsbernd.com, brauner@kernel.org, criu@lists.linux.dev, david@kernel.org, dhowells@redhat.com, fuse-devel@lists.linux.dev, hch@infradead.org, jack@suse.cz, joannelkoong@gmail.com, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, miklos@szeredi.hu, netdev@vger.kernel.org, patches@lists.linux.dev, pfalcato@suse.de, rostedt@goodmis.org, safinaskar@gmail.com, torvalds@linux-foundation.org, val@packett.cool, viro@zeniv.linux.org.uk, willy@infradead.org Subject: Re: [PATCH 0/3] vmsplice: make vmsplice a trivial wrapper for preadv2/pwritev2 Date: Wed, 24 Jun 2026 10:12:26 +0300 Message-ID: <20260624071226.2272209-1-safinaskar@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Andrei Vagin : > The CRIU fifo test fails with this change. The problem is that vmsplice > with SPLICE_F_NONBLOCK to a fifo file descriptor fails with -EOPNOTSUPP. > > It seems we need a fix like this one: > > diff --git a/fs/pipe.c b/fs/pipe.c > index 429b0714ec57..6fc49e933727 100644 > --- a/fs/pipe.c > +++ b/fs/pipe.c > @@ -1253,6 +1253,7 @@ static int fifo_open(struct inode *inode, struct > file *filp) > > /* We can only do regular read/write on fifos */ > stream_open(inode, filp); > + filp->f_mode |= FMODE_NOWAIT; > > switch (filp->f_mode & (FMODE_READ | FMODE_WRITE)) { > case FMODE_READ: Does CRIU actually rely on ability to do SPLICE_F_NONBLOCK vmsplice into named fifos? Or this is merely a test? If this is just a test, I think we need not to preserve this behavior. I did debian code search with regex "vmsplice.*SPLICE_F_NONBLOCK" and I found very few packages. And it seems all them use pipes, not named fifos. (On speed: I still think that my vmsplice patches are good thing, despite performance regressions in CRIU.) -- Askar Safin