From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E775A21773D; Thu, 25 Jun 2026 02:48:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782355696; cv=none; b=FDQN8LVeEwZ4qckUPd7urcdBe12DAJ/rXrzXoM4HtQnzhus1Ov4ftpuWstxrIwevzhjSiy/8xVvf5KG9ye+PDeQtc59aN3wVvB6QHbt1P5APp0qGO7l6WNrT68hB+GCt/dZyXuA9cJHJWUKP0L654rrxQ2/lPYY8CIJpba4OQjo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782355696; c=relaxed/simple; bh=vjbeSP5smM1dIMr0Bdr4YKNk9KN39+pe1aZylvOxals=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=R05VcDtoZgPAt1zhWrQp7pkL9ZqpNGptaK6iuuDtCfW8AAKGV49JuhGgUfb+S7mOD9ituwhFRIpTe/ql2qZLId7lwXR1nSgcqY/JhAWGyqVWMZEPj/kgJ5X6tC62/38tx4621vl9hHJJcAZmkLYvOSFgyiPUpiXFBCl0m2uMJiI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HolgLYdh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HolgLYdh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0A741F000E9; Thu, 25 Jun 2026 02:48:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782355695; bh=vjbeSP5smM1dIMr0Bdr4YKNk9KN39+pe1aZylvOxals=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=HolgLYdhcI44tmkHBqhcNk+vR4TYfk3uC/URHebjxdZMjMJRuLWqtCY/vaz9Qzw9b 1CQGlg3d6Vs6DlgpUlsDEuy8/YZFVIfKByIJI4mF7kqtWePqSATOSy6J5YzTT3fi4H 9QsBxRwmIqizT93ruEMecJREKiEoyww4TtKOER5oAQhNL2Dw/emyFAJQ0uj7dfJXtg z/Q+uBstWq93ukndAbMlCRQV/77H446aSPWQVrmqmEFJf3lGu4kznVWyqBS+L2dgPw 0gCRGZ67VNhwcMqehnWflNHjR6oaADi3urCBzF0dYefcTDSOxbA+JdE+w1/KqPWUNd D/oq/0gE6KwKw== Date: Wed, 24 Jun 2026 19:48:14 -0700 From: Jakub Kicinski To: Haoxiang Li Cc: madalin.bucur@nxp.com, sean.anderson@linux.dev, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, florinel.iordache@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@kernel.org, Pavan Chebbi , Breno Leitao Subject: Re: [PATCH net v3] fsl/fman: Free init resources on KeyGen failure in fman_init() Message-ID: <20260624194814.350800e9@kernel.org> In-Reply-To: <20260625004834.3394389-1-haoxiang_li2024@163.com> References: <20260625004834.3394389-1-haoxiang_li2024@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 25 Jun 2026 08:48:34 +0800 Haoxiang Li wrote: > fman_muram_alloc() allocates initialization resources before > initializing the KeyGen block. If keygen_init() fails, the > function returns -EINVAL directly and leaves those resources > allocated. Free the initialization resources before returning > from the KeyGen failure path. Please slow down. You're sending a lot of low value patches. Please do not have more than 5 outstanding "active" networking patches under name at any given time: https://patchwork.kernel.org/project/netdevbpf/list/?submitter=215341