All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Muchun Song <muchun.song@linux.dev>
Cc: mclapinski@google.com, mm-commits@vger.kernel.org,
	vbabka@kernel.org, stable@vger.kernel.org, osalvador@suse.de,
	kas@kernel.org, david@kernel.org
Subject: Re: + mm-hugetlb-init-tails-before-init_migratetype.patch added to mm-hotfixes-unstable branch
Date: Wed, 24 Jun 2026 20:03:11 -0700	[thread overview]
Message-ID: <20260624200311.6da8a04dd323b336afe25673@linux-foundation.org> (raw)
In-Reply-To: <A6C55A66-5225-4C1C-9E4C-988EEAA960D0@linux.dev>

On Thu, 25 Jun 2026 10:49:25 +0800 Muchun Song <muchun.song@linux.dev> wrote:

> > VM_BUG_ON_PAGE(!zone_spans_pfn(page_zone(page), pfn), page);
> > 
> > This code looks inside the struct page which will be uninitialized
> > for hugetlb tail pages, which will cause a false positive.
> > 
> > So let's initialize the tail pages before this happens.
> > 
>
> ...
>
> 
> Hi Andrew,
> 
> Just a quick heads-up — this bug was actually already fixed in my patch #1 of
> patchset [1].

OK, thanks.  I work through backlog in reverse time order, so that's
still 800 emails away ;)

> Since both patches address the same issue, I'd suggest picking
> mine to avoid unnecessary merge conflicts when the rest of my series gets applied.
>
> Thanks to Michal for also taking a look at this — always good to have extra eyes
> on the same problem.
> 
> [1] https://lore.kernel.org/linux-mm/20260612035903.2468601-2-songmuchun@bytedance.com/

That's a very different change.

I expect I'll need to separate your [01/19] out of the series and make
it a hotfix.

Oh well, thanks, I'll leave a note against
mm-hugetlb-init-tails-before-init_migratetype.patch for now.

      reply	other threads:[~2026-06-25  3:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25  0:54 + mm-hugetlb-init-tails-before-init_migratetype.patch added to mm-hotfixes-unstable branch Andrew Morton
2026-06-25  2:49 ` Muchun Song
2026-06-25  3:03   ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260624200311.6da8a04dd323b336afe25673@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=kas@kernel.org \
    --cc=mclapinski@google.com \
    --cc=mm-commits@vger.kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=osalvador@suse.de \
    --cc=stable@vger.kernel.org \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.