Re: [PATCH v3] ASoC: dt-bindings: Convert cirrus,cs35l36 to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `cirrus,boost-ind-nanohenry` property was incorrectly omitted from the `required` list in the YAML schema.
--

commit 778c838f7518ecfc3c565efa00f1019533b91e2d
Author: David Heidelberg <david@ixit.cz>

ASoC: dt-bindings: Convert cirrus,cs35l36 to DT schema

Convert the CS35L36 Speaker Amplifier binding from text to YAML format, 
updating the maintainer list and aligning the properties with the datasheet.

> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l36.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l36.yaml
> new file mode 100644
> index 0000000000000..2a142b32acf50
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l36.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - VA-supply
> +  - cirrus,boost-ctl-millivolt
> +  - cirrus,boost-peak-milliamp

[Severity: Medium]
Should cirrus,boost-ind-nanohenry be included in this required list?

A device tree missing this property will pass schema validation, but the 
driver will fail to probe. Looking at cs35l36_handle_of_data() in 
sound/soc/codecs/cs35l36.c, the driver hard-fails if it's absent:

sound/soc/codecs/cs35l36.c:cs35l36_handle_of_data() {
	...
	if (of_property_read_u32(np, "cirrus,boost-ind-nanohenry", &val) >= 0) {
		pdata->boost_ind = val;
	} else {
		dev_err(&i2c_client->dev, "Inductor not specified.\n");
		return -EINVAL;
	}
	...
}

> +
> +unevaluatedProperties: false
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260624-dt-cirrus-cs35l36-v3-1-ec451d5a2908@ixit.cz?part=1