From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37A583655E3 for ; Thu, 25 Jun 2026 02:26:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782354399; cv=none; b=gXxFvpVqidpuckWK+qjvCfQ9AlwJv+ZgCLwci8zaX3nd5tl320xomjCMjlaOxmAEQ/hhtmI5GfLnTnobB0SKrg9S3MznoTNY/4Qq9VfHi1EVLac4gjoc9dzezcygQuhiIzuc3OhGX5cWHT8WKoX0Ok7W/Fzdsv7cE21DrZzOWrg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782354399; c=relaxed/simple; bh=PgCBUmEK1cYzcl8pHA8wGIIEemv8P1lDK9pYq34EwQU=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Sgcs12JZemuqGOc5hFM1DdYcmMy2l/ayIbdKXhl9hCrOO5xjRr9Bj84f4+sqzD0GKLgAPfMiqpyqXO5uXn4u5YImAicQ2jN+vOgGKckdNei2IUAdYY6UoG5kfGR/KO8OpgIxo5CrIeYjQWJyxd5uNuO70aOSeyL77BKSDiS2tDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QryLIjvp; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QryLIjvp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B07AB1F000E9; Thu, 25 Jun 2026 02:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782354397; bh=piVxViYlQ+kltRFXDt12OjI0Tk0TH9pkIuto1efw8U0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=QryLIjvp2XY51GGWpzERWCxa0il/rXsoFjNiZe8G5sKwWx3IS0jBoCLXpX5zqyx+t 9004I/2xAALj9OH7KGfyaKnL79Do5bQIsby7tuc0oWX2ojpiBz/cTB6qWQysYj1xBj a7bjiLA4eerbNn9TSfAuri+p/GNatUuNQwMn/Y6I/sEMCs0BG7aPGwIqgWZnN9lF5V F/JEzmqrB8AJu2LV4GP5gIfylo5C3X8c3IuCcLL6aCEDA60R8X+XHS+SN5Me1V+lQu CRfjqmrWuvDzQrZPI6kmierbnqUg2DyQh7GSHjykgFxK3z4etU6gXNp65OlM225tQj /yhi8uq4t4QHQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 1/2] regulator: dt-bindings: rtq2208: Label mtp-sel-high property as deprecated Reply-To: sashiko-reviews@lists.linux.dev To: cy_huang@richtek.com Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org In-Reply-To: References: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 25 Jun 2026 02:26:37 +0000 Message-Id: <20260625022637.B07AB1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The deprecated property `richtek,mtp-sel-high` remains in the YAML = example block. -- commit 34889eeeff15702a135fa4ac9e6b9f3ab88ee425 Author: ChiYuan Huang regulator: dt-bindings: rtq2208: Label mtp-sel-high property as deprecated Since it can be identified by hardware register, label the unnecessary property 'richtek,mtp-sel-high' as deprecated. > diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.= yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml > --- a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml > +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml > @@ -42,11 +42,14 @@ properties: > =20 > richtek,mtp-sel-high: > type: boolean > + deprecated: true > description: > vout register selection based on this boolean value. > false - Using DVS0 register setting to adjust vout > true - Using DVS1 register setting to adjust vout > =20 > + The property is now deprecated. Will be identified by RG HW regist= er. > + > regulators: [Severity: Low] Since this property is now marked as deprecated, should it also be removed from the example device tree in this binding? Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml:examples: ... pmic@10 { compatible =3D "richtek,rtq2208"; reg =3D <0x10>; interrupts-extended =3D <&gpio26 0 IRQ_TYPE_LEVEL_LOW>; richtek,mtp-sel-high; regulators { ... Leaving the deprecated property in the example encourages its continued use by developers who might copy and paste binding examples into their device trees. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1782353659.gi= t.cy_huang@richtek.com?part=3D1