From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BBE2CDB47C for ; Thu, 25 Jun 2026 02:56:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JL5FIqiT+DpNc0amPtCR6lrU2NmIZd/bt5vGU3A8tfM=; b=YwzX+i2Vuno+Lv eTYHjE3eieLA9s1d4pqgGWm/DxMxp/+u3NL+NKXWoGoEbJI5ufXtIQov/siWjrN+emdNZxIrKd9M2 JvNMEhz3IXh70B+9+1I62vsZbc7oigAPgMAFAsXiGS1Lov3cbxsXor7/NlFjcnRQrdOEkysEdbAjU CB/dzyXzTLjjEhUI/oW6+t2h0TZjFZEAV36VccugleeQgW9JRdXARuscca6ptUBvCdq3nb2XysGwB avdLjdLci/wK9BgeFJ7mz8wZ6urQrxBlAMVKm9jZ+ucZ6s1UFNt3o3p7M2iAZmXHJTmO5J3MURC5B 6PJ89YdoXrnB6PpEWrlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wcaGw-00000008b0Z-03Jp; Thu, 25 Jun 2026 02:56:58 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wcaGv-00000008b0T-0MrZ for linux-phy@lists.infradead.org; Thu, 25 Jun 2026 02:56:57 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 2681260018; Thu, 25 Jun 2026 02:56:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B0211F000E9; Thu, 25 Jun 2026 02:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782356215; bh=qlqA9kPYgXWfUACPUut1tV7rNdv4oaSCMTbf73mg6U8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=MuChnWOWcnj8/w874/Sts9ItQg2YsIrrRpNlhvxT+pNlmrzGO70JVU7MNqjOQKMez ws+KXeNNp0tMwAvOxE7UASW5N8Gkisxybqftvourkwo60Obc9fnZ42yNgSucJHlK9x rea++WqOqCl0vyvt0xIZalQ+2D/HVkDKHA47Hm41BjMkZDQy0lJnVQnsIiHz5Bd+JQ aHHSd+dzvczRu0UC01cOrwjjUNHXwQVfgK1ts0ZZCnomDf6yimYntT0xTw9cBOnzcO 8Y2f4RphM2A4kjdqobtB4+gjV0MV+1RJyx6kMLpsPnWadWn/imAn4+zyEP4dlGjTw/ o2x1mcUKnvsDA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 3/4] arm64: dts: nuvoton: ma35d1: add USB controllers and dual-port PHY node To: "Joey Lu" Cc: linux-phy@lists.infradead.org, conor+dt@kernel.org, olteanv@gmail.com, robh@kernel.org, vkoul@kernel.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260625023958.569299-4-a0987203069@gmail.com> References: <20260625023958.569299-1-a0987203069@gmail.com> <20260625023958.569299-4-a0987203069@gmail.com> Date: Thu, 25 Jun 2026 02:56:55 +0000 Message-Id: <20260625025655.8B0211F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIFRoZSBQSFkgZHJpdmVy IGZhaWxzIHRvIHByb2JlIHVuY29uZGl0aW9uYWxseSBiZWNhdXNlIHRoZSBuZXcgZGV2aWNlIHRy ZWUgbm9kZSBsYWNrcyByZXF1aXJlZCBwcm9wZXJ0aWVzLgotIFtIaWdoXSBUaGUgUEhZIGRyaXZl ciBkb2VzIG5vdCBzdXBwb3J0IG11bHRpLVBIWSBpbmRleGluZywgY2F1c2luZyB0aGUgc2Vjb25k IFVTQiBwb3J0IHRvIHJlbWFpbiB1bmluaXRpYWxpemVkLgotIFtMb3ddIFRoZSBgc3lzYCBub2Rl IGxhY2tzIGEgYHJhbmdlc2AgcHJvcGVydHksIGJyZWFraW5nIHN0YW5kYXJkIGRldmljZSB0cmVl IGFkZHJlc3MgdHJhbnNsYXRpb24gZm9yIGl0cyBjaGlsZHJlbi4KLS0KCmNvbW1pdCA5ZGM1ODgw OTZiNzM5ZjViNzBmMTcxYzFlYjE0NzY0YjIzMGRmYjU3CkF1dGhvcjogSm9leSBMdSA8YTA5ODcy MDMwNjlAZ21haWwuY29tPgoKYXJtNjQ6IGR0czogbnV2b3RvbjogbWEzNWQxOiBhZGQgVVNCIGNv bnRyb2xsZXJzIGFuZCBkdWFsLXBvcnQgUEhZIG5vZGUKClRoaXMgY29tbWl0IGFkZHMgZGV2aWNl IHRyZWUgbm9kZXMgZm9yIHRoZSBNQTM1RDEgVVNCIHN1YnN5c3RlbSwgaW5jbHVkaW5nCnRoZSBz aW1wbGUtbWZkIHN5cyBub2RlLCB0aGUgdXNiLXBoeSBjaGlsZCBub2RlLCBhbmQgdGhlIERXQzIs IEVIQ0kwLzEsIAphbmQgT0hDSTAvMSBjb250cm9sbGVycy4gSXQgYWxzbyBlbmFibGVzIHRoZW0g YW5kIHNldHMgdXAgcGluY3RybCBpbiB0aGUgCmJvYXJkIGZpbGVzLgoKPiBkaWZmIC0tZ2l0IGEv YXJjaC9hcm02NC9ib290L2R0cy9udXZvdG9uL21hMzVkMS5kdHNpIGIvYXJjaC9hcm02NC9ib290 L2R0cy9udXZvdG9uL21hMzVkMS5kdHNpCj4gaW5kZXggZTUxYjk4ZjViZGNlNC4uYTZhMzU0ZjI4 MzExNyAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL251dm90b24vbWEzNWQxLmR0 c2kKPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL251dm90b24vbWEzNWQxLmR0c2kKPiBAQCAt ODMsOSArODMsMTggQEAgc29jIHsKPiAgCQlyYW5nZXM7Cj4gIAo+ICAJCXN5czogc3lzdGVtLW1h bmFnZW1lbnRANDA0NjAwMDAgewo+IC0JCQljb21wYXRpYmxlID0gIm51dm90b24sbWEzNWQxLXJl c2V0IiwgInN5c2NvbiI7Cj4gKwkJCWNvbXBhdGlibGUgPSAibnV2b3RvbixtYTM1ZDEtcmVzZXQi LCAic3lzY29uIiwgInNpbXBsZS1tZmQiOwo+ICAJCQlyZWcgPSA8MHgwIDB4NDA0NjAwMDAgMHgw IDB4MjAwPjsKPiAgCQkJI3Jlc2V0LWNlbGxzID0gPDE+Owo+ICsJCQkjYWRkcmVzcy1jZWxscyA9 IDwxPjsKPiArCQkJI3NpemUtY2VsbHMgPSA8MT47CgpbU2V2ZXJpdHk6IExvd10KU2luY2UgdGhp cyBzeXMgbm9kZSBpcyBhY3RpbmcgYXMgYSBidXMgZm9yIHVzYl9waHkgYW5kIG5vdyBkZWZpbmVz IAojYWRkcmVzcy1jZWxscyBhbmQgI3NpemUtY2VsbHMsIGRvZXMgaXQgYWxzbyBuZWVkIGEgInJh bmdlczsiIHByb3BlcnR5PwoKU3RhbmRhcmQgZGV2aWNlIHRyZWUgc3BlY2lmaWNhdGlvbiByZXF1 aXJlcyBhIHJhbmdlcyBwcm9wZXJ0eSBpbiB0aGUKcGFyZW50IHRvIG1hcCB0aGUgY2hpbGQncyBh ZGRyZXNzIHNwYWNlLiBPbWl0dGluZyBpdCBoZXJlIGJyZWFrcyBzdGFuZGFyZApkZXZpY2UgdHJl ZSBhZGRyZXNzIHRyYW5zbGF0aW9uIGFuZCBjYW4gdHJpZ2dlciBkdGJzX2NoZWNrIHdhcm5pbmdz LgoKPiArCj4gKwkJCXVzYl9waHk6IHVzYi1waHlANjAgewo+ICsJCQkJY29tcGF0aWJsZSA9ICJu dXZvdG9uLG1hMzVkMS11c2IyLXBoeSI7Cj4gKwkJCQlyZWcgPSA8MHg2MCAweDE0PjsKPiArCQkJ CSNwaHktY2VsbHMgPSA8MT47Cj4gKwkJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ICsJCQl9OwoK W1NldmVyaXR5OiBIaWdoXQpXaWxsIHRoaXMgUEhZIG5vZGUgZmFpbCB0byBwcm9iZSBzaW5jZSBp dCBsYWNrcyB0aGUgIm51dm90b24sc3lzIiBhbmQKImNsb2NrcyIgcHJvcGVydGllcz8KCkxvb2tp bmcgYXQgbWEzNV91c2JfcGh5X3Byb2JlKCkgaW4gZHJpdmVycy9waHkvbnV2b3Rvbi9waHktbWEz NWQxLXVzYjIuYywKaXQgdW5jb25kaXRpb25hbGx5IHJlcXVlc3RzIGJvdGggb2YgdGhlc2U6Cgog ICAgcF9waHktPnN5c3JlZyA9IHN5c2Nvbl9yZWdtYXBfbG9va3VwX2J5X3BoYW5kbGUocGRldi0+ ZGV2Lm9mX25vZGUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAibnV2b3RvbixzeXMiKTsKICAgIGlmIChJU19FUlIocF9waHktPnN5c3JlZykpCiAg ICAgICAgcmV0dXJuIGRldl9lcnJfcHJvYmUoJnBkZXYtPmRldiwgUFRSX0VSUihwX3BoeS0+c3lz cmVnKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiRmFpbGVkIHRvIGdldCBTWVMgcmVn aXN0ZXJzXG4iKTsKCkJlY2F1c2UgdGhleSBhcmUgb21pdHRlZCBmcm9tIHRoaXMgbm9kZSwgd29u J3QgdGhlIGxvb2t1cCByZXR1cm4gLUVOT0RFVgphbmQgY2F1c2UgYWxsIGRlcGVuZGVudCBVU0Ig Y29udHJvbGxlcnMgKERXQzIsIEVIQ0kwLzEsIE9IQ0kwLzEpIHRvIGRlZmVyIAppbmRlZmluaXRl bHk/Cgo+ICAJCX07Cj4gIAo+ICAJCWNsazogY2xvY2stY29udHJvbGxlckA0MDQ2MDIwMCB7Cgpb IC4uLiBdCgo+ICsJCWVoY2kxOiB1c2JANDAxYzAwMDAgewo+ICsJCQljb21wYXRpYmxlID0gImdl bmVyaWMtZWhjaSI7Cj4gKwkJCXJlZyA9IDwweDAgMHg0MDFjMDAwMCAweDAgMHgxMDAwPjsKPiAr CQkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDM0IElSUV9UWVBFX0xFVkVMX0hJR0g+Owo+ICsJCQlj bG9ja3MgPSA8JmNsayBIVVNCSDFfR0FURT47Cj4gKwkJCXBoeXMgPSA8JnVzYl9waHkgMT47Cgpb U2V2ZXJpdHk6IEhpZ2hdCkRvZXMgdGhlIGN1cnJlbnQgZHJpdmVyIGFjdHVhbGx5IHN1cHBvcnQg aW5kZXhpbmcgdGhlIFBIWSBsaWtlIHRoaXM/CgpUaGUgZGV2aWNlIHRyZWUgbWFwcyBjb250cm9s bGVycyB0byA8JnVzYl9waHkgMD4gYW5kIDwmdXNiX3BoeSAxPiwgYnV0IApsb29raW5nIGF0IG1h MzVfdXNiX3BoeV9wcm9iZSgpLCB0aGUgZHJpdmVyIHJlZ2lzdGVycyB3aXRoIGEgc2ltcGxlIHhs YXRlCnRoYXQgaWdub3JlcyB0aGUgaW5kZXg6CgogICAgcHJvdmlkZXIgPSBkZXZtX29mX3BoeV9w cm92aWRlcl9yZWdpc3RlcigmcGRldi0+ZGV2LAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBvZl9waHlfc2ltcGxlX3hsYXRlKTsKClNpbmNlIG9mX3BoeV9zaW1w bGVfeGxhdGUgcmV0dXJucyB0aGUgZmlyc3QgUEhZIG9iamVjdCBmb3IgYWxsIHJlcXVlc3RzLCAK YW5kIHRoZSBwb3dlciByb3V0aW5lcyBsaWtlIG1hMzVfdXNiX3BoeV9wb3dlcl9vbigpIGFyZSBo YXJkY29kZWQgdG8gb25seSAKbWFuaXB1bGF0ZSBQSFkwIGJpdHM6CgogICAgcmVnbWFwX3VwZGF0 ZV9iaXRzKHBfcGh5LT5zeXNyZWcsIE1BMzVfU1lTX1JFR19VU0JQTUlTQ1IsIDB4NywKICAgICAg ICAgICAgICAgICAgICAgICAoUEhZMFBPUiB8IFBIWTBTVVNQRU5EKSk7CgpXaWxsIHRoZSBoYXJk d2FyZSBmb3IgUEhZMSAodGhlIGRlZGljYXRlZCBob3N0IHBvcnQpIHJlbWFpbiBjb21wbGV0ZWx5 IAp1bnBvd2VyZWQgYW5kIGZhaWwgdG8gaW5pdGlhbGl6ZSB3aGVuIGVoY2kxIGFuZCBvaGNpMSBh dHRlbXB0IHRvIHVzZSBpdD8KCj4gKwkJCXBoeS1uYW1lcyA9ICJ1c2IiOwo+ICsJCQljb21wYW5p b24gPSA8Jm9oY2kxPjsKPiArCQkJc3RhdHVzID0gImRpc2FibGVkIjsKPiArCQl9OwoKWyAuLi4g XQoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNl dC8yMDI2MDYyNTAyMzk1OC41NjkyOTktMS1hMDk4NzIwMzA2OUBnbWFpbC5jb20/cGFydD0zCgot LSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 444CA14F70 for ; Thu, 25 Jun 2026 02:56:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782356217; cv=none; b=vAr85wRMrXKNCD+sHnjO5l367XOZO67ailjF0EwKx11ee5jbxMiKpDxAvTEH8Nybh82ROfAkHwftY0kUQBry3qKEPg4AM/YpTSAyvp6tVo+zggbcmXxVto82FQRwkCAKsOaC3QmGpJtc2Wff46I192JxPeumt8yqdnF0oHrZFwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782356217; c=relaxed/simple; bh=i6d1+4/OmPrv4r4wXlQsK8ELIrlGKZ76WuYeAcJPtJ0=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=pdroU4TOuQ3+KgPoQjd5Ilqfy+LEKaJKG2NvWlEVmUW17HtC3Zj+thm6z5G3e5DrN7/vEaaX9ntGkXMwRcM3dApM1yQ65x2cpCsXcAD4WJULZIRxV4VpFXMD9meBBlyk1Mrb0tgPvAGif4QpKbmnknejO1UcqcLZCbNps+Z7b+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MuChnWOW; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MuChnWOW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B0211F000E9; Thu, 25 Jun 2026 02:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782356215; bh=qlqA9kPYgXWfUACPUut1tV7rNdv4oaSCMTbf73mg6U8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=MuChnWOWcnj8/w874/Sts9ItQg2YsIrrRpNlhvxT+pNlmrzGO70JVU7MNqjOQKMez ws+KXeNNp0tMwAvOxE7UASW5N8Gkisxybqftvourkwo60Obc9fnZ42yNgSucJHlK9x rea++WqOqCl0vyvt0xIZalQ+2D/HVkDKHA47Hm41BjMkZDQy0lJnVQnsIiHz5Bd+JQ aHHSd+dzvczRu0UC01cOrwjjUNHXwQVfgK1ts0ZZCnomDf6yimYntT0xTw9cBOnzcO 8Y2f4RphM2A4kjdqobtB4+gjV0MV+1RJyx6kMLpsPnWadWn/imAn4+zyEP4dlGjTw/ o2x1mcUKnvsDA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 3/4] arm64: dts: nuvoton: ma35d1: add USB controllers and dual-port PHY node Reply-To: sashiko-reviews@lists.linux.dev To: "Joey Lu" Cc: linux-phy@lists.infradead.org, conor+dt@kernel.org, olteanv@gmail.com, robh@kernel.org, vkoul@kernel.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260625023958.569299-4-a0987203069@gmail.com> References: <20260625023958.569299-1-a0987203069@gmail.com> <20260625023958.569299-4-a0987203069@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 25 Jun 2026 02:56:55 +0000 Message-Id: <20260625025655.8B0211F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: - [High] The PHY driver fails to probe unconditionally because the new devi= ce tree node lacks required properties. - [High] The PHY driver does not support multi-PHY indexing, causing the se= cond USB port to remain uninitialized. - [Low] The `sys` node lacks a `ranges` property, breaking standard device = tree address translation for its children. -- commit 9dc588096b739f5b70f171c1eb14764b230dfb57 Author: Joey Lu arm64: dts: nuvoton: ma35d1: add USB controllers and dual-port PHY node This commit adds device tree nodes for the MA35D1 USB subsystem, including the simple-mfd sys node, the usb-phy child node, and the DWC2, EHCI0/1,=20 and OHCI0/1 controllers. It also enables them and sets up pinctrl in the=20 board files. > diff --git a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi b/arch/arm64/boot/dt= s/nuvoton/ma35d1.dtsi > index e51b98f5bdce4..a6a354f283117 100644 > --- a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi > +++ b/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi > @@ -83,9 +83,18 @@ soc { > ranges; > =20 > sys: system-management@40460000 { > - compatible =3D "nuvoton,ma35d1-reset", "syscon"; > + compatible =3D "nuvoton,ma35d1-reset", "syscon", "simple-mfd"; > reg =3D <0x0 0x40460000 0x0 0x200>; > #reset-cells =3D <1>; > + #address-cells =3D <1>; > + #size-cells =3D <1>; [Severity: Low] Since this sys node is acting as a bus for usb_phy and now defines=20 #address-cells and #size-cells, does it also need a "ranges;" property? Standard device tree specification requires a ranges property in the parent to map the child's address space. Omitting it here breaks standard device tree address translation and can trigger dtbs_check warnings. > + > + usb_phy: usb-phy@60 { > + compatible =3D "nuvoton,ma35d1-usb2-phy"; > + reg =3D <0x60 0x14>; > + #phy-cells =3D <1>; > + status =3D "disabled"; > + }; [Severity: High] Will this PHY node fail to probe since it lacks the "nuvoton,sys" and "clocks" properties? Looking at ma35_usb_phy_probe() in drivers/phy/nuvoton/phy-ma35d1-usb2.c, it unconditionally requests both of these: p_phy->sysreg =3D syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "nuvoton,sys"); if (IS_ERR(p_phy->sysreg)) return dev_err_probe(&pdev->dev, PTR_ERR(p_phy->sysreg), "Failed to get SYS registers\n"); Because they are omitted from this node, won't the lookup return -ENODEV and cause all dependent USB controllers (DWC2, EHCI0/1, OHCI0/1) to defer=20 indefinitely? > }; > =20 > clk: clock-controller@40460200 { [ ... ] > + ehci1: usb@401c0000 { > + compatible =3D "generic-ehci"; > + reg =3D <0x0 0x401c0000 0x0 0x1000>; > + interrupts =3D ; > + clocks =3D <&clk HUSBH1_GATE>; > + phys =3D <&usb_phy 1>; [Severity: High] Does the current driver actually support indexing the PHY like this? The device tree maps controllers to <&usb_phy 0> and <&usb_phy 1>, but=20 looking at ma35_usb_phy_probe(), the driver registers with a simple xlate that ignores the index: provider =3D devm_of_phy_provider_register(&pdev->dev, of_phy_simple_xlate); Since of_phy_simple_xlate returns the first PHY object for all requests,=20 and the power routines like ma35_usb_phy_power_on() are hardcoded to only=20 manipulate PHY0 bits: regmap_update_bits(p_phy->sysreg, MA35_SYS_REG_USBPMISCR, 0x7, (PHY0POR | PHY0SUSPEND)); Will the hardware for PHY1 (the dedicated host port) remain completely=20 unpowered and fail to initialize when ehci1 and ohci1 attempt to use it? > + phy-names =3D "usb"; > + companion =3D <&ohci1>; > + status =3D "disabled"; > + }; [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260625023958.5692= 99-1-a0987203069@gmail.com?part=3D3