All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Yu Qin <qin.yuA@h3c.com>
Cc: SeongJae Park <sj@kernel.org>,
	akpm@linux-foundation.org, damon@lists.linux.dev,
	linux-mm@kvack.org
Subject: Re: [PATCH] mm/damon/paddr: remove folio_put from damon_pa_invalid_damos_folio
Date: Wed, 24 Jun 2026 20:25:52 -0700	[thread overview]
Message-ID: <20260625032552.97468-1-sj@kernel.org> (raw)
In-Reply-To: <20260625012201.2937854-1-qin.yuA@h3c.com>

Hi Yu,


On Thu, 25 Jun 2026 09:22:01 +0800 Yu Qin <qin.yuA@h3c.com> wrote:

> This boolean function called folio_put() implicitly. Remove the put and let
> callers handle it explicitly, making the get/put pair more clear.

Thank you for this patch.  I agree explicit get/put pair could look clearer for
some people.  But, to some perspectives, doing NULL check and putting a folio
that already determined as invalid may look awkward.  Given the fact tht NULL
check was already done inside the validity checck, doing the NULL check again
makes it even look inefficient.

Maybe just a matter of taste, but my taste is unfortunately closer to the
second perspective.


Thanks,
SJ

[...]

  reply	other threads:[~2026-06-25  3:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25  1:22 [PATCH] mm/damon/paddr: remove folio_put from damon_pa_invalid_damos_folio Yu Qin
2026-06-25  3:25 ` SeongJae Park [this message]
2026-06-25  3:49 ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260625032552.97468-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-mm@kvack.org \
    --cc=qin.yuA@h3c.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.