From: Askar Safin <safinaskar@gmail.com>
To: linux-fsdevel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-api@vger.kernel.org, netdev@vger.kernel.org,
fuse-devel@lists.linux.dev,
Linus Torvalds <torvalds@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
David Howells <dhowells@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Pedro Falcato <pfalcato@suse.de>,
Miklos Szeredi <miklos@szeredi.hu>,
Andy Lutomirski <luto@amacapital.net>,
Collin Funk <collin.funk1@gmail.com>,
David Laight <david.laight.linux@gmail.com>,
Stefan Metzmacher <metze@samba.org>,
The 8472 <kernel@infinite-source.de>, Willy Tarreau <w@1wt.eu>,
Joanne Koong <joannelkoong@gmail.com>,
Val Packett <val@packett.cool>, Andrei Vagin <avagin@gmail.com>,
patches@lists.linux.dev
Subject: [PATCH v2 6/7] vmsplice: return -EINVAL for particular combination of flags
Date: Thu, 25 Jun 2026 08:34:08 +0000 [thread overview]
Message-ID: <20260625083409.3769242-7-safinaskar@gmail.com> (raw)
In-Reply-To: <20260625083409.3769242-1-safinaskar@gmail.com>
See comment for details.
Signed-off-by: Askar Safin <safinaskar@gmail.com>
---
fs/read_write.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/fs/read_write.c b/fs/read_write.c
index dbd0debc2..b1f71b142 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -1258,6 +1258,16 @@ SYSCALL_DEFINE4(vmsplice, int, fd, const struct iovec __user *, vec,
bool non_block = (flags & SPLICE_F_NONBLOCK) || (fd_file(f)->f_flags & O_NONBLOCK);
ssize_t ret;
+ /*
+ * libfuse relies on sharing vmsplice behavior.
+ * So we detect particular combination of flags to
+ * pipe2(2) and vmsplice(2) and return -EINVAL.
+ * This forces libfuse to fail back to non-vmsplice
+ * code path.
+ */
+ if ((flags == SPLICE_F_NONBLOCK) && (fd_file(f)->f_flags & O_NONBLOCK))
+ return -EINVAL;
+
do {
pipe_lock(pipe);
ret = pipe_wait_for_space(pipe, non_block);
--
2.47.3
next prev parent reply other threads:[~2026-06-25 8:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 8:34 [PATCH v2 0/7] vmsplice: fix some problems in my previous vmsplice patchset Askar Safin
2026-06-25 8:34 ` [PATCH v2 1/7] vmsplice: open-code do_writev and do_readv Askar Safin
2026-06-25 8:34 ` [PATCH v2 2/7] vmsplice: change argument type back to "int" Askar Safin
2026-06-25 8:34 ` [PATCH v2 3/7] splice: turn wait_for_space flags argument into bool Askar Safin
2026-06-25 8:34 ` [PATCH v2 4/7] pipe: move wait_for_space to fs/pipe.c and rename it Askar Safin
2026-06-25 8:34 ` [PATCH v2 5/7] vmsplice: make sure we don't wait after writing some data Askar Safin
2026-06-25 8:34 ` Askar Safin [this message]
2026-06-25 8:34 ` [PATCH v2 7/7] pipe: set FMODE_NOWAIT for named FIFOs Askar Safin
2026-06-25 8:46 ` [PATCH v2 0/7] vmsplice: fix some problems in my previous vmsplice patchset David Hildenbrand (Arm)
2026-06-25 10:11 ` Askar Safin
2026-06-25 10:35 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260625083409.3769242-7-safinaskar@gmail.com \
--to=safinaskar@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=collin.funk1@gmail.com \
--cc=david.laight.linux@gmail.com \
--cc=david@kernel.org \
--cc=dhowells@redhat.com \
--cc=fuse-devel@lists.linux.dev \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=joannelkoong@gmail.com \
--cc=kernel@infinite-source.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=metze@samba.org \
--cc=miklos@szeredi.hu \
--cc=netdev@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=pfalcato@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=val@packett.cool \
--cc=viro@zeniv.linux.org.uk \
--cc=w@1wt.eu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.