From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E659331EDF for ; Thu, 25 Jun 2026 08:37:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782376649; cv=none; b=ruNSpcSNHW0gpQyf+hSmpqatibBHmk9EN5rJz0iQA++Ao1TzYSaocEpZrQGe8FFWHd8i6STffWJUiB/Y846091O/45he+WmJe5bha5QwE0P/4hprTc92m/iBW0GO3dPMl3VW+ukpHUwttO/rn/FTgcifiYCS/OxgwWqpHnRY09Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782376649; c=relaxed/simple; bh=A1vhDmz+89jHbyteI2xkw/LkfcWehs/1EHm6N0/5qPI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nt3YsXtTCxWGcs2drlNB3Zx2GWZqq677jaNjEkiDT1OfylGV7tTPRlsn7RkM4or6cMvqioXzDFJzicFMn0P/pbAKZNVQN3A5PLefEUqXiiKpOPmhYzPDXGgxFX9kLqwER78HvvpqtfogKfGBPQCEG1nD/DgemvuT94SoCNlGL08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Xow1WVU9; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Xow1WVU9" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=neLp0XH/IAeRvjn58xTPog1VVRAzlgLcuwQZJbU2FcA=; b=Xow1WVU92nlKR2NItCdvcCG6l6 4/DMIqOc3CZyr+2ka8R6OI7T432omCrCMnZEzEFMcXAayg0WLyzkqNiMrRT3XgUgGblqTNS5IqJA7 DZ3aPQOMYcE32kbt3E3c5H+DA5URDn7Fwwm9sExxEQgto/+8L3xHXi5xcWqdwtkfy0hji4/rmD2n6 0QGTRJcoGSFqBrSXC2ETkRnibKLbWQBgXtYOdR/Z10IWN0av1yvK8KwAbgmlzPMXddmMFzkbKNnQz kzGGv9RfhP+0vIhhcT4rlen2/XI9xPRcbUHC5G9ebkhxgIJLVjVorF8eFtMhI8NPR4iQuncjSKdSe ToTNzlhA==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wcfaK-00000009Zlj-3n7q; Thu, 25 Jun 2026 08:37:21 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id D4474300B5F; Thu, 25 Jun 2026 10:37:20 +0200 (CEST) Date: Thu, 25 Jun 2026 10:37:20 +0200 From: Peter Zijlstra To: K Prateek Nayak Cc: Vincent Guittot , mingo@redhat.com, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, qyousef@layalina.io Subject: Re: [PATCH 6/6 v3] sched/eevdf: Speedup short slice task scheduling Message-ID: <20260625083720.GR42921@noisy.programming.kicks-ass.net> References: <20260624151229.1710703-1-vincent.guittot@linaro.org> <20260624151229.1710703-7-vincent.guittot@linaro.org> <613c1bde-4152-493f-b103-f1fda035b4af@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <613c1bde-4152-493f-b103-f1fda035b4af@amd.com> On Thu, Jun 25, 2026 at 01:07:43PM +0530, K Prateek Nayak wrote: > > +static u64 eligible_vruntime(struct cfs_rq *cfs_rq, struct sched_entity *se) > > +{ > > + struct sched_entity *curr = cfs_rq->curr; > > curr seems to be unused here and is NULL anyways when > set_protect_slice() is called ;-) Ah, but it is not with the flat patches on, which is why I was a little confused ;-) That said; I now see se == curr. So let me go have another look at all that.