From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0D391624D5 for ; Thu, 25 Jun 2026 06:53:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782370413; cv=none; b=r3uxljmc/fF3Q9n9g/YKm3H6KuWOlLRz3ujC+UDx2guHxPEEHXktJGcD6l7u3sb6ZAYI7waExNpMjd+DwyxIw/Kb3Es1IpRb845Tkpm99B//SKeJI8h+Fszm3SUhPv1guZjSpZnX6dZX+IV3n6w6Ql/kJcZoSZ3VjOOur3ZrBLY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782370413; c=relaxed/simple; bh=ocDMCPCVk4vD8AsrlTz1uxLK3tzjDYYHl9+zv15oNCQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ORjKNV6uCHtYe3dPwo8/6IojA2X4zZagAk4Xa9DZNrICAtqAB2N7KeO+aaol7lspX+z1tYh02dIwaBtNolJMrv1JY4E3jK9Utu6nQ2Iv/nJQ0nFYKeWrAZSZ39p1TtkAYxJJFND4lJ7qPZ6V1Z4TzSXKwxGjfV0MNIqaVT36mL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NeFmfYUz; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NeFmfYUz" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-49241a577d8so11350625e9.3 for ; Wed, 24 Jun 2026 23:53:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782370410; x=1782975210; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=527+QTmY13teDKGyNepJ0jPYC5z44tEECNyArKFfF1c=; b=NeFmfYUzmvN8K0fhtJiP4JeRt/akMAFlIus5hY5LyVHuWcGM5oNCxlMP07PAErUOEe ugMu/wJk0lkosDYrfn+TDx7DY5Kw7OGAVdT8h/VcSPtUJX9GKO1+t0z84Ytp7c8vEeIz LRI3ns2HjtJE06MEPdVa+uE6V5HH29OfnrGLOYNbit9b+XiQ1UWBFzjcTXJ5Nluqgukz qCCKrPvnDWRpuId63vW9XfHAV/DYvEI6+wf0Q6qxCs7ssn74NIXRWQNm3MxMcmiCyAVz /9zpLknItdaFuOXHJ9eizPbdsRA9KUdXtMUN8BBl5gv7BBQ776EGVzsBiU/DmdX4cSc6 O3QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782370410; x=1782975210; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=527+QTmY13teDKGyNepJ0jPYC5z44tEECNyArKFfF1c=; b=ZXV9J79yVrLmPYpx3pIBElb7rhEKPk5Myfl/87L5iRg0l+t8Zd83+F9rQBTibpa22U 8iUtzu9TjUG+l8N5Cw25xT3onVrPd253dUAXgT63T16QBJMBCHdSyiY7IZi6W0wKcscG UlG/2t6SsoLYG5Bu7E8yRdZ5VuZu4SK30twd7gU9zl0hCgZlY9Wv+clbCnIY+4YnY9Hn S7B+Fd46IzRjkFOoaGyPQM8/XnOc+hiivftxaLJYU8/VbRPBgPYbqP6if83yp5Q51S1v 75JkbR57ktWqC77NJxqAot6aANk7uL2jC2kYo7E6i5uy+cOHoPzwv+n15kT2gpMT9KUC HUqw== X-Forwarded-Encrypted: i=1; AFNElJ+EreAN8cCgJGNGk2Stje+5H3lIkaFiBfPY8W0QtAvWjb9DU1YzjyIZoVu4Sitttf5C+zvGlF/tKd+3SGo=@vger.kernel.org X-Gm-Message-State: AOJu0YwU3Ysjwz4acRovz549e+tqrvHvtS8gEjcKmNXddDoAdrtIpvxx 8U0mmSiFkgRfN3VeGWGzGM3yJkTtNJb/3PORGnswIdEis9PtCqoxDUzhrlfPXA== X-Gm-Gg: AfdE7ckOf3gMnNoPJExlyh/dm7AXQ3qTZXgQx8ENPs4lyLWGE+Y42lghDnuddcPZhfs WaPRCu/v+OSAzC2VTcIk6hHMpPaWzMENXlN4UQxHua/9cuF2KnLss1lcLIa5gsh+IXYoniau9qf dKlJh9Hfsng6LHlBTWIXI4ze2u0kYh8UWXirG0KYNDqvjPfgaSclfacpdFHJ2QewNfApYqSjnHf m7VTH3lLPfY+72JsyOQB0uplaq1Ts/NXveZJxEMCPWU36z3Ze+/ZAqKwmkKu2UaNzolZ4LNRGZG KLZknIMRDXqX74mb3a/D8iT806WpDNYEKAjE8Q7PvzFjz94+knjRFdx5F726uWdUO75Evw5PDFw o6eiqlyH8KQAdjOtot0jKaNaSWTxrfWtsyyHhw51Megry7UX/bFsO5i24RjrfIImc8fn5gNT8UT l7FTDzSaufi+j6MJGtlvRyLQvmLDD6gCMdrrgu9TRClEE/SWsaJxyHBnvQ5RK0tPfsKOw8DliU6 X8kUENVbEZ41JhNFqdJn/IYLiD9C0usnk2zA6EHfUqf/NtdIfNH1/VliZ2449cxV0RIvD6COKri M1hE7rnPqd3e89mKO90ZUqNI2Snkn/sfG2aY5AM3v/ciXH2DVOvBZH8= X-Received: by 2002:a05:600c:6219:b0:492:4fc6:75e with SMTP id 5b1f17b1804b1-492667c7325mr13136695e9.0.1782370409895; Wed, 24 Jun 2026 23:53:29 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49265975147sm44140535e9.5.2026.06.24.23.53.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 23:53:29 -0700 (PDT) Date: Thu, 25 Jun 2026 08:53:29 +0200 From: Joshua Crofts To: Andy Shevchenko Cc: Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Svyatoslav Ryhel , David Heidelberg , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries Message-ID: <20260625085329.00007959@gmail.com> In-Reply-To: References: <20260625-fix-al3xxx-kconfig-v1-0-d41cbc0c3cf4@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 25 Jun 2026 09:41:31 +0300 Andy Shevchenko wrote: > On Thu, Jun 25, 2026 at 07:20:42AM +0200, Joshua Crofts wrote: > > This series adds REGMAP_I2C support to three AL3xxx ambient light > > sensors that were previously missing this dependency, causing build > > failures. =20 >=20 > There are two problems with the commit message: > - SELECT versus select (see the comment against patch 1) > - you mentioned build failures but haven't provided any evidence, please > provide a reasonable lines of build output to prove that >=20 Sure, I could elaborate a bit more. Just run `make allnoconfig` and `make menuconfig` in which you select IIO, I2C and any AL3xxx sensor and `make .` will fail with errors such as drivers/iio/light/al3010.c: In function =E2=80=98al3010_probe=E2=80=99: drivers/iio/light/al3010.c:185:24: error: implicit declaration of function = =E2=80=98devm_regmap_init_i2c=E2=80=99 [-Wimplicit-function-declaration] 185 | data->regmap =3D devm_regmap_init_i2c(client, &al3010_regma= p_config); | ^~~~~~~~~~~~~~~~~~~~ drivers/iio/light/al3010.c:185:22: error: assignment to =E2=80=98struct reg= map *=E2=80=99 from =E2=80=98int=E2=80=99 makes pointer from integer withou= t a cast [-Wint-conversion] 185 | data->regmap =3D devm_regmap_init_i2c(client, &al3010_regma= p_config); | ^ drivers/iio/light/al3010.c: At top level: drivers/iio/light/al3010.c:48:35: error: storage size of =E2=80=98al3010_re= gmap_config=E2=80=99 isn=E2=80=99t known 48 | static const struct regmap_config al3010_regmap_config =3D { | ^~~~~~~~~~~~~~~~~~~~ Hopefully this is enough. --=20 Kind regards CJD