From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A7243C10AE for ; Thu, 25 Jun 2026 10:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782382210; cv=none; b=DltsyI6AXbbxsuMzXcfxh6hzqc2kyi/YK2nmD8+aDxKxWW6B1ijPE2orTRl3F9k43H8eVfTfqNIDxBNhoXyWAzNz7aFssz65v6J59v+K/iWazN4QPaazMApD4UiLwupTXfggQEQSiv2pu4r7B4vFzuARkt5przhOqc6SQ1Bw+Pg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782382210; c=relaxed/simple; bh=9jVrV5UGqoOzzWzcx5ACXu2FkMsMdpOhC5QlYsg/GK4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NMSsy0xbdIWxjpx1QVqATAJ6vax033picdK0P8jEkep6VWmXmmYaK3x9KhvxeEKC1vF/fCEKoRScMNZgzTG8QtPftIgnSzpmyUn7Gp2K8xOiGcZRrnLlEEzY4D9cfBHpdo3yziJURGGcFsIBoCDJJ6vbdWsZ1EHbhgS+ws7g+DI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=mNvEPOaB; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="mNvEPOaB" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hNpQg73opr0lghi9Mgh6oT1L7e9cZCkDMgW5ZYXrU5o=; b=mNvEPOaBRLbs2ZfVsL8H7XLz0E qZkH6jVIPRejVxLitZOD/C2O7fsQuFpCSABrotXH/28CxOiLvBlZbggdIt0IOtD557OL84/lfg+m4 ojWsZKHe9GWpGHsCKkGcjcqIGd7LYAebfN/DhqZT6vHZ9MVHzaL4pwHLTbai6v/Bjcl3npwSSj5BR ODYpGl/QmnXiNuJGqbT81RzcvVi5VmpKbi1lymnzuT370D0QBYh3QfjC2PCYNHRyTYx9S4tufMzmD vpZ9kWiU7zFCXT4YYcErW+kkf13kRWHx3WybKOlxxz11FByKe9KEDPmp7fDzaDhUaxiR/O+dqNWAJ WxUctAyg==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wch1z-00000003SZc-1b2k; Thu, 25 Jun 2026 10:09:59 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id DAFBA300B5F; Thu, 25 Jun 2026 12:09:57 +0200 (CEST) Date: Thu, 25 Jun 2026 12:09:57 +0200 From: Peter Zijlstra To: K Prateek Nayak Cc: Vincent Guittot , mingo@redhat.com, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, qyousef@layalina.io Subject: Re: [PATCH 6/6 v3] sched/eevdf: Speedup short slice task scheduling Message-ID: <20260625100957.GA2568396@noisy.programming.kicks-ass.net> References: <20260624151229.1710703-1-vincent.guittot@linaro.org> <20260624151229.1710703-7-vincent.guittot@linaro.org> <613c1bde-4152-493f-b103-f1fda035b4af@amd.com> <20260625083720.GR42921@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260625083720.GR42921@noisy.programming.kicks-ass.net> On Thu, Jun 25, 2026 at 10:37:20AM +0200, Peter Zijlstra wrote: > On Thu, Jun 25, 2026 at 01:07:43PM +0530, K Prateek Nayak wrote: > > > > +static u64 eligible_vruntime(struct cfs_rq *cfs_rq, struct sched_entity *se) > > > +{ > > > + struct sched_entity *curr = cfs_rq->curr; > > > > curr seems to be unused here and is NULL anyways when > > set_protect_slice() is called ;-) > > Ah, but it is not with the flat patches on, which is why I was a little > confused ;-) > > That said; I now see se == curr. So let me go have another look at all > that. I might be slow -- it is definitely waay to warm already -- but I'm not seeing how you don't want avg_vruntime() here.