From: Christoph Hellwig <hch@lst.de>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-block@vger.kernel.org
Subject: Re: [PATCH blktests] block/044: basic block error injection sanity test
Date: Thu, 25 Jun 2026 13:54:22 +0200 [thread overview]
Message-ID: <20260625115422.GA18348@lst.de> (raw)
In-Reply-To: <ajzJiWqsQc2EgR3I@shinmob>
On Thu, Jun 25, 2026 at 03:36:19PM +0900, Shin'ichiro Kawasaki wrote:
> Hi Christoph, thanks for the patch. I ran the test case with block/for-next
> kernel branch tip and confirmed that it is working as expected.
>
> Please find my comments in line. FYI, I atttach the patch which reflects my
> comments. If you are fine with the changes, please let me know so that I can
> fold in the change and apply this patch.
> > +# SPDX-License-Identifier: GPL-2.0
>
> Nit: Majority of the blktests test cases have GPL-3.0+. If you do not mind,
> I suggest GPL-3.0+.
Well a mix of licenses is obviously bad, although I hate the GPL 3 with
passion.
> I suggest to add the line below.
>
> _have_kernel_option BLK_ERROR_INJECTION
>
> This way, we can confirm the kernel has the required changes and
> the dependent feature is enabled.
Sounds good, although this assumes we actually have /proc/config.gz?
Otherwise the changes looks fine.
next prev parent reply other threads:[~2026-06-25 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 16:08 [PATCH blktests] block/044: basic block error injection sanity test Christoph Hellwig
2026-06-25 6:36 ` Shin'ichiro Kawasaki
2026-06-25 11:54 ` Christoph Hellwig [this message]
2026-06-26 4:31 ` Shin'ichiro Kawasaki
2026-06-26 4:56 ` Christoph Hellwig
2026-06-27 4:06 ` Shin'ichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260625115422.GA18348@lst.de \
--to=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.