From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 552CC2877F7; Thu, 25 Jun 2026 13:12:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782393158; cv=none; b=JvQEToI6PhuFcncyhk6QxWl+92bM4bXdHCfRwA87xJwaFp8hSAQ/gLPMSxp5eZnKUkY19cCZsY1pitUrGAio3vAHdt371K3wgVsbPlVOeGFhVecg6MZ+IMFFAkSA8/RPpdmXrTlahOvqA94RN1tsV0vWGA6AJU3lLruWRLNo30k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782393158; c=relaxed/simple; bh=q1TvoQpIYP4VxoS3ex/IOKrHkXw0QVlkwvGRO8Rqx+M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SQ+XL8E3Anf+HkQ5EU9fKVKKYLLSFv/TaeObE4Gc9TdXHaksEWJNPEEliK91SIvP6Ajh/zADZEux98eoJoGnhgd9rZvKGUNVE0uJbs5Sq8MSQKbJnnnDHxXoUigBNctudlnJ+ClT1R1dHwLDomsd+7rAKB2QYDrm8LHeFt/YaxY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zz2kQ8gJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zz2kQ8gJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 764DC1F000E9; Thu, 25 Jun 2026 13:12:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1782393157; bh=MFmuFYwY5MNi6D3TSDmyH9/gmyvEvOSufVOPzAg4zuE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=zz2kQ8gJA+3yfIi0KuCa8EmPB2boVcnSly5wja/3bI8sFSz3tlVS75jskOR4Ww8j6 Zg9eI7vDpE82hQmC/uk9Rxnji403geHKSjXCL9nseWI/Wmrj5d7oVFbpz8m5gW5Vhl QrK/FnDnexdmeVGh6yeH6PkYKbl+UuzYZApA5YvA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bartosz Golaszewski , Viken Dadhaniya Subject: [PATCH 7.1 16/21] serial: qcom_geni: Fix RX DMA stall when SE_DMA_RX_LEN_IN is zero Date: Thu, 25 Jun 2026 14:04:08 +0100 Message-ID: <20260625125615.518034583@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260625125613.243729608@linuxfoundation.org> References: <20260625125613.243729608@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Viken Dadhaniya commit b93062b6d8a1b2d9bad235cac25558a909819026 upstream. In qcom_geni_serial_handle_rx_dma(), geni_se_rx_dma_unprep() clears port->rx_dma_addr before SE_DMA_RX_LEN_IN is read. If the register is zero, for example when the RX stale counter fires on an idle line, the handler returns without calling geni_se_rx_dma_prep(). The next RX DMA interrupt then hits the !port->rx_dma_addr guard and returns immediately, so the RX DMA buffer is never rearmed and later input is lost. Keep the handler on the rearm path when rx_in is zero. Warn about the unexpected zero-length DMA completion, skip received-data handling, and always call geni_se_rx_dma_prep(). Fixes: 2aaa43c70778 ("tty: serial: qcom-geni-serial: add support for serial engine DMA") Cc: stable@vger.kernel.org Reviewed-by: Bartosz Golaszewski Signed-off-by: Viken Dadhaniya Link: https://patch.msgid.link/20260528-serial-rx-0-byte-fix-v2-1-b4195cfe342f@oss.qualcomm.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/qcom_geni_serial.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -905,12 +905,9 @@ static void qcom_geni_serial_handle_rx_d port->rx_dma_addr = 0; rx_in = readl(uport->membase + SE_DMA_RX_LEN_IN); - if (!rx_in) { - dev_warn(uport->dev, "serial engine reports 0 RX bytes in!\n"); - return; - } - - if (!drop) + if (!rx_in) + dev_warn_ratelimited(uport->dev, "serial engine reports 0 RX bytes in!\n"); + else if (!drop) handle_rx_uart(uport, rx_in); ret = geni_se_rx_dma_prep(&port->se, port->rx_buf,