Re: [RFC PATCH v1.2 01/11] Docs/mm/damon/design: update for DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP

[SeongJae Park <sj@kernel.org>]

On Thu, 25 Jun 2026 14:29:36 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Malformed reStructuredText inline literal syntax introduced for `node_memcg_used_bp` which will cause a Sphinx build warning.
> --
> 
> commit a9ffce1612fd4b4c8226cfb7a55a1781daa5364d
> Author: SeongJae Park <sj@kernel.org>
> 
> Docs/mm/damon/design: update for DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP
> 
> This commit updates the DAMON design document to include the
> node_eligible_mem_bp goal metric, which was introduced earlier but
> omitted from the design documentation.
> 
> > diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> > index 2da7ca0d3d17a..9dbace087a329 100644
> > --- a/Documentation/mm/damon/design.rst
> > +++ b/Documentation/mm/damon/design.rst
> > @@ -686,9 +686,11 @@ mechanism tries to make ``current_value`` of ``target_metric`` be same to
> 
> [ ... ]
> 
> > -``nid`` is optionally required for only ``node_mem_used_bp``,
> > -``node_mem_free_bp``, ``node_memcg_used_bp`` and ``node_memcg_free_bp`` to
> > +``nid`` is optionally required for ``node_mem_used_bp``, ``node_mem_free_bp``,
> > +``node_memcg_used_bp`,` ``node_memcg_free_bp`` and ``node_eligible_mem_bp`` to
> 
> [Severity: Low]
> Does this malformed reStructuredText inline literal syntax cause a Sphinx build
> warning?
> 
> It appears the backticks around node_memcg_used_bp are unbalanced due to a
> misplaced backtick before the comma.

Good catch.  I will fix in the next revision.


Thanks,
SJ

[...]