From: Tharit Tangkijwanichakul <tharitt97@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev,
Tharit Tangkijwanichakul <tharitt97@gmail.com>
Subject: [PATCH] media: imx219: fix test pattern ordering and add patterns
Date: Thu, 25 Jun 2026 23:02:28 +0700 [thread overview]
Message-ID: <20260625160228.59672-1-tharitt97@gmail.com> (raw)
The test pattern menu currently maps 0 to color bars and 1 to a solid
color, whereas the imx219 datasheet specifies the reverse layout. fix
the ordering to align with the hardware specification.
Additionally, add 5 missing test patterns to complete the available
hardware test patterns.
The changes were validated on a raspberry pi 5 with an imx219 sensor
using v4l2-ctl and rpicam-still.
Signed-off-by: Tharit Tangkijwanichakul <tharitt97@gmail.com>
---
drivers/media/i2c/imx219.c | 31 +++++++++++++++++++++++--------
1 file changed, 23 insertions(+), 8 deletions(-)
diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index 223d3753c..8f0c04afd 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -110,11 +110,16 @@
/* Test Pattern Control */
#define IMX219_REG_TEST_PATTERN CCI_REG16(0x0600)
-#define IMX219_TEST_PATTERN_DISABLE 0
-#define IMX219_TEST_PATTERN_SOLID_COLOR 1
-#define IMX219_TEST_PATTERN_COLOR_BARS 2
-#define IMX219_TEST_PATTERN_GREY_COLOR 3
-#define IMX219_TEST_PATTERN_PN9 4
+#define IMX219_TEST_PATTERN_DISABLE 0
+#define IMX219_TEST_PATTERN_SOLID_COLOR 1
+#define IMX219_TEST_PATTERN_COLOR_BARS 2
+#define IMX219_TEST_PATTERN_GREY_COLOR 3
+#define IMX219_TEST_PATTERN_PN9 4
+#define IMX219_TEST_PATTERN_16SPLIT_COLOR_BARS 5
+#define IMX219_TEST_PATTERN_16SPLIT_INV_COLOR_BARS 6
+#define IMX219_TEST_PATTERN_COLUMN_COUNTER 7
+#define IMX219_TEST_PATTERN_INV_COLUMN_COUNTER 8
+#define IMX219_TEST_PATTERN_PN31 9
/* Test pattern colour components */
#define IMX219_REG_TESTP_RED CCI_REG16(0x0602)
@@ -235,18 +240,28 @@ static const s64 imx219_link_freq_4lane_menu[] = {
static const char * const imx219_test_pattern_menu[] = {
"Disabled",
- "Color Bars",
"Solid Color",
+ "Color Bars",
"Grey Color Bars",
- "PN9"
+ "PN9",
+ "16 Split Color Bars",
+ "16 Split Inverted Color Bars",
+ "Column Counter",
+ "Inverted Column Counter",
+ "PN31"
};
static const int imx219_test_pattern_val[] = {
IMX219_TEST_PATTERN_DISABLE,
- IMX219_TEST_PATTERN_COLOR_BARS,
IMX219_TEST_PATTERN_SOLID_COLOR,
+ IMX219_TEST_PATTERN_COLOR_BARS,
IMX219_TEST_PATTERN_GREY_COLOR,
IMX219_TEST_PATTERN_PN9,
+ IMX219_TEST_PATTERN_16SPLIT_COLOR_BARS,
+ IMX219_TEST_PATTERN_16SPLIT_INV_COLOR_BARS,
+ IMX219_TEST_PATTERN_COLUMN_COUNTER,
+ IMX219_TEST_PATTERN_INV_COLUMN_COUNTER,
+ IMX219_TEST_PATTERN_PN31
};
/* regulator supplies */
base-commit: 06cb687a5132fcffe624c0070576ab852ac6b568
--
2.53.0
next reply other threads:[~2026-06-25 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 16:02 Tharit Tangkijwanichakul [this message]
2026-06-26 10:04 ` [PATCH] media: imx219: fix test pattern ordering and add patterns Jai Luthra
2026-06-26 12:38 ` Tharit Tangkijwanichakul
2026-07-01 6:53 ` Jai Luthra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260625160228.59672-1-tharitt97@gmail.com \
--to=tharitt97@gmail.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.