From: sashiko-bot@kernel.org
To: "Nathan Morrisson" <nmorrisson@phytec.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: ti: Add bindings for PHYTEC AM67x based hardware
Date: Thu, 25 Jun 2026 16:15:29 +0000 [thread overview]
Message-ID: <20260625161530.515111F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260625160214.4001298-1-nmorrisson@phytec.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces a tab character for indentation in a YAML file, which is forbidden by the YAML specification and breaks schema validation.
--
commit 969d143e093fd0e0c150cfa118a1a7839d600df9
Author: Nathan Morrisson <nmorrisson@phytec.com>
dt-bindings: arm: ti: Add bindings for PHYTEC AM67x based hardware
This commit adds device tree bindings for the AM67x based phyCORE-AM67x SoM
and phyBOARD-Rigel.
> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> index 2a6a9441c23de..9abe252fc7080 100644
> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> @@ -215,6 +215,13 @@ properties:
> - ti,j722s-evm
> - const: ti,j722s
>
> + - description: K3 AM67 SoC PHYTEC phyBOARD-Rigel
> + items:
> + - enum:
> + - phytec,am6754-phyboard-rigel
[Severity: Low]
Does this line use a tab character for indentation? YAML syntax strictly
forbids the use of tabs for indentation, which will cause dt_binding_check
to fail with a parsing syntax error.
> + - const: phytec,am67-phycore-som
> + - const: ti,j722s
> +
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260625160214.4001298-1-nmorrisson@phytec.com?part=1
next prev parent reply other threads:[~2026-06-25 16:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 16:02 [PATCH 1/2] dt-bindings: arm: ti: Add bindings for PHYTEC AM67x based hardware Nathan Morrisson
2026-06-25 16:02 ` [PATCH 2/2] arm64: dts: ti: Add support for the phyCORE-AM67x Nathan Morrisson
2026-06-25 16:17 ` sashiko-bot
2026-06-26 15:29 ` Nathan Morrisson
2026-06-25 20:37 ` Andrew Davis
2026-06-29 13:57 ` [Upstream] " Wadim Egorov
2026-06-25 16:15 ` sashiko-bot [this message]
2026-06-25 16:22 ` [PATCH 1/2] dt-bindings: arm: ti: Add bindings for PHYTEC AM67x based hardware Conor Dooley
2026-06-25 17:50 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260625161530.515111F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=nmorrisson@phytec.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.