From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54FF6CDE001 for ; Thu, 25 Jun 2026 16:20:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wcmnX-0005dj-2X; Thu, 25 Jun 2026 12:19:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wcmnW-0005dL-1f for qemu-arm@nongnu.org; Thu, 25 Jun 2026 12:19:26 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wcmnU-0003o3-Cr for qemu-arm@nongnu.org; Thu, 25 Jun 2026 12:19:25 -0400 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-2c6ab886da6so883875ad.0 for ; Thu, 25 Jun 2026 09:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782404363; x=1783009163; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CZzBY6/b/ei0TiL0DOEvAI8MzFOiD1eI+e0BWWTe+5k=; b=VBFfO1+vK/wGlinGpLYNpIT803PmvNl5vg/JWJGB8KiApzTise7MzH23x1CBeEghbN xN/So279EoSZrxRqLSYIpiY9o/4uDJCFKw+0HDpzzfbSYDU1x3aHyAZsT8NMBc9eY1yB C7EHj1IO6bICS52qCl1hMYO/42oh/ynzcXkneqzoReKmtHhGPKb1LHzJqjDb1Q+SVSlR qqgSovzBQZjoJnKnnfOTLREtpIH5NDWHAEgXjm4lgjVvpUzGKJGMm64QJLO3E8g9mSju 6EZjDDYMefesAfTtCw9WdVDViLAInSQENttBrnKAYQEPQjbLM/x7VAt8IHus3CkcbxlM 3MCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782404363; x=1783009163; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CZzBY6/b/ei0TiL0DOEvAI8MzFOiD1eI+e0BWWTe+5k=; b=ISdGHD2UEhV2TnSKaq2T5U3cyayiU3n47XOme0PXE3ovSQ1y1nJ73aHo+jQoSido0x iov+ZuVEdyAnadgFIszW5VnFGmf4CERuPa3ZB/Qv9xYG9Cy6Ey4ZJ953zYv6xtfdd59V WlpeusQZ0GWtLwG2d5CxA2E2bsXV8Y9J9t82eMbkPQTDfDrQQnYuK16E4bRguDve4Eg/ Y/AfLoF/muO6jfOGq+8hrBsE/6+GXieg0L3j8by54xtuj1SMJrysM3SxjHaYG0bn/m1d whHc7k3RZ2YZhvWXvJdZD+xCiRqBKkVctFqaMsq6TgGmEcArrWSriOXWT9VkYxExmGeq ECqQ== X-Forwarded-Encrypted: i=1; AHgh+RqgB0yMUcqe57AYY0g3IBXNtWy8YOugn2QjRd5vIU0YGXP+1gRk1HkpwizJ1fEvbD2W8DAz+X1l0g==@nongnu.org X-Gm-Message-State: AOJu0YwhwKZ0zPxB815dc4VCZhRmwk6cdoCFD19IZ0POtbzQNKQuczlb XbGCx0H2tTl3D5cl1rMZMWIIS7hsQC4zIZlAOJ68GS77mCaWKwkveYg6 X-Gm-Gg: AfdE7cmVlRwCuxst9l5qfsQM4FEsQ3S3Xn0tdI9gC5D8AHoUcnsSFh3EY1CSWAnMcC8 2IuFiaR5iEhfJXO/dGoLGuinemmUcxYl9EfVTL9EVvbx+QmlnEbFxjabsi2wLPsAYX189Qg3FGK euw57EQArXqHJqaHmXS//4c52Z3ws7aBHiGnNHkprnaA/YIWCMaBwEO1hST5ORRs5Ki0BbbSQ76 too/pWBXyqnA73CvFvM27EySiuoRQgNeIZ8gi5lZ5YtjUeR3wWNpdM9O75SLgpvMbJeyKocJHth ZE/r/yQ+NJ53QbeFNdBUKOBKK2fxSnaqGUYEVi00LXMecpGjKq5LovEZ8cf7d2xv0/L6K1jmXx5 wS8Y+FSGezvVit6sSxQhqfQdH2OxbQwaVpIWT3t+avF1yrfNMDSAICLaUGa+owG3fndBM+Y4C0q SSl42NBt19CjLReuMjwfa88835qrU= X-Received: by 2002:a17:902:da8b:b0:2c6:f350:e89e with SMTP id d9443c01a7336-2c7fca1543dmr31806195ad.20.1782404362796; Thu, 25 Jun 2026 09:19:22 -0700 (PDT) Received: from localhost.localdomain ([212.135.211.99]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7f64dc839sm22650235ad.68.2026.06.25.09.19.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 25 Jun 2026 09:19:21 -0700 (PDT) From: jack wang <163wangjack@gmail.com> To: qemu-devel@nongnu.org Cc: jack wang <163wangjack@gmail.com>, Peter Maydell , Jean-Christophe Dubois , qemu-arm@nongnu.org (open list:i.MX25 PDK) Subject: [PATCH v3 2/3] hw/misc/imx25_ccm: Replace DPRINTF with trace events Date: Fri, 26 Jun 2026 00:18:53 +0800 Message-ID: <20260625161855.5132-3-163wangjack@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260625161855.5132-1-163wangjack@gmail.com> References: <20260625161855.5132-1-163wangjack@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=163wangjack@gmail.com; helo=mail-pl1-x633.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_STARTS_WITH_NUMS=0.738, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Signed-off-by: jack wang <163wangjack@gmail.com> Reviewed-by: Peter Maydell --- hw/misc/imx25_ccm.c | 34 ++++++++++------------------------ hw/misc/trace-events | 9 +++++++++ 2 files changed, 19 insertions(+), 24 deletions(-) diff --git a/hw/misc/imx25_ccm.c b/hw/misc/imx25_ccm.c index a6665d5535..d051e8a2d1 100644 --- a/hw/misc/imx25_ccm.c +++ b/hw/misc/imx25_ccm.c @@ -16,18 +16,8 @@ #include "migration/vmstate.h" #include "qemu/log.h" #include "qemu/module.h" +#include "hw/misc/trace.h" -#ifndef DEBUG_IMX25_CCM -#define DEBUG_IMX25_CCM 0 -#endif - -#define DPRINTF(fmt, args...) \ - do { \ - if (DEBUG_IMX25_CCM) { \ - fprintf(stderr, "[%s]%s: " fmt , TYPE_IMX25_CCM, \ - __func__, ##args); \ - } \ - } while (0) static const char *imx25_ccm_reg_name(uint32_t reg) { @@ -118,12 +108,12 @@ static uint32_t imx25_ccm_get_mpll_clk(IMXCCMState *dev) freq = imx_ccm_calc_pll(s->reg[IMX25_CCM_MPCTL_REG], CKIH_FREQ); } - DPRINTF("freq = %u\n", freq); + trace_imx25_ccm_get_mpll_clk(freq); return freq; } -static uint32_t imx25_ccm_get_mcu_clk(IMXCCMState *dev) +static uint32_t imx25_ccm_get_mcu_clk(IMX25CCMState *dev) { uint32_t freq; IMX25CCMState *s = IMX25_CCM(dev); @@ -136,7 +126,7 @@ static uint32_t imx25_ccm_get_mcu_clk(IMXCCMState *dev) freq = freq / (1 + EXTRACT(s->reg[IMX25_CCM_CCTL_REG], ARM_CLK_DIV)); - DPRINTF("freq = %u\n", freq); + trace_imx25_ccm_get_mcu_clk(freq); return freq; } @@ -149,7 +139,7 @@ static uint32_t imx25_ccm_get_ahb_clk(IMXCCMState *dev) freq = imx25_ccm_get_mcu_clk(dev) / (1 + EXTRACT(s->reg[IMX25_CCM_CCTL_REG], AHB_CLK_DIV)); - DPRINTF("freq = %u\n", freq); + trace_imx25_ccm_get_ahb_clk(freq); return freq; } @@ -160,7 +150,7 @@ static uint32_t imx25_ccm_get_ipg_clk(IMXCCMState *dev) freq = imx25_ccm_get_ahb_clk(dev) / 2; - DPRINTF("freq = %u\n", freq); + trace_imx25_ccm_get_ipg_clk(freq); return freq; } @@ -168,7 +158,7 @@ static uint32_t imx25_ccm_get_ipg_clk(IMXCCMState *dev) static uint32_t imx25_ccm_get_clock_frequency(IMXCCMState *dev, IMXClk clock) { uint32_t freq = 0; - DPRINTF("Clock = %d)\n", clock); + trace_imx25_ccm_get_clock_frequency(clock, freq); switch (clock) { case CLK_NONE: @@ -186,7 +176,7 @@ static uint32_t imx25_ccm_get_clock_frequency(IMXCCMState *dev, IMXClk clock) break; } - DPRINTF("Clock = %d) = %u\n", clock, freq); + trace_imx25_ccm_get_clock_frequency(clock, freq); return freq; } @@ -195,8 +185,6 @@ static void imx25_ccm_reset(DeviceState *dev) { IMX25CCMState *s = IMX25_CCM(dev); - DPRINTF("\n"); - memset(s->reg, 0, IMX25_CCM_MAX_REG * sizeof(uint32_t)); s->reg[IMX25_CCM_MPCTL_REG] = 0x800b2c01; s->reg[IMX25_CCM_UPCTL_REG] = 0x84042800; @@ -238,8 +226,7 @@ static uint64_t imx25_ccm_read(void *opaque, hwaddr offset, unsigned size) HWADDR_PRIx "\n", TYPE_IMX25_CCM, __func__, offset); } - DPRINTF("reg[%s] => 0x%" PRIx32 "\n", imx25_ccm_reg_name(offset >> 2), - value); + trace_imx25_ccm_read(imx25_ccm_reg_name(offset >> 2), value); return value; } @@ -249,8 +236,7 @@ static void imx25_ccm_write(void *opaque, hwaddr offset, uint64_t value, { IMX25CCMState *s = (IMX25CCMState *)opaque; - DPRINTF("reg[%s] <= 0x%" PRIx32 "\n", imx25_ccm_reg_name(offset >> 2), - (uint32_t)value); + trace_imx25_ccm_write(imx25_ccm_reg_name(offset >> 2), value); if (offset < 0x70) { /* diff --git a/hw/misc/trace-events b/hw/misc/trace-events index fdb4844045..ebe9b4fb22 100644 --- a/hw/misc/trace-events +++ b/hw/misc/trace-events @@ -273,6 +273,15 @@ imx6_src_reset(void) "" imx7_src_read(const char *reg_name, uint32_t value) "reg[%s] => 0x%" PRIx32 imx7_src_write(const char *reg_name, uint32_t value) "reg[%s] <= 0x%" PRIx32 +# imx25_ccm.c +imx25_ccm_get_mpll_clk(uint32_t freq) "freq = %u" +imx25_ccm_get_mcu_clk(uint32_t freq) "freq = %u" +imx25_ccm_get_ahb_clk(uint32_t freq) "freq = %u" +imx25_ccm_get_ipg_clk(uint32_t freq) "freq = %u" +imx25_ccm_get_clock_frequency(unsigned clock, uint32_t freq) "(clock = %d) = %u" +imx25_ccm_read(const char *reg, uint32_t value) "reg[%s] => 0x%" PRIx32 +imx25_ccm_write(const char *reg, uint32_t value) "reg[%s] <= 0x%" PRIx32 + # iotkit-sysinfo.c iotkit_sysinfo_read(uint64_t offset, uint64_t data, unsigned size) "IoTKit SysInfo read: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" iotkit_sysinfo_write(uint64_t offset, uint64_t data, unsigned size) "IoTKit SysInfo write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" -- 2.53.0