All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Sivaprasad Tummala <sivaprasad.tummala@amd.com>,
	stable@dpdk.org,
	Konstantin Ananyev <konstantin.ananyev@huawei.com>
Subject: [PATCH v3 3/6] examples/ip_fragmentation: remove redundant Tx queue limit
Date: Thu, 25 Jun 2026 10:46:53 -0700	[thread overview]
Message-ID: <20260625174908.278408-4-stephen@networkplumber.org> (raw)
In-Reply-To: <20260625174908.278408-1-stephen@networkplumber.org>

From: Sivaprasad Tummala <sivaprasad.tummala@amd.com>

In `ip_fragmentation` application, Tx queues are configured per lcore
to enable a lockless design and achieve optimal performance.

The `MAX_TX_QUEUE_PER_PORT` macro, defined as `RTE_MAX_ETHPORTS`,
introduced an artificial constraint on the number of Tx queues
and limited core-scaling performance.

This patch removes the unused `MAX_TX_QUEUE_PER_PORT` macro and
redundant Tx queue check, allowing Tx queues to scale directly
with the no. of lcores.

Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org

Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
 examples/ip_fragmentation/main.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
index 2180682373..132550e497 100644
--- a/examples/ip_fragmentation/main.c
+++ b/examples/ip_fragmentation/main.c
@@ -133,7 +133,6 @@ struct rx_queue {
 };
 
 #define MAX_RX_QUEUE_PER_LCORE 16
-#define MAX_TX_QUEUE_PER_PORT 16
 struct __rte_cache_aligned lcore_queue_conf {
 	uint16_t n_rx_queue;
 	uint16_t tx_queue_id[RTE_MAX_ETHPORTS];
@@ -947,8 +946,6 @@ main(int argc, char **argv)
 		fflush(stdout);
 
 		n_tx_queue = nb_lcores;
-		if (n_tx_queue > MAX_TX_QUEUE_PER_PORT)
-			n_tx_queue = MAX_TX_QUEUE_PER_PORT;
 		ret = rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue,
 					    &local_port_conf);
 		if (ret < 0) {
-- 
2.53.0


  parent reply	other threads:[~2026-06-25 17:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-01 15:44 [PATCH] examples/l3fwd-graph: remove redundant Tx queue limit Sivaprasad Tummala
2025-09-22  5:52 ` Nithin Dabilpuram
2025-09-22  6:49   ` Konstantin Ananyev
2025-10-06  8:58     ` Tummala, Sivaprasad
2025-11-18 17:09       ` Thomas Monjalon
2025-11-19 12:08         ` Tummala, Sivaprasad
2025-11-19 12:57           ` Thomas Monjalon
2025-11-19 13:56             ` Tummala, Sivaprasad
2025-11-19 14:55               ` Thomas Monjalon
2025-11-21  4:37                 ` Tummala, Sivaprasad
2025-11-22 15:51 ` [PATCH v2 1/5] " Sivaprasad Tummala
2025-11-22 15:51   ` [PATCH v2 2/5] examples/l3fwd: " Sivaprasad Tummala
2025-11-22 15:51   ` [PATCH v2 3/5] examples/ip_fragmentation: " Sivaprasad Tummala
2025-11-22 15:51   ` [PATCH v2 4/5] examples/ip_reassembly: " Sivaprasad Tummala
2025-11-22 15:51   ` [PATCH v2 5/5] examples/ipv4_multicast: " Sivaprasad Tummala
2026-06-25 17:46 ` [PATCH v3 0/6] examples: remove MAX_TX_QUEUE_PER_PORT Stephen Hemminger
2026-06-25 17:46   ` [PATCH v3 1/6] examples/l3fwd-graph: remove redundant Tx queue limit Stephen Hemminger
2026-06-25 17:46   ` [PATCH v3 2/6] examples/l3fwd: " Stephen Hemminger
2026-06-25 17:46   ` Stephen Hemminger [this message]
2026-06-25 17:46   ` [PATCH v3 4/6] examples/ip_reassembly: " Stephen Hemminger
2026-06-25 17:46   ` [PATCH v3 5/6] examples/ipv4_multicast: " Stephen Hemminger
2026-06-25 17:46   ` [PATCH v3 6/6] examples: remove unused define Stephen Hemminger
2026-06-26  7:23   ` [PATCH v3 0/6] examples: remove MAX_TX_QUEUE_PER_PORT Bruce Richardson
2026-07-12  0:17     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260625174908.278408-4-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@huawei.com \
    --cc=sivaprasad.tummala@amd.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.