From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46009CDE000 for ; Thu, 25 Jun 2026 17:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8kPtnoGjgzIK0JnMa9C4CcmCPELKtja/PlmU5vfHVRs=; b=vmOKwpHDrhT+EU kS3EKNyxJKpzjxQDuk0qML8zIIWULdpP8akoVMzYsPBPgcOn/3NThv9sGehzld3wNXfU67Icqij4v oW/Y3xhwpk9U+slj0dekPo8s+cdlVi5DjZhRdXC0FdZGbjnqr4M8pBul08uv8NW+sSWvlLxgGcTXc qEJHvaFy1WJYMNyKsFTCr9fRpIP1KFg9qttfQ4LZvcRZ2vmBpMPbT1Gnf/gdOpiVylCmlZVRwvFdz zFHkY1F3XbRyir8EFr8dbvXazsQ3ZYELiJJQ+n1O60LMXhEoPu3WjW1TecrUvmuvJzo/k+Qw2Yjtl TGOoKtBugyyZlNezBGtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wcoLV-00000009eQf-1fms; Thu, 25 Jun 2026 17:58:37 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wcoLU-00000009eQV-2ocq for linux-phy@lists.infradead.org; Thu, 25 Jun 2026 17:58:36 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id D3A3360098; Thu, 25 Jun 2026 17:58:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC26D1F000E9; Thu, 25 Jun 2026 17:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782410315; bh=LFxr+kkazsL5eaKgPpO7yTdT4eGb9hozazGeuujrHdA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Mj4Hf1uWMfCeXBS7WjMGsYsLy6gnKsv0LuRU3fMYjVsxyRcHD9ZNF0T6p5KZ0MXRq 5Su/oBjQiRrqMIGLxlXeFO8haHYYlsoavbq+95jz4n8SvxQcX2Pb7JAHD+/NAYgIsc 8Ryyk0NfeG96FPGXYgnLrZOWNz8ZrL1ba3e5RJESSR7sLZHmgkbqHdEEq3YhiWDlKE rCIhOVHPbSLUXi5w5qvncktev3vZ1qZb0vTRsemXaJdEPh4rLXYOxdbJjTAhAVLIHd I8X8MICUrxZtzwpMgPG08S6phivnYWZdN58pG66aCh1zAcMCYJu+nyjPd/7KbI61zX DRNZYSD0b7OtQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 06/27] phy: rockchip: usbdp: Drop seamless DP takeover To: "Sebastian Reichel" Cc: conor+dt@kernel.org, robh@kernel.org, vkoul@kernel.org, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, olteanv@gmail.com, devicetree@vger.kernel.org In-Reply-To: <20260625-rockchip-usbdp-cleanup-v7-6-38eb3cf654fd@collabora.com> References: <20260625-rockchip-usbdp-cleanup-v7-0-38eb3cf654fd@collabora.com> <20260625-rockchip-usbdp-cleanup-v7-6-38eb3cf654fd@collabora.com> Date: Thu, 25 Jun 2026 17:58:33 +0000 Message-Id: <20260625175834.AC26D1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIFVuY29uZGl0aW9uYWxs eSBkaXNhYmxpbmcgdGhlIERQIFBIWSBkdXJpbmcgcHJvYmUgY2FuIGNhdXNlIGEgZmF0YWwgYnVz IHN0YWxsIGlmIHRoZSBib290bG9hZGVyIGxlZnQgdGhlIGRpc3BsYXkgcGlwZWxpbmUgYWN0aXZl LgotLQoKY29tbWl0IGM5MTVkMDU2NWQyYmZlNjg1MWVhMjVkMGY3ZDA5OWY3MGEyMjcwM2YKQXV0 aG9yOiBTZWJhc3RpYW4gUmVpY2hlbCA8c2ViYXN0aWFuLnJlaWNoZWxAY29sbGFib3JhLmNvbT4K CnBoeTogcm9ja2NoaXA6IHVzYmRwOiBEcm9wIHNlYW1sZXNzIERQIHRha2VvdmVyCgpUaGlzIGNv bW1pdCByZW1vdmVzIHNlYW1sZXNzIERQIHRha2VvdmVyIHN1cHBvcnQgYnkgdW5jb25kaXRpb25h bGx5IGRpc2FibGluZwp0aGUgRFAgUEhZIGR1cmluZyBpbml0aWFsIHN0YXR1cyBjaGVja3MuIEl0 IGFpbXMgdG8gcHJldmVudCBjbG9jayByZXNvdXJjZQpsZWFrcyBvbiBtb2R1bGUgcmVtb3ZhbCBz aW5jZSB0aGUgRFJNIHN0YWNrIGRvZXMgbm90IHlldCBzdXBwb3J0IHNlYW1sZXNzCnRha2VvdmVy LgoKQ2xvc2VzOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1waHkvMjAyNjA2MTIxNjQx MDcuQzdEQjIxRjAwMEU5QHNtdHAua2VybmVsLm9yZy8KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv cGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC11c2JkcC5jIGIvZHJpdmVycy9waHkvcm9ja2NoaXAv cGh5LXJvY2tjaGlwLXVzYmRwLmMKPiAtLS0gYS9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9j a2NoaXAtdXNiZHAuYwo+ICsrKyBiL2RyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC11 c2JkcC5jCj4gQEAgLTkzOSw5ICs5MzksOSBAQCBzdGF0aWMgaW50IHJrX3VkcGh5X2dldF9pbml0 aWFsX3N0YXR1cyhzdHJ1Y3QgcmtfdWRwaHkgKnVkcGh5KQo+ICAKPiAgCXJlZ21hcF9yZWFkKHVk cGh5LT5wbWFfcmVnbWFwLCBDTU5fTEFORV9NVVhfQU5EX0VOX09GRlNFVCwgJnZhbHVlKTsKPiAg CWlmIChGSUVMRF9HRVQoQ01OX0RQX0xBTkVfTVVYX0FMTCwgdmFsdWUpICYmIEZJRUxEX0dFVChD TU5fRFBfTEFORV9FTl9BTEwsIHZhbHVlKSkKPiAtCQl1ZHBoeS0+c3RhdHVzID0gVURQSFlfTU9E RV9EUDsKPiAtCWVsc2UKPiAtCQlya191ZHBoeV9kaXNhYmxlKHVkcGh5KTsKPiArCQlkZXZfZGJn KHVkcGh5LT5kZXYsICJTdGFydGVkIHdpdGggRFAgUEhZIHByZS1lbmFibGVkOyBzZWFtbGVzcyB0 YWtlb3ZlciB1bnN1cHBvcnRlZFxuIik7Cj4gKwo+ICsJcmtfdWRwaHlfZGlzYWJsZSh1ZHBoeSk7 CgpbU2V2ZXJpdHk6IEhpZ2hdCldpbGwgdGhpcyB1bmNvbmRpdGlvbmFsIGNhbGwgdG8gcmtfdWRw aHlfZGlzYWJsZSgpIGNhdXNlIGEgZmF0YWwgYnVzIHN0YWxsCmlmIHRoZSBib290bG9hZGVyIGxl ZnQgdGhlIGRpc3BsYXkgcGlwZWxpbmUgYWN0aXZlPwoKSWYgdGhlIGJvb3Rsb2FkZXIgbGVhdmVz IHRoZSBEUCBQSFkgZW5hYmxlZCBhbmQgc3RyZWFtaW5nIGZvciBhIHNwbGFzaApzY3JlZW4sIHRo ZSBWaWRlbyBPdXRwdXQgUHJvY2Vzc29yIChWT1ApIGlzIGFjdGl2ZWx5IHB1c2hpbmcgcGl4ZWxz IHRvIHRoZQpQSFkgYW5kIGRlcGVuZGluZyBvbiBpdHMgY2xvY2tzLgoKQnkgc2h1dHRpbmcgZG93 biB0aGUgUEhZLCBjdXR0aW5nIGl0cyBjbG9ja3MsIGFuZCBhc3NlcnRpbmcgcmVzZXRzIGhlcmUK YmVmb3JlIHRoZSBWT1AgaXMgc3RvcHBlZCwgdGhlIFZPUCBjb3VsZCBzdGFsbCB0aGUgQVhJIGJ1 cyB3aGVuIGl0cwpkb3duc3RyZWFtIHNpbmsgYWJydXB0bHkgc3RvcHMuIFRoaXMgY2FuIGxlYWQg dG8gYW4gYXN5bmNocm9ub3VzIGV4dGVybmFsCmFib3J0IChTRXJyb3IpIG9yIGEgY29tcGxldGUg c3lzdGVtIGhhbmcuCgpFdmVuIHdpdGhvdXQgc2VhbWxlc3MgRFJNIHRha2VvdmVyIHN1cHBvcnQs IHNob3VsZCB0aGUgUEhZIHJlbWFpbiBlbmFibGVkCnVudGlsIHRoZSBEUk0gZHJpdmVyIGdyYWNl ZnVsbHkgdGVhcnMgZG93biB0aGUgZGlzcGxheSBwaXBlbGluZSBpbiB0aGUKY29ycmVjdCBoYXJk d2FyZS1tYW5kYXRlZCBvcmRlciAoVk9QIGZpcnN0LCB0aGVuIFBIWSk/Cgo+ICAKPiAgCXJldHVy biAwOwo+ICB9CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8j L3BhdGNoc2V0LzIwMjYwNjI1LXJvY2tjaGlwLXVzYmRwLWNsZWFudXAtdjctMC0zOGViM2NmNjU0 ZmRAY29sbGFib3JhLmNvbT9wYXJ0PTYKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4 LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED19F282F1D for ; Thu, 25 Jun 2026 17:58:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782410317; cv=none; b=EdNWFwGV6Hsf0ue5rs2cvvrOk9E1/jT/QUm+3N4DbFCtH05jiPoQ4x4TITWZFohbP/aPSi1s0DeqpoNFQaDQyT9GDaEjozUjrwwrWuE0HaLmAJQ6b8bqYpIPOJynIBHGckU/ABRyJGKfUH4bUQg3z2FMTlexBBRFTyDyNGsHa/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782410317; c=relaxed/simple; bh=7LOu2OJTm/9L4hHcPIXkIQVSnqzJcGkpzqnAAtGQ9nw=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=myQajGQQzwA/WLbjLViZrIbtLT0Qmxof50NGzMyot5e52aSsZm9zacunG0zc0RJFzE2kkRnHe8swZOlfVypvTPNq891O3j4FKnVBFio0c3dHu4JajGK4y3bvXHAGxS5Z9A9SuCcSBthcho0BNYglDVRYAfGj7U+ybeYRBaW/hNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Mj4Hf1uW; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mj4Hf1uW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC26D1F000E9; Thu, 25 Jun 2026 17:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782410315; bh=LFxr+kkazsL5eaKgPpO7yTdT4eGb9hozazGeuujrHdA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Mj4Hf1uWMfCeXBS7WjMGsYsLy6gnKsv0LuRU3fMYjVsxyRcHD9ZNF0T6p5KZ0MXRq 5Su/oBjQiRrqMIGLxlXeFO8haHYYlsoavbq+95jz4n8SvxQcX2Pb7JAHD+/NAYgIsc 8Ryyk0NfeG96FPGXYgnLrZOWNz8ZrL1ba3e5RJESSR7sLZHmgkbqHdEEq3YhiWDlKE rCIhOVHPbSLUXi5w5qvncktev3vZ1qZb0vTRsemXaJdEPh4rLXYOxdbJjTAhAVLIHd I8X8MICUrxZtzwpMgPG08S6phivnYWZdN58pG66aCh1zAcMCYJu+nyjPd/7KbI61zX DRNZYSD0b7OtQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 06/27] phy: rockchip: usbdp: Drop seamless DP takeover Reply-To: sashiko-reviews@lists.linux.dev To: "Sebastian Reichel" Cc: conor+dt@kernel.org, robh@kernel.org, vkoul@kernel.org, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, olteanv@gmail.com, devicetree@vger.kernel.org In-Reply-To: <20260625-rockchip-usbdp-cleanup-v7-6-38eb3cf654fd@collabora.com> References: <20260625-rockchip-usbdp-cleanup-v7-0-38eb3cf654fd@collabora.com> <20260625-rockchip-usbdp-cleanup-v7-6-38eb3cf654fd@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 25 Jun 2026 17:58:33 +0000 Message-Id: <20260625175834.AC26D1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] Unconditionally disabling the DP PHY during probe can cause a fata= l bus stall if the bootloader left the display pipeline active. -- commit c915d0565d2bfe6851ea25d0f7d099f70a22703f Author: Sebastian Reichel phy: rockchip: usbdp: Drop seamless DP takeover This commit removes seamless DP takeover support by unconditionally disabli= ng the DP PHY during initial status checks. It aims to prevent clock resource leaks on module removal since the DRM stack does not yet support seamless takeover. Closes: https://lore.kernel.org/linux-phy/20260612164107.C7DB21F000E9@smtp.= kernel.org/ > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rock= chip/phy-rockchip-usbdp.c > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -939,9 +939,9 @@ static int rk_udphy_get_initial_status(struct rk_udph= y *udphy) > =20 > regmap_read(udphy->pma_regmap, CMN_LANE_MUX_AND_EN_OFFSET, &value); > if (FIELD_GET(CMN_DP_LANE_MUX_ALL, value) && FIELD_GET(CMN_DP_LANE_EN_A= LL, value)) > - udphy->status =3D UDPHY_MODE_DP; > - else > - rk_udphy_disable(udphy); > + dev_dbg(udphy->dev, "Started with DP PHY pre-enabled; seamless takeove= r unsupported\n"); > + > + rk_udphy_disable(udphy); [Severity: High] Will this unconditional call to rk_udphy_disable() cause a fatal bus stall if the bootloader left the display pipeline active? If the bootloader leaves the DP PHY enabled and streaming for a splash screen, the Video Output Processor (VOP) is actively pushing pixels to the PHY and depending on its clocks. By shutting down the PHY, cutting its clocks, and asserting resets here before the VOP is stopped, the VOP could stall the AXI bus when its downstream sink abruptly stops. This can lead to an asynchronous external abort (SError) or a complete system hang. Even without seamless DRM takeover support, should the PHY remain enabled until the DRM driver gracefully tears down the display pipeline in the correct hardware-mandated order (VOP first, then PHY)? > =20 > return 0; > } --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260625-rockchip-u= sbdp-cleanup-v7-0-38eb3cf654fd@collabora.com?part=3D6