Re: [PATCH 7/7] drm/nova: remove unused trait in commands.rs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing trailing comma and space in the import block.
--

commit 24496bb80f7a04aa163bf36fdd55b1fa6b6ff3ac
Author: Pedro Yudi Honda <niyudi.honda@usp.br>

drm/nova: remove unused trait in commands.rs

This commit removes an unused transmute::FromBytes implementation for
GspInitDone in the nova-core driver. It also cleans up the associated
imports in commands.rs.

> diff --git a/drivers/gpu/nova-core/gsp/commands.rs b/drivers/gpu/nova-core/gsp/commands.rs
> index f84de9f4f0450..a3c0b7fa3b9ed 100644
> --- a/drivers/gpu/nova-core/gsp/commands.rs
> +++ b/drivers/gpu/nova-core/gsp/commands.rs
> @@ -12,10 +12,7 @@
>      device,
>      pci,
>      prelude::*,
> -    transmute::{
> -        AsBytes,
> -        FromBytes, //
> -    }, //
> +    transmute::AsBytes//

[Severity: Low]
This isn't a bug, but should this import retain the trailing comma and space
before the comment? Keeping the trailing comma (e.g., transmute::AsBytes, //)
prevents noisier diffs when new imports are added later, and adding a space
matches typical formatting conventions for vertical import blocks.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260625190553.7245-1-niyudi.honda@usp.br?part=7