From: Greg KH <gregkh@linuxfoundation.org>
To: raoxu <raoxu@uniontech.com>
Cc: valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usbip: tools: support SuperSpeed Plus devices
Date: Thu, 25 Jun 2026 16:09:49 +0100 [thread overview]
Message-ID: <2026062527-unmoral-drop-down-9ade@gregkh> (raw)
In-Reply-To: <1B3C4D10DA532DC9+20260622100802.377751-1-raoxu@uniontech.com>
On Mon, Jun 22, 2026 at 06:08:02PM +0800, raoxu wrote:
> From: Xu Rao <raoxu@uniontech.com>
>
> USB/IP reads a remote device's speed from the server-side sysfs
> "speed" attribute. read_attr_speed() converts the string to
> enum usb_device_speed before the value is sent to the client.
>
> The conversion table only recognizes 5000 Mbps. Devices reporting
> 10000 or 20000 Mbps are therefore sent as USB_SPEED_UNKNOWN. The
> client then selects a USB 2.0 VHCI port, and the kernel rejects the
> attach request because USB_SPEED_UNKNOWN is not a supported speed.
>
> Map both SuperSpeed Plus sysfs values to USB_SPEED_SUPER_PLUS and
> select the SuperSpeed VHCI hub for that speed.
>
> The issue was reproduced with the following server hardware:
>
> xHCI controller: Intel 8086:a0ed, revision 20
> Subsystem: Lenovo 17aa:382a
> USB device: Silicon Motion 090c:2320 mass storage
> sysfs speed: 10000 Mbps
>
> Before the change:
>
> $ usbip attach -r 10.20.12.170 -b 2-2
> usbip: error: import device
>
> After the change, the device attaches and uses usb-storage:
>
> $ usbip port
> Port 08: <Port in Use> at Super Speed(5000Mbps)
> 8-1 -> usbip://10.20.12.170:3240/2-2
>
> VHCI currently exposes the imported device as SuperSpeed, so the
> client reports 5000 Mbps instead of 10000 Mbps. This is a separate
> speed-reporting limitation and does not prevent attachment or I/O.
>
> Signed-off-by: Xu Rao <raoxu@uniontech.com>
> ---
> tools/usb/usbip/libsrc/usbip_common.c | 2 ++
> tools/usb/usbip/libsrc/vhci_driver.c | 1 +
> 2 files changed, 3 insertions(+)
Isn't this covered by this change:
https://lore.kernel.org/r/00C828F338E43447+20260617020613.199086-1-chenyichong@uniontech.com
?
thanks,
greg k-h
next prev parent reply other threads:[~2026-06-25 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 10:08 [PATCH] usbip: tools: support SuperSpeed Plus devices raoxu
2026-06-22 19:20 ` Shuah Khan
2026-06-23 3:00 ` raoxu
2026-06-25 15:09 ` Greg KH [this message]
2026-06-25 15:37 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026062527-unmoral-drop-down-9ade@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=raoxu@uniontech.com \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.