From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] USB: serial: digi_acceleport: fix write buffer corruption
Date: Thu, 25 Jun 2026 15:56:37 +0100 [thread overview]
Message-ID: <2026062529-entity-setup-6b60@gregkh> (raw)
In-Reply-To: <20260623151229.315224-1-johan@kernel.org>
On Tue, Jun 23, 2026 at 05:12:29PM +0200, Johan Hovold wrote:
> The digi_write_inb_command() is supposed to wait for the write urb to
> become available or return an error, but instead it updates the transfer
> buffer and tries to resubmit the urb on timeout.
>
> To make things worse, for commands like break control where no timeout
> is used, the driver would corrupt the urb immediately due to a broken
> jiffies comparison (on 32-bit machines this takes five minutes of uptime
> to trigger due to INITIAL_JIFFIES).
>
> Fix this by adding the missing return on timeout and waiting
> indefinitely when no timeout has been specified as intended.
>
> This issue was (sort of) flagged by Sashiko when reviewing an unrelated
> change to the driver.
>
> Link: https://sashiko.dev/#/patchset/20260610132232.356139-1-johan%40kernel.org?part=11
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable@vger.kernel.org
> Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
prev parent reply other threads:[~2026-06-25 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 15:12 [PATCH] USB: serial: digi_acceleport: fix write buffer corruption Johan Hovold
2026-06-25 14:56 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026062529-entity-setup-6b60@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.