From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ADF53FADED for ; Fri, 26 Jun 2026 15:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782489215; cv=none; b=HTTSmkJmVU2ZJM0OA4AZwvpARSvBvl00gxxvL99evg3EwQ51giROO8p89gc02gTCiO59nOU5fSkTjjqTa9+NK8DdgO645DFnyudFXNTvWRJtfHDeHDY57eGKtp65+FvOmpiwNDkMB9/ukPq9lq3WWmf/vQYKC19eM4/ydydJYAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782489215; c=relaxed/simple; bh=sw/itTApZtj5ELmtGp/FD8pnZRafoMnfw5NN7MpT5O0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R2FJ2jupnmPmQadvonOnyYeNEzWri7P8o6hI9PXsw5nXVwLdeZMb37oDa6HBixnh8hscNfBoUHz6ANkrxweBgDcxC/oCUzuprHDb59FhM8vMfsAsKRNjbo5bMhrJuGCp7ap01Buf2Vyig+F5ojvg/n1B3ONxzkgumS0XY7XpfJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BziHvIyE; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BziHvIyE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15A1A1F00A3A; Fri, 26 Jun 2026 15:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782489213; bh=TEO7jKAKCPzDL8FtobZad8/84KpoEOayy5z47i0zBtQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=BziHvIyEYCAN2Wdp0fEhcRjUsDq/Gjo92fHTREZwOFosrFFY7LqHa4oRrQ3ZQdWiK 5xY6YurkSLO2/kanXHLF4ICHpm2proWTcWUT6sfR+KGYLY6PqHZVdzUDkNYWmWmENb NpjqG/pcIkDnR31zHDgYMITuhG6obuFh44DoztFMEqxCbhAozfnBhaW79DnlNfW9bR TmvC/h4ECtCDUt4sEbpwGHBgXzmqAnkRREJa/ytnYKdDJ9llR/3XTU5FMMHp23CWiV cT/r2uqbm3FyoVdl8JKJY7r/LpnNqXVDmuhZBGgtvOfVUqQnkapG/AbAtXMtTSMEys cCoSCadxhhk+w== Date: Fri, 26 Jun 2026 16:53:28 +0100 From: Conor Dooley To: Philipp Zabel Cc: peter.wang@mediatek.com, linux-kernel@vger.kernel.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org, linux-devicetree@vger.kernel.org, chun-hung.wu@mediatek.com, alice.chao@mediatek.com, naomi.chu@mediatek.com, ed.tsai@mediatek.com Subject: Re: [PATCH v1 1/2] Documentation: dt: reset: add mediatek,syscon-reset binding Message-ID: <20260626-rewrap-sediment-ad9449abd837@spud> References: <20260626074820.2537772-1-peter.wang@mediatek.com> <20260626074820.2537772-2-peter.wang@mediatek.com> <4ac862d82690a850eeaa997f041f22ee61233ed7.camel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SbwAaF4JR27ITmQ7" Content-Disposition: inline In-Reply-To: <4ac862d82690a850eeaa997f041f22ee61233ed7.camel@pengutronix.de> --SbwAaF4JR27ITmQ7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 26, 2026 at 10:33:20AM +0200, Philipp Zabel wrote: > > +additionalProperties: false > > + > > +examples: > > + - | > > + ufs0cfg_ao: syscon@16840000 { > > + compatible =3D "mediatek,mt8183-ufs0cfg_ao", "syscon", "simple= -mfd"; >=20 > Where is the binding doc for mediatek,mt8183-ufs0cfg_ao? Is this > simple-mfd just to load the reset driver? It isn't going to exist, since we will chuck a fit at the underscore! >=20 > > + reg =3D <0x16840000 0x1000>; > > + #address-cells =3D <1>; > > + #size-cells =3D <1>; > > + > > + ufs0cfgao_rst: reset-controller { > > + compatible =3D "mediatek,syscon-reset"; >=20 > It looks to me like this is just two registers inside ufs0cfg_ao, not a > separate device. Why don't you just add #reset-cells to the parent > node? I concur, seems like it should be in the parent. pw-bot: changes-requested >=20 > > + #reset-cells =3D <1>; > > + mediatek,reset-bits =3D > > + <0x48 3 0x4c 3 100>, > > + <0x148 0 0x14c 0 100>, > > + <0x148 1 0x14c 1 100>, > > + <0x148 2 0x14c 2 0>; > > + }; >=20 > Why is this in DT? This should be a table in the reset driver. >=20 > regards > Philipp --SbwAaF4JR27ITmQ7 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaj6geAAKCRB4tDGHoIJi 0ghHAP989cBkqpm6xunHVMaoI6R3jsc+bhIIE55ueB2q4ezN4wD+NQP9qD+msJ7s v74SVWF2FIl3dzq7t1BO+TJpeP6s+gs= =/Xy/ -----END PGP SIGNATURE----- --SbwAaF4JR27ITmQ7--