All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "SeongJae Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [RFC PATCH v1.3 02/11] Docs/ABI/damon: document probe files
Date: Fri, 26 Jun 2026 00:25:45 +0000	[thread overview]
Message-ID: <20260626002545.8211E1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260626001644.85825-3-sj@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The documentation for the probe filter 'type' attribute fails to enumerate the supported filter type values.
--

commit bda36c29fa892137debaa25d64442f7c3b5efd22
Author: SeongJae Park <sj@kernel.org>

Docs/ABI/damon: document probe files

This commit updates the DAMON ABI document to include descriptions for the
DAMON probe sysfs files.

> diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> index b73e6bc28ea5f..f914aab79fced 100644
> --- a/Documentation/ABI/testing/sysfs-kernel-mm-damon
> +++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
[ ... ]
> +What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/probes/<P>/filters/<F>/type
> +Date:		May 2026
> +Contact:	SeongJae Park <sj@kernel.org>
> +Description:	Writing to and reading from this file sets and gets the type of
> +		the memory of the interest.

[Severity: Low]
Does this documentation need to enumerate the supported filter type values
(such as anon and memcg)?

Users reading the ABI documentation might not know what strings are valid to
write into the probe filter type file without this information.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260626001644.85825-1-sj@kernel.org?part=2

  reply	other threads:[~2026-06-26  0:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-26  0:16 [RFC PATCH v1.3 00/11] mm/damon: update, optimize, and clean up doc, tests, and code SeongJae Park
2026-06-26  0:16 ` [RFC PATCH v1.3 01/11] Docs/mm/damon/design: update for DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP SeongJae Park
2026-06-26  0:24   ` sashiko-bot
2026-06-26  0:31     ` SeongJae Park
2026-06-26  0:16 ` [RFC PATCH v1.3 02/11] Docs/ABI/damon: document probe files SeongJae Park
2026-06-26  0:25   ` sashiko-bot [this message]
2026-06-26  0:34     ` SeongJae Park
2026-06-26  0:16 ` [RFC PATCH v1.3 03/11] mm/damon/tests/core-kunit: test damon_rand() SeongJae Park
2026-06-26  0:25   ` sashiko-bot
2026-06-26  0:39     ` SeongJae Park
2026-06-26  0:16 ` [RFC PATCH v1.3 04/11] selftests/damon/sysfs.sh: test multiple probe dirs creation SeongJae Park
2026-06-26  0:16 ` [RFC PATCH v1.3 05/11] selftests/damon/sysfs.sh: test {core,ops}_filters/ directories SeongJae Park
2026-06-26  0:16 ` [RFC PATCH v1.3 06/11] selftests/damon/sysfs.sh: test dests dir SeongJae Park
2026-06-26  0:16 ` [RFC PATCH v1.3 07/11] selftests/damon/sysfs.sh: test all files in quota goal dir SeongJae Park
2026-06-26  0:16 ` [RFC PATCH v1.3 08/11] mm/damon/core: reduce range setup in damon_commit_target_regions() SeongJae Park
2026-06-26  0:16 ` [RFC PATCH v1.3 09/11] mm/damon/sysfs: split probe setup function out SeongJae Park
2026-06-26  0:16 ` [RFC PATCH v1.3 10/11] mm/damon/sysfs: split out filters setup function SeongJae Park
2026-06-26  0:16 ` [RFC PATCH v1.3 11/11] mm/damon/sysfs: fix typos in probe_{add,rm}_dirs: s/attr/probe/ SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260626002545.8211E1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.