From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB514390C8E for ; Fri, 26 Jun 2026 02:38:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782441519; cv=none; b=mLWoeDYZ8tkStCZMaSAOPg/DKPc/y+Tzms3LLaNGpRVBGGL1Pgg/QmA/EZqJFTNSO1+mlKHu1GaFKV0rJvrMgJCc3Y2o+gCFba68LY0n4lWpFZVFamA1/Jl2AofKkq14ndj6EIHiQzvW6EsAi+jS4eYInyu0HEXSXF/Wmjo7I+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782441519; c=relaxed/simple; bh=X5splIcy0GuCQtfmPA3InAlf+z2ZI0wKvk+URkjXHw4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=OVnpBqtaICwEjznZLZITXCDxLch7j+b8aXXeo0b1dssOZacMD+SWmqlbvx1PJN08WPE9rQonuBdZ3Qhhdezmjs61WI4yNEh/S5KUqCxTLRVaAn8qs32zQeMThqTMk5o+EUs9Q27e1EGdPH0dcwsyrmQwE9iB+F9FepBrFDk9EPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mbDcdjzY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mbDcdjzY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E9081F000E9; Fri, 26 Jun 2026 02:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782441517; bh=a/LDu1elJuq5ZpneWEEUcv0fCbFFJ4wFbEX5gTt4A2s=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=mbDcdjzYhpAz901yI2t3U53etk2Mb04szJWOx4rTvh+89XNaoNDESiJClWbegTbBl Tb5F4tnruTmYhnvGS9uKNwzdbRI+vROYeFdxlUxAxUksG0Leh0cEiAo/H9KjS+pX9S WGGyzhU23/1MdLIoLAkAPUTPTAnZIQpfzHJJ2jpyR2ivPKLBCCQHOr8KiysCMa/8P6 GrWLrOGprER8Srw5qknz20kyEQ0OphShIN06wyEEo3vuFbYRJXoWiNrd6NB5rr8Wd3 KQAtXbZVDsNLp4wWNGNv/JjqhKFdsGrwr0uLjN+3Ph3AarsCS2UqMZQ++eD0TW10I1 QcJnaXbaQA71g== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 6/9] ASoC: loongson: Add Loongson-2K0300 CTCISZ Forever Pi sound card support Reply-To: sashiko-reviews@lists.linux.dev To: "Binbin Zhou" Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org In-Reply-To: References: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 26 Jun 2026 02:38:36 +0000 Message-Id: <20260626023837.2E9081F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] DAI format configuration is entirely bypassed if `mclk-fs` is 0. -- commit 00af2efc83640c13d13fd25311896531fc01a8e7 Author: Binbin Zhou ASoC: loongson: Add Loongson-2K0300 CTCISZ Forever Pi sound card support The Loongson-2K0300 audio card uses a different DAI format compared to existing Loongson platforms. Move the dai_fmt setting from the static DAI link to runtime hw_params via snd_soc_runtime_set_dai_fmt(), and pass the correct format through driver match data. > diff --git a/sound/soc/loongson/loongson_card.c b/sound/soc/loongson/loon= gson_card.c > index ea895fe6b5e97..0e63cbcad57ac 100644 > --- a/sound/soc/loongson/loongson_card.c > +++ b/sound/soc/loongson/loongson_card.c [ ... ] > @@ -45,7 +59,7 @@ static int loongson_card_hw_params(struct snd_pcm_subst= ream *substream, > return ret; > } > =20 > - return 0; > + return snd_soc_runtime_set_dai_fmt(rtd, ls_card->cfg->fmt); > } [Severity: Medium] If a platform's firmware explicitly sets the mclk-fs property to 0, loongson_card_hw_params() will exit early: if (!ls_card->mclk_fs) return 0; By moving the format configuration to the end of this function, will the CPU and CODEC DAIs fail to be configured with the correct format when mclk-fs is 0, since the early return bypasses this new call? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1782439646.gi= t.zhoubinbin@loongson.cn?part=3D6