From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 890D73A48CE; Fri, 26 Jun 2026 05:26:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782451577; cv=none; b=KtsbN2hDVU3ayPQAE0eWmlYdGE+ne/A9595XTpuzc7nUXMTraH6pBswbrz5XW+o4cRJXGukpUG+2cCAxcE8G//3vDtUKvi2ca21W55CnYVvPmQ+RWQ7pNzmvpT1ajIu2zrSzvn8fPmhZpYLbFA3fu/Lut9WivKR3ptlyRjI4dQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782451577; c=relaxed/simple; bh=YrSVqAg5us6uAGsW/AFD5fokE0Fkrz3QrveDNTRf9ww=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j959eh6EuXXyhANq+lncWwLwl0Lrjk7w+lsrJ2na3cSJqUv4FFJ+eD6wREwROn+sRyjV8PtmR0VbtDYWtSsJIrUUI05UgN6bDkCyh7lC+IrB4kUljmsetW3x6GAyW88WBMCikCbDIgj4H0xdHpnlVh+dGuAXWOWAYe6lECUC1uM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 959AC68C4E; Fri, 26 Jun 2026 07:26:13 +0200 (CEST) Date: Fri, 26 Jun 2026 07:26:13 +0200 From: Christoph Hellwig To: Eric Biggers Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, Christoph Hellwig , Theodore Ts'o , Andreas Dilger , Baokun Li , Jan Kara , Ojaswin Mujoo , Ritesh Harjani , Zhang Yi , Jaegeuk Kim , Chao Yu Subject: Re: [PATCH 08/16] ext4: Further de-generalize the bio postprocessing code Message-ID: <20260626052613.GH9043@lst.de> References: <20260624050334.124606-1-ebiggers@kernel.org> <20260624050334.124606-9-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260624050334.124606-9-ebiggers@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Jun 23, 2026 at 10:03:26PM -0700, Eric Biggers wrote: > +extern int __init ext4_init_verity_caches(void); > +extern void ext4_exit_verity_caches(void); Maybe drop these pointless externs while you're at it? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EACA9CDE010 for ; Fri, 26 Jun 2026 05:26:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Aj9w+fEbo33kG0YknOn/nKq+DkwUSd3pGM4qTo9ckrg=; b=UWEizCuItEvBSw7QmShsrKpQRP YWBM+5/cuakREpm7BSFty391VJYoQElauAvLXaCzW1HlihbKp+uzuVEgZOwRDqUdYW5/UcfI670/h 0IbtAKgirxUXrsAfzYERzSAgdfzGEuDHGiQdXzN7C4AU39wfn0PlOUpcPOVdwSOfJNqk=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wcz55-0002Fg-TE; Fri, 26 Jun 2026 05:26:23 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wcz54-0002FZ-BJ for linux-f2fs-devel@lists.sourceforge.net; Fri, 26 Jun 2026 05:26:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YrSVqAg5us6uAGsW/AFD5fokE0Fkrz3QrveDNTRf9ww=; b=cRLfnaWeIFJ4aWwCXj6/f/rLI7 RfLLfLUlOPjdUZ+CXpTQCORq/DlCtSmbc06EyQWE405EYS3amIQEYaasLlP9JzgEc1hMs1Uuto/lx y01ffRYk6qedtELXDU+j8ZVpCfBd8154iMq5rCMnzx49DfoEBuFidAZui7dsbzF5YG44=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YrSVqAg5us6uAGsW/AFD5fokE0Fkrz3QrveDNTRf9ww=; b=ayjAoFmXubBplFgEqpG9mu1cRb JbVw+n25ElePpfq2gFT5tHMELTGitCFZCWMdx0t1L+tU58minThSbSRA1jlm20lw5wz8ralbh2/8R lm5xZP3JSCbWquA7juED138jBthp+ypYU/JynhcUERD+LRZtamegLzqUzlnwNXv4kSdc=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wcz52-0000ut-Ck for linux-f2fs-devel@lists.sourceforge.net; Fri, 26 Jun 2026 05:26:22 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 959AC68C4E; Fri, 26 Jun 2026 07:26:13 +0200 (CEST) Date: Fri, 26 Jun 2026 07:26:13 +0200 From: Christoph Hellwig To: Eric Biggers Message-ID: <20260626052613.GH9043@lst.de> References: <20260624050334.124606-1-ebiggers@kernel.org> <20260624050334.124606-9-ebiggers@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260624050334.124606-9-ebiggers@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1wcz52-0000ut-Ck Subject: Re: [f2fs-dev] [PATCH 08/16] ext4: Further de-generalize the bio postprocessing code X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ritesh Harjani , Theodore Ts'o , Zhang Yi , linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-fscrypt@vger.kernel.org, Andreas Dilger , Ojaswin Mujoo , Baokun Li , Jaegeuk Kim , linux-fsdevel@vger.kernel.org, Jan Kara , linux-ext4@vger.kernel.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Jun 23, 2026 at 10:03:26PM -0700, Eric Biggers wrote: > +extern int __init ext4_init_verity_caches(void); > +extern void ext4_exit_verity_caches(void); Maybe drop these pointless externs while you're at it? _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel