From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A85D1CDE011 for ; Fri, 26 Jun 2026 05:28:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wcz6e-0004dZ-82; Fri, 26 Jun 2026 01:28:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wcz6d-0004dP-2F for qemu-devel@nongnu.org; Fri, 26 Jun 2026 01:27:59 -0400 Received: from out-178.mta0.migadu.com ([91.218.175.178]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wcz6b-0005qJ-LG for qemu-devel@nongnu.org; Fri, 26 Jun 2026 01:27:58 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782451673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0Otmjd2NUErH1wSi2dco8tWcWVtfiS42M6iwdqvIZr8=; b=vTU2IGlmn4SnKkYWSDtGL/EBnrffjlMNoCiGUyNsHDsOoJxh/W3frXd3VpHu9VOqGc3KV/ T5upb8MuJlBQqsd9CM2cvcNv147Y3Eedmf0rQCb0RyGPEQDj5YOY7AZsqGsM2UIX2NKYD5 1BH5bJrGLtcjFGb8H9ObZ3euF6seLUo= From: Tao Cui To: qemu-devel@nongnu.org Cc: Song Gao , Bibo Mao , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Qiang Ma , Tao Cui Subject: [PATCH v2 0/4] target/loongarch/kvm: cpucfg and device attr fixes Date: Fri, 26 Jun 2026 13:27:38 +0800 Message-ID: <20260626052742.810726-1-cui.tao@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.178; envelope-from=cui.tao@linux.dev; helo=out-178.mta0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Tao Cui A few small robustness fixes around cpucfg register sync and kvm device attribute handling in the LoongArch KVM target. 1/4: kvm_check_cpucfg2() discarded the return value of KVM_GET_DEVICE_ATTR and used an uninitialized val to mask cpucfg[2]; check the return value, warn and skip the mask on a GET failure (best-effort negotiation), and initialize val. 2/4: kvm_get_stealtime(), kvm_set_stealtime() and kvm_set_pv_features() pass a struct kvm_device_attr by value to the variadic kvm_vcpu_ioctl(), which expects a pointer. Pass &attr. 3/4: drop the redundant trace_kvm_failed_get/put_cpucfg() calls and their now-unused trace events; kvm_get/set_one_reg() already trace on failure. 4/4: kvm_loongarch_get/put_cpucfg() overwrite ret on each iteration, so only the last register's result is returned and earlier failures are lost; on a failed read, get_cpucfg() also stores a stale val. Accumulate errors with ret |= and only store on a successful read. Compiled and boot-tested on a loongarch64 KVM host. Tao Cui (4): target/loongarch/kvm: fix uninitialized val and unchecked GET in cpucfg2 check target/loongarch/kvm: pass device attr by reference to kvm_vcpu_ioctl target/loongarch/kvm: remove redundant cpucfg failure traces target/loongarch/kvm: fix cpucfg sync error handling target/loongarch/kvm/kvm.c | 46 ++++++++++++++++++++--------------- target/loongarch/trace-events | 2 -- 2 files changed, 26 insertions(+), 22 deletions(-) --- Changes in v2: - 1/4: on KVM_GET_DEVICE_ATTR failure, warn and skip the cpucfg2 mask instead of failing the register sync; the &= mask is best-effort, and a GET failure after a successful HAS is most likely a copy_{from,to}_user issue. Switched the report from error_report() to warn_report(). -- 2.43.0