From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 536EE3BC669; Fri, 26 Jun 2026 05:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782451999; cv=none; b=qXjBFe9TfrkEPhrxInVH5c2faZiwgC7kI3a9MR1wRI/GS3L/2YEAxD5SN5EFgUGWf7BU2iT83AWwaQmpnXgOcjaAUpzS28cZuMOYlwuyFmHFOL409O8SbCuGA3xD0+/jv/UKa+bCo/+RCbrL1lO+f7MX9aorfwwNzvki1q5qZwo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782451999; c=relaxed/simple; bh=lxtrRo+jigevR0QJcO58kA51VyPHqNiIDGDN+D9NtO0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bocICj1x/yDMkYE8nu6Mhb4XgABh6FzbquLjlx3ktMz8KGPEXRZSxjl1AGy97fNKSrL3E74kW199zFJdLz4mn2Gj9D/2owmQ5guMtaDLTyGWDHnu8904k4uG42so/MWEdO+/KoVB+QUYw7r1hpW9kgtqsZN1TUR+7IgRgXztakI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id ED7B468B05; Fri, 26 Jun 2026 07:33:07 +0200 (CEST) Date: Fri, 26 Jun 2026 07:33:07 +0200 From: Christoph Hellwig To: Eric Biggers Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, Theodore Ts'o , Andreas Dilger , Baokun Li , Jan Kara , Ojaswin Mujoo , Ritesh Harjani , Zhang Yi , Jaegeuk Kim , Chao Yu Subject: Re: [PATCH 16/16] fscrypt: Add safety checks to non-block-based en/decryption Message-ID: <20260626053307.GO9043@lst.de> References: <20260624050334.124606-1-ebiggers@kernel.org> <20260624050334.124606-17-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260624050334.124606-17-ebiggers@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Jun 23, 2026 at 10:03:34PM -0700, Eric Biggers wrote: > fscrypt_encrypt_pagecache_blocks(), fscrypt_encrypt_block_inplace(), > fscrypt_decrypt_block_inplace() would dereference a NULL > fscrypt_inode_info pointer if they were to be called on a file that > hasn't been opened yet or on a block-based filesystem. Since they have > the ability to report errors anyway, add WARN_ON_ONCE checks for this. Looks good: Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43857CDE008 for ; Fri, 26 Jun 2026 05:33:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jXgUmn2q/lKY6D0MZ3JmHp76PCOp5t8U3O75ZQ0Jz/o=; b=i6SGyUKq86aFaVlvBLHVMhIrBG PArPLAn09EcsChNqpmEY3uknUVyfZyZs2fytEuLyUaz6MowyQLdCDLOnd3DvT8g+Vw/EksstUIkI4 OmPAmvp3rg/19DCW9c76iQYNuMcz3zkR819qMEeijWeBNCzrwOoyksG1ll0VXrjfsNHs=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wczCE-00056A-Ay; Fri, 26 Jun 2026 05:33:47 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wczBv-00055k-9e for linux-f2fs-devel@lists.sourceforge.net; Fri, 26 Jun 2026 05:33:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Mp3SlZ1WqzRowAF3YrcgCCdPQ9/dBMqCt5uytoZWLmU=; b=miINZwda/6yCS6bmm0iT/XDNlN e+qrmmS9Br3V7NERarJj+UgcLqnvGUukt+UrGz7pY291JmaGDsg2cmDexDhOj3pY1bXppBouy5mdO xkbXEYDA2bL7FGbirkKHlEcRtcmxaaFwHkhCOzAj3/J12aLfnN8VLQMY75DkefAvFbv0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Mp3SlZ1WqzRowAF3YrcgCCdPQ9/dBMqCt5uytoZWLmU=; b=l+GYCOC9GgXa2JGsDsc8PIYqPb oz5Yv3SkqhGkAa8gzKpircdf4Z4gsrnQCmpTltIRWh1YAz5pKI/C5+BHs3TI+PViisLH+t79EgvOR R8QwBQbMg61QTeRDBUFzsibqSgbqSJ3hzqaiC2sA8H1HONIB6Pf8V5nARdbkIkA/OLug=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wczBn-0001II-Op for linux-f2fs-devel@lists.sourceforge.net; Fri, 26 Jun 2026 05:33:21 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id ED7B468B05; Fri, 26 Jun 2026 07:33:07 +0200 (CEST) Date: Fri, 26 Jun 2026 07:33:07 +0200 From: Christoph Hellwig To: Eric Biggers Message-ID: <20260626053307.GO9043@lst.de> References: <20260624050334.124606-1-ebiggers@kernel.org> <20260624050334.124606-17-ebiggers@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260624050334.124606-17-ebiggers@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1wczBn-0001II-Op Subject: Re: [f2fs-dev] [PATCH 16/16] fscrypt: Add safety checks to non-block-based en/decryption X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ritesh Harjani , Theodore Ts'o , Zhang Yi , linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-fscrypt@vger.kernel.org, Andreas Dilger , Ojaswin Mujoo , Baokun Li , Jaegeuk Kim , linux-fsdevel@vger.kernel.org, Jan Kara , linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Jun 23, 2026 at 10:03:34PM -0700, Eric Biggers wrote: > fscrypt_encrypt_pagecache_blocks(), fscrypt_encrypt_block_inplace(), > fscrypt_decrypt_block_inplace() would dereference a NULL > fscrypt_inode_info pointer if they were to be called on a file that > hasn't been opened yet or on a block-based filesystem. Since they have > the ability to report errors anyway, add WARN_ON_ONCE checks for this. Looks good: Reviewed-by: Christoph Hellwig _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel