From: Christoph Hellwig <hch@lst.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com,
bvanassche@acm.org, elver@google.com, gjoyce@linux.ibm.com
Subject: Re: [PATCHv2 14/17] nvme: fix Clang context analysis warning in rdma.c
Date: Fri, 26 Jun 2026 08:49:16 +0200 [thread overview]
Message-ID: <20260626064916.GC11106@lst.de> (raw)
In-Reply-To: <20260614131541.2017845-15-nilay@linux.ibm.com>
On Sun, Jun 14, 2026 at 06:45:29PM +0530, Nilay Shroff wrote:
> After adding Clang lock context annotations in rdma.c, Clang reports
> the following warning when context analysis is enabled:
>
> drivers/nvme/host/rdma.c:972:24: warning: passing pointer to variable 'list' requires holding mutex 'nvme_rdma_ctrl_mutex'
> [-Wthread-safety-pointer]
> 972 | if (list_empty(&ctrl->list))
> | ^
>
> The warning is triggered because ctrl->list is annotated as being
> protected by nvme_rdma_ctrl_mutex, but list_empty(&ctrl->list) is
> invoked without holding that mutex.
Does switching to list_empty_careful fix this? If not, does
list_empty_careful need annotations to make this work?
next prev parent reply other threads:[~2026-06-26 6:49 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-14 13:15 [PATCHv2 00/17] Support Clang context analysis for NVMe host drivers Nilay Shroff
2026-06-14 13:15 ` [PATCHv2 01/17] nvme: update nvme_passthru_end() signature Nilay Shroff
2026-06-26 6:32 ` Christoph Hellwig
2026-06-14 13:15 ` [PATCHv2 02/17] nvme: add Clang context annotations for nvme_passthru_{start|stop} Nilay Shroff
2026-06-26 6:33 ` Christoph Hellwig
2026-06-26 14:20 ` Nilay Shroff
2026-06-14 13:15 ` [PATCHv2 03/17] nvme: add Clang context annotations for nvme_ns_head::srcu Nilay Shroff
2026-06-26 6:34 ` Christoph Hellwig
2026-06-14 13:15 ` [PATCHv2 04/17] nvme: add Clang context annotations for nvme_ns_head::requeue_list Nilay Shroff
2026-06-26 6:37 ` Christoph Hellwig
2026-06-26 14:24 ` Nilay Shroff
2026-06-14 13:15 ` [PATCHv2 05/17] nvme: add Clang context annotations for nvme_ns_head::current_path Nilay Shroff
2026-06-26 6:40 ` Christoph Hellwig
2026-06-26 15:35 ` Nilay Shroff
2026-06-26 18:36 ` Paul E. McKenney
2026-06-14 13:15 ` [PATCHv2 06/17] nvme: add Clang context annotations for nvme_dev::shutdown_lock Nilay Shroff
2026-06-26 6:41 ` Christoph Hellwig
2026-06-14 13:15 ` [PATCHv2 07/17] nvme: add Clang context annotations for nvme_subsystem::lock Nilay Shroff
2026-06-26 6:43 ` Christoph Hellwig
2026-06-26 14:39 ` Nilay Shroff
2026-06-14 13:15 ` [PATCHv2 08/17] nvme: add Clang context annotations for nvme_ctrl::ana_lock Nilay Shroff
2026-06-26 6:43 ` Christoph Hellwig
2026-06-14 13:15 ` [PATCHv2 09/17] nvme: add Clang context annotations for nvme_subsystems_lock Nilay Shroff
2026-06-26 6:45 ` Christoph Hellwig
2026-06-26 14:48 ` Nilay Shroff
2026-06-14 13:15 ` [PATCHv2 10/17] nvme: add Clang context annotations in fabric.c Nilay Shroff
2026-06-14 13:15 ` [PATCHv2 11/17] nvme: add Clang context annotations for nvme_queue::sq_lock Nilay Shroff
2026-06-26 6:47 ` Christoph Hellwig
2026-06-26 9:50 ` Marco Elver
2026-06-26 15:12 ` Nilay Shroff
2026-06-14 13:15 ` [PATCHv2 12/17] nvme: add Clang context annotations for nvme_queue::cq_poll_lock Nilay Shroff
2026-06-26 6:48 ` Christoph Hellwig
2026-06-26 15:22 ` Nilay Shroff
2026-06-14 13:15 ` [PATCHv2 13/17] nvme: add Clang context annotations in rdma.c Nilay Shroff
2026-06-14 13:15 ` [PATCHv2 14/17] nvme: fix Clang context analysis warning " Nilay Shroff
2026-06-26 6:49 ` Christoph Hellwig [this message]
2026-06-26 15:31 ` Nilay Shroff
2026-06-14 13:15 ` [PATCHv2 15/17] nvme: add Clang context annotations in tcp.c Nilay Shroff
2026-06-14 13:15 ` [PATCHv2 16/17] nvme: fix Clang context analysis warning " Nilay Shroff
2026-06-14 13:15 ` [PATCHv2 17/17] nvme: enable Clang context analysis support for nvme host driver Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260626064916.GC11106@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=bvanassche@acm.org \
--cc=elver@google.com \
--cc=gjoyce@linux.ibm.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.