Re: [PATCH v3 4/8] KVM: arm64: Move PSCI helper functions to a shared header

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly shared header `include/kvm/arm_psci.h` references functions without including their defining headers (`<asm/kvm_emulate.h>` and `<linux/wordpart.h>`), violating the practice of self-contained headers.
--

commit 6015f90f953617e9e81e02b97f5532daaa5dfdd7
Author: Fuad Tabba <fuad.tabba@linux.dev>

KVM: arm64: Move PSCI helper functions to a shared header

This commit moves kvm_psci_valid_affinity(), kvm_psci_narrow_to_32bit(),
and psci_affinity_mask() from psci.c to the shared include/kvm/arm_psci.h
header. This prepares the helpers for use in protected-guest PSCI calls
at EL2.

> diff --git a/include/kvm/arm_psci.h b/include/kvm/arm_psci.h
> index cbaec804eb839..f86a006d67136 100644
> --- a/include/kvm/arm_psci.h
> +++ b/include/kvm/arm_psci.h
[ ... ]
> +/* Narrow the PSCI register arguments (r1 to r3) to 32 bits. */
> +static inline void kvm_psci_narrow_to_32bit(struct kvm_vcpu *vcpu)
> +{
> +	int i;
> +
> +	/*
> +	 * Zero the input registers' upper 32 bits. They will be fully
> +	 * zeroed on exit, so we're fine changing them in place.
> +	 */
> +	for (i = 1; i < 4; i++)
> +		vcpu_set_reg(vcpu, i, lower_32_bits(vcpu_get_reg(vcpu, i)));
> +}

[Severity: Low]
Does this new shared header need to include asm/kvm_emulate.h and 
linux/wordpart.h to remain self-contained?

This inline function relies on lower_32_bits(), vcpu_get_reg(), and 
vcpu_set_reg(), but the definitions are not directly included here.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260626070408.3420953-1-fuad.tabba@linux.dev?part=4