Re: [PATCH V15 7/9] iio: imu: inv_icm42607: Add Gyroscope to icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Temperature channel rejects `SAMP_FREQ` read_avail and write requests despite sharing it.
--

commit 44a4695bd590583ad4160f9a70b38ed7f1470dfa
Author: Chris Morgan <macromorgan@hotmail.com>

    iio: imu: inv_icm42607: Add Gyroscope to icm42607
    
    Add gyroscope functions to the icm42607 driver.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_gyro.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_gyro.c
> new file mode 100644
> index 0000000000000..c7215b3826adc
> --- /dev/null
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_gyro.c
[ ... ]
> +static int inv_icm42607_gyro_read_avail(struct iio_dev *indio_dev,
> +					struct iio_chan_spec const *chan,
> +					const int **vals,
> +					int *type, int *length, long mask)
> +{
> +	if (chan->type != IIO_ANGL_VEL)
> +		return -EINVAL;

[Severity: Medium]
Does this strict check reject the IIO_TEMP channel for available value queries?
Since the temperature channel shares the SAMP_FREQ attribute with other
channels, in-kernel consumers attempting to read available sampling frequencies
might receive an unexpected -EINVAL error.

[ ... ]
> +static int inv_icm42607_gyro_write_raw(struct iio_dev *indio_dev,
> +				       struct iio_chan_spec const *chan,
> +				       int val, int val2, long mask)
> +{
> +	int ret;
> +
> +	if (chan->type != IIO_ANGL_VEL)
> +		return -EINVAL;

[Severity: Medium]
Will this similarly reject write requests for the temperature channel,
preventing updates to the shared SAMP_FREQ attribute? (The same behavior
appears to exist in the accelerometer driver's inv_icm42607_accel_write_raw()
function).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260626161230.93069-1-macroalpha82@gmail.com?part=7