From: kernel test robot <lkp@intel.com>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [bcachefs:bcachefs-testing 361/405] fs/bcachefs/data/ec/create.c:371:1: warning: the frame size of 1352 bytes is larger than 1280 bytes
Date: Fri, 26 Jun 2026 17:14:48 +0800 [thread overview]
Message-ID: <202606261712.ZltrHkIJ-lkp@intel.com> (raw)
tree: https://evilpiepirate.org/git/bcachefs.git bcachefs-testing
head: ca944a61e079450f82be88c91e349638c75cf4b6
commit: 87c8e87f6e10fa0ef7e46b4b356c8598a0abcfbb [361/405] bcachefs: Exents that point to stripes with missing devs can be repaired
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20260626/202606261712.ZltrHkIJ-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260626/202606261712.ZltrHkIJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606261712.ZltrHkIJ-lkp@intel.com/
All warnings (new ones prefixed by >>):
fs/bcachefs/data/ec/create.c: In function 'stripe_update_bucket':
>> fs/bcachefs/data/ec/create.c:371:1: warning: the frame size of 1352 bytes is larger than 1280 bytes [-Wframe-larger-than=]
371 | }
| ^
vim +371 fs/bcachefs/data/ec/create.c
bde39b90107558 Kent Overstreet 2026-01-17 302
0a97da6f3749b9 Kent Overstreet 2026-01-22 303 static int stripe_update_bucket(struct btree_trans *trans, struct ec_stripe_new *s, unsigned new_blocknr)
bde39b90107558 Kent Overstreet 2026-01-17 304 {
bde39b90107558 Kent Overstreet 2026-01-17 305 struct bch_fs *c = trans->c;
0a97da6f3749b9 Kent Overstreet 2026-01-22 306 unsigned old_blocknr = new_blocknr < s->old_blocks_nr
0a97da6f3749b9 Kent Overstreet 2026-01-22 307 ? s->old_block_map[new_blocknr]
0a97da6f3749b9 Kent Overstreet 2026-01-22 308 : new_blocknr;
bde39b90107558 Kent Overstreet 2026-01-17 309
0ca5116355ce27 Kent Overstreet 2026-01-25 310 struct bkey_i_stripe *new_stripe = &s->new_stripe.key;
0a97da6f3749b9 Kent Overstreet 2026-01-22 311 struct bkey_i_stripe *old_stripe = new_blocknr < s->old_blocks_nr
0ca5116355ce27 Kent Overstreet 2026-01-25 312 ? &s->old_stripe.key
0a97da6f3749b9 Kent Overstreet 2026-01-22 313 : new_stripe;
0a97da6f3749b9 Kent Overstreet 2026-01-22 314
0a97da6f3749b9 Kent Overstreet 2026-01-22 315 struct bch_extent_ptr old_block = old_stripe->v.ptrs[old_blocknr];
0a97da6f3749b9 Kent Overstreet 2026-01-22 316 struct bch_extent_ptr new_block = new_stripe->v.ptrs[new_blocknr];
0a97da6f3749b9 Kent Overstreet 2026-01-22 317
0a97da6f3749b9 Kent Overstreet 2026-01-22 318 CLASS(bch2_dev_bkey_tryget, ca)(c, bkey_i_to_s_c(&old_stripe->k_i), old_block.dev);
87c8e87f6e10fa Kent Overstreet 2026-01-22 319 enum btree_id btree;
87c8e87f6e10fa Kent Overstreet 2026-01-22 320 struct bpos start, end;
87c8e87f6e10fa Kent Overstreet 2026-01-22 321 if (ca) {
0a97da6f3749b9 Kent Overstreet 2026-01-22 322 struct bpos bucket_pos = PTR_BUCKET_POS(ca, &old_block);
bde39b90107558 Kent Overstreet 2026-01-17 323
87c8e87f6e10fa Kent Overstreet 2026-01-22 324 btree = BTREE_ID_backpointers;
87c8e87f6e10fa Kent Overstreet 2026-01-22 325 start = bucket_pos_to_bp_start(ca, bucket_pos);
87c8e87f6e10fa Kent Overstreet 2026-01-22 326 end = bucket_pos_to_bp_end(ca, bucket_pos);
87c8e87f6e10fa Kent Overstreet 2026-01-22 327 } else {
87c8e87f6e10fa Kent Overstreet 2026-01-22 328 u64 idx = old_stripe->k.p.offset;
87c8e87f6e10fa Kent Overstreet 2026-01-22 329 btree = BTREE_ID_stripe_backpointers;
87c8e87f6e10fa Kent Overstreet 2026-01-22 330 start = POS((idx << 8) | old_blocknr, 0);
87c8e87f6e10fa Kent Overstreet 2026-01-22 331 end = POS((idx << 8) | old_blocknr, U64_MAX);
87c8e87f6e10fa Kent Overstreet 2026-01-22 332 }
87c8e87f6e10fa Kent Overstreet 2026-01-22 333
bde39b90107558 Kent Overstreet 2026-01-17 334 struct wb_maybe_flush last_flushed __cleanup(wb_maybe_flush_exit);
bde39b90107558 Kent Overstreet 2026-01-17 335 wb_maybe_flush_init(&last_flushed);
bde39b90107558 Kent Overstreet 2026-01-17 336
bde39b90107558 Kent Overstreet 2026-01-17 337 struct stripe_update_bucket_stats stats = {};
bde39b90107558 Kent Overstreet 2026-01-17 338
bde39b90107558 Kent Overstreet 2026-01-17 339 CLASS(disk_reservation, res)(c);
bde39b90107558 Kent Overstreet 2026-01-17 340
87c8e87f6e10fa Kent Overstreet 2026-01-22 341 try(for_each_btree_key_max(trans, bp_iter, btree, start, end, 0, bp_k, ({
bde39b90107558 Kent Overstreet 2026-01-17 342 if (bp_k.k->type != KEY_TYPE_backpointer)
bde39b90107558 Kent Overstreet 2026-01-17 343 continue;
bde39b90107558 Kent Overstreet 2026-01-17 344
bde39b90107558 Kent Overstreet 2026-01-17 345 struct bkey_s_c_backpointer bp = bkey_s_c_to_backpointer(bp_k);
bde39b90107558 Kent Overstreet 2026-01-17 346 if (bp.v->btree_id == BTREE_ID_stripes)
bde39b90107558 Kent Overstreet 2026-01-17 347 continue;
bde39b90107558 Kent Overstreet 2026-01-17 348
bde39b90107558 Kent Overstreet 2026-01-17 349 wb_maybe_flush_inc(&last_flushed);
0a97da6f3749b9 Kent Overstreet 2026-01-22 350 stripe_update_extent(trans, old_stripe, new_stripe,
0a97da6f3749b9 Kent Overstreet 2026-01-22 351 old_block, new_block, new_blocknr,
0a97da6f3749b9 Kent Overstreet 2026-01-22 352 bp, &stats, &res.r, &last_flushed);
bde39b90107558 Kent Overstreet 2026-01-17 353 })));
bde39b90107558 Kent Overstreet 2026-01-17 354
bde39b90107558 Kent Overstreet 2026-01-17 355 event_inc_trace(c, stripe_update_bucket, buf, ({
0a97da6f3749b9 Kent Overstreet 2026-01-22 356 prt_printf(&buf, "Updating block %u\n", new_blocknr);
0ca5116355ce27 Kent Overstreet 2026-01-25 357 bch2_bkey_val_to_text(&buf, c, bkey_i_to_s_c(&s->new_stripe.key.k_i));
bde39b90107558 Kent Overstreet 2026-01-17 358 prt_newline(&buf);
bde39b90107558 Kent Overstreet 2026-01-17 359
bde39b90107558 Kent Overstreet 2026-01-17 360 prt_printf(&buf, "bp_to_deleted:\t%u %u\n",
bde39b90107558 Kent Overstreet 2026-01-17 361 stats.nr_bp_to_deleted, stats.sectors_bp_to_deleted);
bde39b90107558 Kent Overstreet 2026-01-17 362 prt_printf(&buf, "no_match:\t%u %u\n",
bde39b90107558 Kent Overstreet 2026-01-17 363 stats.nr_no_match, stats.sectors_no_match);
bde39b90107558 Kent Overstreet 2026-01-17 364 prt_printf(&buf, "cached:\t%u %u\n",
bde39b90107558 Kent Overstreet 2026-01-17 365 stats.nr_cached, stats.sectors_cached);
bde39b90107558 Kent Overstreet 2026-01-17 366 prt_printf(&buf, "done:\t%u %u\n",
bde39b90107558 Kent Overstreet 2026-01-17 367 stats.nr_done, stats.sectors_done);
bde39b90107558 Kent Overstreet 2026-01-17 368 }));
bde39b90107558 Kent Overstreet 2026-01-17 369
bde39b90107558 Kent Overstreet 2026-01-17 370 return 0;
bde39b90107558 Kent Overstreet 2026-01-17 @371 }
bde39b90107558 Kent Overstreet 2026-01-17 372
:::::: The code at line 371 was first introduced by commit
:::::: bde39b90107558a6e5c84934716bf171ced1cef5 bcachefs: Split up data/ec.c
:::::: TO: Kent Overstreet <kent.overstreet@linux.dev>
:::::: CC: Kent Overstreet <kent.overstreet@linux.dev>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-06-26 9:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202606261712.ZltrHkIJ-lkp@intel.com \
--to=lkp@intel.com \
--cc=kent.overstreet@linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.