From: sashiko-bot@kernel.org
To: "Trevor Allison" <tallison@redhat.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf build: Add LDFLAGS to dlfilters .so link
Date: Fri, 26 Jun 2026 18:34:23 +0000 [thread overview]
Message-ID: <20260626183423.ADD211F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260626182739.53294-1-tallison@redhat.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding `$(LDFLAGS)` to the unconditionally built `dlfilters` shared library link rule breaks statically linked `perf` builds.
--
commit 18f2c24db710920618ef1d894a2b24abff4dbeb9
Author: Trevor Allison <tallison@redhat.com>
perf build: Add LDFLAGS to dlfilters .so link
Build-time linker flags were not applied when linking dlfilters.
Pass LDFLAGS for consistency with the other link rules.
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 476b8dcaef58c..f2294a6d89604 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -677,7 +677,7 @@ $(OUTPUT)dlfilters/%.o: dlfilters/%.c include/perf/perf_dlfilter.h
> .SECONDARY: $(DLFILTERS:.so=.o)
>
> $(OUTPUT)dlfilters/%.so: $(OUTPUT)dlfilters/%.o
> - $(QUIET_LINK)$(CC) $(EXTRA_CFLAGS) -shared -o $@ $<
> + $(QUIET_LINK)$(CC) $(LDFLAGS) $(EXTRA_CFLAGS) -shared -o $@ $<
[Severity: Low]
Does this break static builds of perf?
If a user builds perf statically by setting LDFLAGS="-static", this rule
will pass both "-static" and "-shared" to the linker. Since these flags are
mutually exclusive, this results in a fatal linker error.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260626182739.53294-1-tallison@redhat.com?part=1
prev parent reply other threads:[~2026-06-26 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 18:27 [PATCH] perf build: Add LDFLAGS to dlfilters .so link Trevor Allison
2026-06-26 18:34 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260626183423.ADD211F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tallison@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.