From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 841313F8EA2 for ; Fri, 26 Jun 2026 16:02:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782489760; cv=none; b=Ub3W1qGz0N/h0hzOdr2zQlY179G+8yfIevoldorTjRn1IEAC5qX0B7qRwHqLzvgPXzux1cbkOHMu+u8YR7tRhOwmeeQfpX+9NRS0XjZZp2qFqMHXnr2aWvMgsIcuRD/IQjZtpdiuAx3d0fpSLfm6fAWrJW/3OFmqu7bjuy2DVLM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782489760; c=relaxed/simple; bh=i7UN6NZmlk87N9g+MUwiSXXy8P7EDhqDhWuLVQnXrEg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=YMGFJ02fG8RKg4H8f17ROtTW2oFook44C8bSBNCopSNgXNgTaoo/GKqEa/s0quwNyROqCRSLOum6JU8ivpwZVhWDRxTgjKdKg9/koWsA5qkEeoxe7/x6Hg24ZuLFJDNhSZfWYhGR24oQJQfy2W/estqQ73/E3KkvIq8sLLWI6n0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fdRjeBD0; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fdRjeBD0" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-37da8b5540bso792736a91.0 for ; Fri, 26 Jun 2026 09:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782489758; x=1783094558; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=nB0N03rGfVExnQtJc3B4o4XRNHfaU9SsB4IMAxp8xSE=; b=fdRjeBD0YjvUKrEJ4BESbAsGDWS0wJjxvKFH22rDFQevIfjkTzFuE6Pcg4CgQk8eSL 9T/dZz3+Zcw1IB4rA726tASBs2svXd4HAlgBdHwN3yHCE7EMhljfgKnWGMcvVXkii53S NV9aFddQxRENflXmYnQtlWpHJenu5I3niqOV+W/W3DWrK3KG5Y3h+DkDFma5mVs5jEXT cZbbioEV4hBL/+8p472ufGQaUbfgL8R5hhzPi8XZ7vNooQI8i4a44WpKONOBfclgp4/2 3RixD+Kgc4byZ5/RqE2x7W14d3GtGOmdc8CFH67DIHc4+zfWRwfSijFgCtth5GLHQHhD uu5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782489758; x=1783094558; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nB0N03rGfVExnQtJc3B4o4XRNHfaU9SsB4IMAxp8xSE=; b=NzVd6IAhFfZRsm+gWRNajSSlIrq/q64GRJ6cbt6JyWeG11FDpw3U6dudMkkMlnDjmC ij8L07IGNjHBIjLAspQzL7VBcgkOM77Y7o6LGHp8e83MTerfsg0wCiV6vg7YPpbx0pFW VGLGoe5yRjW0AZjEkErek5UCYU8rC+EnOxUFBr1goolTP4XQdsJwvfyjTQxnE6Y4pb/X qZ0M73np/SUUABWd5I904YIeXe37Bt1wWazVDSuhnN7IxOzH7ogA9YZB78YusNmaxWjA Q/L9ZiWtNYujGCe5DAxEBDNCUcPtUiaZFdylopfm461/s+tOKzVJ1cy7swvV5vc3e+Co zK3w== X-Forwarded-Encrypted: i=1; AHgh+RqIFLDh2NQrQvjADODOySEf41miowHgco1lhH2gmnmrNIICSJHCCMrdjMpFXhhq6/fWPAKFxePvN6m2xh4=@vger.kernel.org X-Gm-Message-State: AOJu0YzHtmn6kONP9dwim+W4zKfqQLoC9U9/CCMJhICpe8adNkkHpB98 y3KQa2LHKG/QoHpuIANbumI2BZIE+rqmVtwonclHDFHEJNLr80OETjgR X-Gm-Gg: AfdE7cn/Ji8J0ieCZZHLlLSEqTH2I729k7aoloP9GV0b5Zw3+gsnK1PHPH8/eCOQf4U HwSH2A8FDmGoHjGj+UzndlSCDJ8FPJtyiLMWxktjxcan6jV+h1A+MqDXiCVA2IK87QrMrg67/uw fYTuSKEds19jrCOHALoW3rB2ARPODcGx3D5rJ6CPPm/qz5GZw4ELU63qAtQgUiXc6HkXNgwAcuG 16M7kkk/k9RhtNH98QGhRmOellgbFC79WVdCOWiuYzBO9M2Q+O2K3X0s6yEejqEODrieocwJvtV Ca5h4PsKjxVyKELukJs9pa4ivxStJ6OICFvotDNCtJNlo4ShAZ8i4zFss3zmiiorTF1wn1I9K1Q Ed/eYiqhBqev8P4fckxCaQKED/Oe0EAuzWDcCpNUqgQf/SOQeMr+qzkMbXAWBk4dGCKRG4qx/NI 8xeAukNyq0yEo8DWSIRue1yMf1T8ZrXXl161q0C0WAqXTZXcH/MrdWee8BjzeJQ+8wGJgag+WPM WkpExUOII4zSbbo6Q== X-Received: by 2002:a17:90b:5826:b0:36b:b4a1:2939 with SMTP id 98e67ed59e1d1-37dfa251534mr7269381a91.15.1782489757620; Fri, 26 Jun 2026 09:02:37 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.166.246.74]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37df3b657b3sm4149363a91.15.2026.06.26.09.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 09:02:36 -0700 (PDT) From: Felix Gu Date: Sat, 27 Jun 2026 00:02:29 +0800 Subject: [PATCH] spi: rzv2h-rspi: Fix DMA transfer error handling for signal interruption Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260627-rspi-v1-1-170c93ee14da@gmail.com> X-B4-Tracking: v=1; b=H4sIAJSiPmoC/yXMQQqAIBCF4avErBNMaBZdJVqYjTUtTJyKILx7V ssP/vduEEpMAl11Q6KThbdQ0NQVuMWGmRRPxWC0QY0GVZLIymvbokNqyVkoaUzk+fpu+uG3HON Kbn+3kPMDCWDmUmgAAAA= X-Change-ID: 20260626-rspi-f0a56c6e5eca To: Fabrizio Castro , Mark Brown , Cosmin Tanislav Cc: linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782489753; l=1399; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=i7UN6NZmlk87N9g+MUwiSXXy8P7EDhqDhWuLVQnXrEg=; b=ZO0A3r26F72IgnWv9fDl+OwU5EUI+bhNAfMK24m0PF6jGX+ZGxsDpS9yssQnG8VnanG6MC9RE FZE2QjPAY29AuBMSejrmJjxrpfWD6u0y5Db6QoWAH7r79JGIDv3kYFF X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= wait_event_interruptible_timeout() can return a negative error code when interrupted by a signal. The original code treated all non-zero return values as success, which would incorrectly synchronize DMA channels and return 0 instead of propagating the interruption error. Fixes: fa08b566860b ("spi: rzv2h-rspi: add support for DMA mode") Signed-off-by: Felix Gu --- drivers/spi/spi-rzv2h-rspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-rzv2h-rspi.c b/drivers/spi/spi-rzv2h-rspi.c index 0738d448160d..daa4239b0fe0 100644 --- a/drivers/spi/spi-rzv2h-rspi.c +++ b/drivers/spi/spi-rzv2h-rspi.c @@ -366,14 +366,14 @@ static int rzv2h_rspi_transfer_dma(struct rzv2h_rspi_priv *rspi, rzv2h_rspi_clear_all_irqs(rspi); ret = wait_event_interruptible_timeout(rspi->wait, rspi->dma_callbacked, HZ); - if (ret) { + if (ret > 0) { dmaengine_synchronize(rspi->controller->dma_tx); dmaengine_synchronize(rspi->controller->dma_rx); ret = 0; } else { dmaengine_terminate_sync(rspi->controller->dma_tx); dmaengine_terminate_sync(rspi->controller->dma_rx); - ret = -ETIMEDOUT; + ret = ret ?: -ETIMEDOUT; } enable_irq(rspi->irq_rx); --- base-commit: 30ffa8de54e5cc80d93fd211ca134d1764a7011f change-id: 20260626-rspi-f0a56c6e5eca Best regards, -- Felix Gu