From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m16.yeah.net (mail-m16.yeah.net [1.95.21.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB12A3939CE for ; Sat, 27 Jun 2026 09:57:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=1.95.21.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782554255; cv=none; b=oL+R3pwI6qCLLrsp6jk86NHIAv1fKm9v6du2Euh/VNbpFbF6D+481RGKp2Qe9tVCSgLiEVNTZqgq4yWIXLX1M1UDryWi7+IFVcx399sPk4SCQ9dS+W6GbORhREnXZdbgfPIvFy8PqcllaWBh0A2H6jrKFk1GUEkLL5dlrkJyL5s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782554255; c=relaxed/simple; bh=xARHP8yHjKWxT/hzqpA4gobAr/ysu19iWeERyYFiiJo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=f247HAR27zQ3AP5qShNyC1DpXEpQ/pKloq5W2XBPzoRGTzc8GuF6ze3Egs5oTkCGIphBK/3ZRS4GXHBO12XQY+vGLTJYZa/u7OlUPmjm4XeXGDK+ueZxG/Wqw24fwGArddbaKmEffH39PulYUZT5Nm6azcSY06g6rZwhDYrvk1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yeah.net; spf=pass smtp.mailfrom=yeah.net; dkim=pass (1024-bit key) header.d=yeah.net header.i=@yeah.net header.b=UjTLx4oI; arc=none smtp.client-ip=1.95.21.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yeah.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yeah.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=yeah.net header.i=@yeah.net header.b="UjTLx4oI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version: Content-Type; bh=cditTTZR98qCuukx7N1JBr9bmy5QU/HMtRkQnIKtEBw=; b=UjTLx4oIOzozLBA3ssScOuWhIDyB81Iy5o3Y0U4UPTvky5Eh0i4X3Qm2+8kMSY U1S8jtBwPfxxPDlhVQF/QiV6dXms7Tr+IDtO2Gi/Ca3KiysZSjQJF5Zpu6T3rMeI UngzsSUFbMImW5+SzqQbLgAFyxQ7efQJr7sZsWmJ8o7mE= Received: from zhang.. (unknown []) by gzsmtp3 (Coremail) with UTF8SMTPSA id M88vCgDnfzRnnj9qUg0MAw--.13884S4; Sat, 27 Jun 2026 17:57:01 +0800 (CST) From: Ziran Zhang To: markus.elfring@web.de Cc: airlied@gmail.com, alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org, christian.koenig@amd.com, dri-devel@lists.freedesktop.org, harry.wentland@amd.com, linux-kernel@vger.kernel.org, simona@ffwll.ch, siqueira@igalia.com, sunpeng.li@amd.com, zhangcoder@yeah.net Subject: Re: [PATCH] drm/amd/display: Remove redundant NULL check before kfree() in mod_power_create() Date: Sat, 27 Jun 2026 17:54:54 +0800 Message-ID: <20260627095616.4479-1-zhangcoder@yeah.net> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CM-TRANSID:M88vCgDnfzRnnj9qUg0MAw--.13884S4 X-Coremail-Antispam: 1Uf129KBjvdXoWrZrWDWFy7KFyfuryDtFWUArb_yoW3XFcEkw 4ktFn7uw40yrW8Awnayr43Wrs0kw47Cas5Gw1FyF9aqry3Jws7Zrs7GFn5Aw1rZF18CF4D Cr15Ar10vFyxWjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xR_UUUUUUUUU== X-CM-SenderInfo: x2kd0wpfrgv2o61htxgoqh3/1tbiIA4t7Wo-nm7sqwAA3M On Sat, 27 Jun 2026 11:43:25 +0200, Markus Elfring wrote: > … > > +++ b/drivers/gpu/drm/amd/display/modules/power/power.c > > @@ -270,12 +270,10 @@ struct mod_power *mod_power_create(struct dc *dc, > > fail_bad_brightness_range: > … > > fail_construct: > > for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++) { > > - if (core_power->map[i].psr_context) > > - kfree(core_power->map[i].psr_context); > > + kfree(core_power->map[i].psr_context); > > } > May curly brackets be omitted here? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.1#n197 > > Regards, > Markus Yes, you're right. I will send a v2 with this fixed. Regards, Ziran Zhang