From: Ziran Zhang <zhangcoder@yeah.net>
To: "Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Markus Elfring" <Markus.Elfring@web.de>
Cc: Rodrigo Siqueira <siqueira@igalia.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Ziran Zhang <zhangcoder@yeah.net>
Subject: [PATCH v3] drm/amd/display: Remove redundant NULL check before kfree() in mod_power_create()
Date: Sat, 27 Jun 2026 21:13:54 +0800 [thread overview]
Message-ID: <20260627131354.5811-1-zhangcoder@yeah.net> (raw)
In-Reply-To: <20260627100945.5826-1-zhangcoder@yeah.net>
kfree() safely handles NULL pointers, so there is no need to check for
NULL before calling kfree().
Remove redundant NULL check.
Found by Coccinelle ifnullfree script.
Signed-off-by: Ziran Zhang <zhangcoder@yeah.net>
---
Changes in v3:
- Add parentheses to "kfree" in subject line for consistency.
.../gpu/drm/amd/display/modules/power/power.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/power/power.c b/drivers/gpu/drm/amd/display/modules/power/power.c
index 5659a38b3..97889867a 100644
--- a/drivers/gpu/drm/amd/display/modules/power/power.c
+++ b/drivers/gpu/drm/amd/display/modules/power/power.c
@@ -270,13 +270,11 @@ struct mod_power *mod_power_create(struct dc *dc,
fail_bad_brightness_range:
fail_alloc_backlight_array:
for (inst = 0; inst < edp_num; inst++)
- if (core_power->bl_prop[inst].backlight_lut)
- kfree(core_power->bl_prop[inst].backlight_lut);
+ kfree(core_power->bl_prop[inst].backlight_lut);
fail_construct:
- for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++) {
- if (core_power->map[i].psr_context)
- kfree(core_power->map[i].psr_context);
- }
+ for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++)
+ kfree(core_power->map[i].psr_context);
+
kfree(core_power->map);
fail_alloc_map:
@@ -295,8 +293,7 @@ void mod_power_destroy(struct mod_power *mod_power)
MOD_POWER_TO_CORE(mod_power);
for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++)
- if (core_power->map[i].psr_context)
- kfree(core_power->map[i].psr_context);
+ kfree(core_power->map[i].psr_context);
for (i = 0; i < core_power->num_entities; i++)
if (core_power->map[i].stream)
@@ -305,8 +302,7 @@ void mod_power_destroy(struct mod_power *mod_power)
kfree(core_power->map);
for (i = 0; i < MAX_NUM_EDP; i++)
- if (core_power->bl_prop[i].backlight_lut)
- kfree(core_power->bl_prop[i].backlight_lut);
+ kfree(core_power->bl_prop[i].backlight_lut);
kfree(core_power);
}
--
2.43.0
prev parent reply other threads:[~2026-06-27 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-27 9:26 [PATCH] drm/amd/display: Remove redundant NULL check before kfree in mod_power_create() Ziran Zhang
2026-06-27 9:43 ` [PATCH] drm/amd/display: Remove redundant NULL check before kfree() " Markus Elfring
2026-06-27 9:54 ` Ziran Zhang
2026-06-27 10:09 ` [PATCH v2] drm/amd/display: Remove redundant NULL check before kfree " Ziran Zhang
2026-06-27 11:53 ` Markus Elfring
2026-06-27 13:07 ` [PATCH] drm/amd/display: Remove redundant NULL check before kfree() " Ziran Zhang
2026-06-27 13:13 ` Ziran Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260627131354.5811-1-zhangcoder@yeah.net \
--to=zhangcoder@yeah.net \
--cc=Markus.Elfring@web.de \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.