Re: [RFC PATCH bpf-next 12/12] selftests/bpf: Add tests for bpf SDT probe

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect relative include path for `bpf_sdt.h` causes compilation failure.
--

commit e66dde4c8db25d960e4cc2ec8a78a2fbb3113bee
Author: Xu Kuohai <xukuohai@huawei.com>

selftests/bpf: Add tests for bpf SDT probe

This commit adds selftests for BPF SDT probe sites and observers. It
includes tests for argument checking of the observer program, multiple
target programs in the same ELF, and programs with subprograms.

> diff --git a/tools/testing/selftests/bpf/progs/bpf_sdt_target.c b/tools/testing/selftests/bpf/progs/bpf_sdt_target.c
> new file mode 100644
> index 0000000000000..e1c14b9d7e9a2
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/bpf_sdt_target.c
> @@ -0,0 +1,34 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include "vmlinux.h"
> +#include <bpf/bpf_helpers.h>
> +#include <bpf/bpf_tracing.h>
> +#include "../../../../tools/lib/bpf/bpf_sdt.h"

[Severity: Low]
Will this relative include path cause a compilation failure?

Starting from tools/testing/selftests/bpf/progs/, going up four directories
with ../../../../ lands in the tools/ directory. Adding tools/lib/bpf/bpf_sdt.h
makes the resolved path tools/tools/lib/bpf/bpf_sdt.h, which doesn't exist.

Should this be ../../../../lib/bpf/bpf_sdt.h or perhaps just <bpf/bpf_sdt.h>?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1782571533.git.xukuohai@huawei.com?part=12