Re: [PATCH v4 3/3] iio: dac: m62332: Use guard(mutex) for locking

[Joshua Crofts <joshua.crofts1@gmail.com>]

On Sat, 27 Jun 2026 10:25:30 -0300
Erick Henrique <erick.henrique.rodrigues@usp.br> wrote:

> Replace mutex_lock()/mutex_unlock() calls with guard(mutex)() to
> simplify locking and make cleanup automatic when the lock goes out
> of scope. Also simplify the i2c_master_send() error handling by
> using sequential early returns instead of a combined condition.
> 
> Signed-off-by: Erick Henrique <erick.henrique.rodrigues@usp.br>
> ---
>  drivers/iio/dac/m62332.c | 17 +++++------------
>  1 file changed, 5 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/iio/dac/m62332.c b/drivers/iio/dac/m62332.c
> index ee8fd3a71315..10ff6727b76c 100644
> --- a/drivers/iio/dac/m62332.c
> +++ b/drivers/iio/dac/m62332.c
> @@ -47,33 +47,26 @@ static int m62332_set_value(struct iio_dev *indio_dev, u8 val, int channel)
>  	outbuf[0] = channel;
>  	outbuf[1] = val;
>  
> -	mutex_lock(&data->mutex);
> +	guard(mutex)(&data->mutex);

You're missing #include <linux/cleanup.h>.

-- 
Kind regards

CJD