Re: [PATCH] MAINTAINERS: s/SeongJae/SJ/

[SJ Park <sj@kernel.org>]

On Sat, 27 Jun 2026 20:00:28 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Unintended Code Deletion / Copyright Removal

These are intended change.  If someone thinks this is problematic or wants the
commit message to be updated for more clarification, please let me know.

> --
> 
> commit 7824bc7fc9af6bcdbf6c2338af2a70179e7f0325
> Author: SJ Park <sj@kernel.org>
> 
> MAINTAINERS: s/SeongJae/SJ/
> 
> This commit changes instances of the author's name from "SeongJae" to the
> preferred name "SJ" to avoid confusion.
> 
> > diff --git a/include/linux/damon.h b/include/linux/damon.h
> > index 6f7edb3590ef9..8bb28d5682dd8 100644
> > --- a/include/linux/damon.h
> > +++ b/include/linux/damon.h
> > @@ -1,8 +1,6 @@
> >  /* SPDX-License-Identifier: GPL-2.0 */
> >  /*
> >   * DAMON api
> > - *
> > - * Author: SeongJae Park <sj@kernel.org>
> >   */
> >  
> >  #ifndef _DAMON_H_
> 
> [Severity: Medium]
> Was it intentional to completely delete the Author attribution here instead of 
> updating it to SJ Park?

Yes, it is intentional.  We can show who wrote it using 'git log'.

> 
> [ ... ]
> 
> > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
> > index 2e95e3bac774d..a9e187158067d 100644
> > --- a/mm/damon/sysfs.c
> > +++ b/mm/damon/sysfs.c
> > @@ -1,8 +1,6 @@
> >  // SPDX-License-Identifier: GPL-2.0
> >  /*
> >   * DAMON sysfs Interface
> > - *
> > - * Copyright (c) 2022 SeongJae Park <sj@kernel.org>
> >   */
> >  
> >  #include <linux/pid.h>
> 
> [Severity: Medium]
> Does this code intentionally drop the copyright notice rather than updating the
> name? The commit message only mentions substituting the name.

Ditto.

> 
> [ ... ]
> 
> > diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
> > index 1cfb8c176b873..fcf7c7fadb5fe 100644
> > --- a/mm/damon/tests/core-kunit.h
> > +++ b/mm/damon/tests/core-kunit.h
> > @@ -1,10 +1,6 @@
> >  /* SPDX-License-Identifier: GPL-2.0 */
> >  /*
> >   * Data Access Monitor Unit Tests
> > - *
> > - * Copyright 2019 Amazon.com, Inc. or its affiliates.  All rights reserved.
> > - *
> > - * Author: SeongJae Park <sj@kernel.org>
> >   */
> >  
> >  #ifdef CONFIG_DAMON_KUNIT_TEST
> 
> [Severity: Medium]
> Is it intended to remove the Amazon.com copyright notice entirely along with the
> Author line? It looks like this might have been an accidental deletion while
> searching and replacing the name.

Yes, intentional.  People can find I was using amazon corporate email account
when I submitted the patch.

> 
> [ ... ]
> 
> > diff --git a/mm/damon/tests/vaddr-kunit.h b/mm/damon/tests/vaddr-kunit.h
> > index 563fbc7e3f448..61f844336ffb5 100644
> > --- a/mm/damon/tests/vaddr-kunit.h
> > +++ b/mm/damon/tests/vaddr-kunit.h
> > @@ -1,10 +1,6 @@
> >  /* SPDX-License-Identifier: GPL-2.0 */
> >  /*
> >   * Data Access Monitor Unit Tests
> > - *
> > - * Copyright 2019 Amazon.com, Inc. or its affiliates.  All rights reserved.
> > - *
> > - * Author: SeongJae Park <sj@kernel.org>
> >   */
> >  
> >  #ifdef CONFIG_DAMON_VADDR_KUNIT_TEST
> 
> [Severity: Medium]
> Similar to core-kunit.h, is it correct to delete the Amazon copyright notice
> here as well?

Ditto.


Thanks,
SJ

[...]